Fix Code Related PT Run Accessibility issues (#5610)

* set the name automation properties for the result elements

* Added name properties to search box

* removed the name for the grid

* localized the automation property names of the launcher control

* Localized the automation name property for the result list

* Uncommented out the Hide() function which was commented out to run Accessibility Insights

* modified resources from static to dynamic

* reverted access modifier to internal as we are no longer using this

* updated csproj file
This commit is contained in:
Alekhya 2020-08-05 13:43:47 -07:00 committed by GitHub
parent 4b72b291ef
commit 30b65028fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
22 changed files with 248 additions and 13 deletions

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Opdatereringsfiler</system:String>
<system:String x:Key="update_wox_update_upadte_description">Opdateringsbeskrivelse</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Aktualisiere Dateien</system:String>
<system:String x:Key="update_wox_update_upadte_description">Aktualisierungbeschreibung</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -142,4 +142,16 @@
<system:String x:Key="update_wox_update_files">Update files</system:String>
<system:String x:Key="update_wox_update_upadte_description">Update description</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -134,4 +134,16 @@
<system:String x:Key="update_wox_update_files">Fichiers mis à jour</system:String>
<system:String x:Key="update_wox_update_upadte_description">Description de la mise à jour</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -137,4 +137,16 @@
<system:String x:Key="update_wox_update_files">File aggiornati</system:String>
<system:String x:Key="update_wox_update_upadte_description">Descrizione aggiornamento</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -140,4 +140,16 @@
<system:String x:Key="update_wox_update_files">更新ファイル一覧</system:String>
<system:String x:Key="update_wox_update_upadte_description">アップデートの詳細</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -132,4 +132,16 @@
<system:String x:Key="update_wox_update_files">업데이트 파일</system:String>
<system:String x:Key="update_wox_update_upadte_description">업데이트 설명</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -137,4 +137,16 @@
<system:String x:Key="update_wox_update_files">Oppdateringsfiler</system:String>
<system:String x:Key="update_wox_update_upadte_description">Oppdateringsbeskrivelse</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Update bestanden</system:String>
<system:String x:Key="update_wox_update_upadte_description">Update beschrijving</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Aktualizuj pliki</system:String>
<system:String x:Key="update_wox_update_upadte_description">Opis aktualizacji</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -137,4 +137,16 @@
<system:String x:Key="update_wox_update_files">Atualizar arquivos</system:String>
<system:String x:Key="update_wox_update_upadte_description">Atualizar descrição</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Обновить файлы</system:String>
<system:String x:Key="update_wox_update_upadte_description">Описание обновления</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -138,4 +138,16 @@
<system:String x:Key="update_wox_update_files">Aktualizovať súbory</system:String>
<system:String x:Key="update_wox_update_upadte_description">Aktualizovať popis</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -137,4 +137,16 @@
<system:String x:Key="update_wox_update_files">Ažuriraj datoteke</system:String>
<system:String x:Key="update_wox_update_upadte_description">Opis ažuriranja</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -141,4 +141,16 @@
<system:String x:Key="update_wox_update_files">Güncellenecek dosyalar</system:String>
<system:String x:Key="update_wox_update_upadte_description">Güncelleme açıklaması</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">Оновити файли</system:String>
<system:String x:Key="update_wox_update_upadte_description">Опис оновлення</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -135,4 +135,16 @@
<system:String x:Key="update_wox_update_files">更新文件</system:String>
<system:String x:Key="update_wox_update_upadte_description">更新日志</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -128,4 +128,16 @@
<system:String x:Key="update_wox_update_files">更新檔案</system:String>
<system:String x:Key="update_wox_update_upadte_description">更新日誌</system:String>
<!--Automation Properties-->
<system:String x:Key="AppIcon">Application Icon</system:String>
<system:String x:Key="ContextMenuItem">Context Menu Item</system:String>
<system:String x:Key="ContextMenuItemAdditionalInformation">Context Menu Item Additional Information</system:String>
<system:String x:Key="ContextMenuIcon">Context Menu Icon</system:String>
<system:String x:Key="ContextMenuItemsCollection">Context Menu Items Collection</system:String>
<system:String x:Key="Query">Query</system:String>
<system:String x:Key="Results">Results</system:String>
<system:String x:Key="SearchIcon">Search Icon</system:String>
<system:String x:Key="Subtitle">Subtitle</system:String>
<system:String x:Key="Title">Title</system:String>
</ResourceDictionary>

View File

@ -92,6 +92,7 @@
-->
<TextBox
AutomationProperties.Name="{DynamicResource Query}"
x:Name="QueryTextBox"
x:FieldModifier="public"
Canvas.ZIndex="0"
@ -103,6 +104,7 @@
/>
<TextBlock
AutomationProperties.Name="{DynamicResource SearchIcon}"
Grid.Column="1"
Text="&#xE721;"
FontFamily="Segoe MDL2 Assets"

View File

@ -127,6 +127,21 @@
<ProjectReference Include="..\Wox.Plugin\Wox.Plugin.csproj" />
</ItemGroup>
<ItemGroup>
<Compile Update="Properties\Resources.Designer.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>Resources.resx</DependentUpon>
</Compile>
</ItemGroup>
<ItemGroup>
<EmbeddedResource Update="Properties\Resources.resx">
<Generator>ResXFileCodeGenerator</Generator>
<LastGenOutput>Resources.Designer.cs</LastGenOutput>
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<None Update="Images\Browser.png">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

View File

@ -8,7 +8,7 @@
// </auto-generated>
//------------------------------------------------------------------------------
namespace Wox.Properties {
namespace PowerLauncher.Properties {
using System;
@ -39,7 +39,7 @@ namespace Wox.Properties {
internal static global::System.Resources.ResourceManager ResourceManager {
get {
if (object.ReferenceEquals(resourceMan, null)) {
global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Wox.Properties.Resources", typeof(Resources).Assembly);
global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("PowerLauncher.Properties.Resources", typeof(Resources).Assembly);
resourceMan = temp;
}
return resourceMan;
@ -63,9 +63,9 @@ namespace Wox.Properties {
/// <summary>
/// Looks up a localized resource of type System.Drawing.Icon similar to (Icon).
/// </summary>
internal static System.Drawing.Icon app {
internal static System.Drawing.Icon placeholderLauncher {
get {
object obj = ResourceManager.GetObject("app", resourceCulture);
object obj = ResourceManager.GetObject("placeholderLauncher", resourceCulture);
return ((System.Drawing.Icon)(obj));
}
}

View File

@ -160,13 +160,14 @@
ScrollViewer.VerticalScrollBarVisibility="Auto"
SelectionMode="Single"
SelectedIndex="{Binding Results.SelectedIndex, Mode=TwoWay}"
ItemContainerStyle="{StaticResource ResultsListViewItemContainerStyle}">
ItemContainerStyle="{StaticResource ResultsListViewItemContainerStyle}"
AutomationProperties.Name="{DynamicResource Results}">
<!--AllowFocusOnInteraction="False"
IsItemClickEnabled="True"-->
<!--Style="{StaticResource ListViewNoAnimations}"-->
<ListView.ItemTemplate>
<DataTemplate >
<DataTemplate>
<Grid
Height="72"
Width="642"
@ -207,10 +208,11 @@
</StackPanel>
</ToolTip>
</Grid.ToolTip>
<Image x:Name="AppIcon" Height="36" MaxWidth="56" Grid.RowSpan="2" Margin="-6,-2,0,0" HorizontalAlignment="Center" Source="{Binding Image}" />
<TextBlock x:Name="Title" Grid.Column="1" Text="{Binding Result.Title}" FontWeight="SemiBold" FontSize="20" Margin="0,0,0,-2" VerticalAlignment="Bottom"/>
<TextBlock x:Name="Path" Grid.Column="1" Text= "{Binding Result.SubTitle}" Grid.Row="1" Foreground="{DynamicResource SecondaryTextForeground}" Margin="0,2,0,0" VerticalAlignment="Top"/>
<Image AutomationProperties.Name="{DynamicResource AppIcon}" x:Name="AppIcon" Height="36" MaxWidth="56" Grid.RowSpan="2" Margin="-6,-2,0,0" HorizontalAlignment="Center" Source="{Binding Image}" />
<TextBlock AutomationProperties.Name="{DynamicResource Title}" x:Name="Title" Grid.Column="1" Text="{Binding Result.Title}" FontWeight="SemiBold" FontSize="20" Margin="0,0,0,-2" VerticalAlignment="Bottom"/>
<TextBlock AutomationProperties.Name="{DynamicResource Subtitle}" x:Name="Path" Grid.Column="1" Text= "{Binding Result.SubTitle}" Grid.Row="1" Foreground="{DynamicResource SecondaryTextForeground}" Margin="0,2,0,0" VerticalAlignment="Top"/>
<ListView
AutomationProperties.Name="{DynamicResource ContextMenuItemsCollection}"
HorizontalAlignment="Right"
VerticalAlignment="Center"
Background="Transparent"
@ -234,14 +236,14 @@
</ItemsControl.ItemsPanel>
<ListView.ItemTemplate>
<DataTemplate>
<Button Style="{StaticResource IconButtonStyle}" Command="{Binding Command}" VerticalAlignment="Center" Height="42" Width="42" BorderThickness="1" >
<Button AutomationProperties.Name="{DynamicResource ContextMenuItem}" Style="{StaticResource IconButtonStyle}" Command="{Binding Command}" VerticalAlignment="Center" Height="42" Width="42" BorderThickness="1" >
<ToolTipService.ToolTip>
<ToolTip >
<TextBlock Text="{Binding Title}" Foreground="{DynamicResource ToolTipForegroundBrushKey}" Margin="8,5" FontSize="12"/>
<TextBlock AutomationProperties.Name="{DynamicResource ContextMenuItemAdditionalInformation}" Text="{Binding Title}" Foreground="{DynamicResource ToolTipForegroundBrushKey}" Margin="8,5" FontSize="12"/>
</ToolTip>
</ToolTipService.ToolTip>
<Button.Content>
<TextBlock FontFamily="{Binding FontFamily}" FontSize="16" Text="{Binding Glyph}"/>
<TextBlock AutomationProperties.Name="{DynamicResource ContextMenuIcon}" FontFamily="{Binding FontFamily}" FontSize="16" Text="{Binding Glyph}"/>
</Button.Content>
</Button>
</DataTemplate>