mirror/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2024-11-27 14:59:16 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[Peek]Fixed crash caused by COM object double release in runner (#33427)

Browse Source
This commit is contained in:
Ani 2024-06-19 17:01:17 +02:00 committed by GitHub
parent c252d87573
commit 5c631bd2c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/modules/peek/peek/dllmain.cpp
View File

@ -187,7 +187,7 @@ private:
}
// Enumerate all Shell Windows to compare the window handle against.
IUnknownPtr spEnum{};
IUnknownPtr spEnum{}; // _com_ptr_t; no Release required.
result = spShellWindows->_NewEnum(&spEnum);
if (result != S_OK || spEnum == nullptr)
{
@ -195,7 +195,7 @@ private:
return true; // Might as well assume it's possible it's an explorer window.
}
IEnumVARIANTPtr spEnumVariant{};
IEnumVARIANTPtr spEnumVariant{}; // _com_ptr_t; no Release required.
result = spEnum.QueryInterface(__uuidof(spEnumVariant), &spEnumVariant);
if (result != S_OK || spEnumVariant == nullptr)
{
@ -219,8 +219,6 @@ private:
{
VariantClear(&variantElement);
spWebBrowserApp->Release();
spEnumVariant->Release();
spEnum->Release();
return true;
}
}
@ -229,8 +227,6 @@ private:
VariantClear(&variantElement);
}
spEnumVariant->Release();
spEnum->Release();
return false;
}