[QuickAccent]Support the Hebrew character set (#22712)

Co-authored-by: אביתר אסתרסון <79063413+EvyatarEsterson@users.noreply.github.com>
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
This commit is contained in:
אביתר 2023-01-09 16:07:35 +02:00 committed by GitHub
parent 3fb707f78d
commit 9baaaefc5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 0 deletions

View File

@ -21,6 +21,7 @@ namespace PowerAccent.Core
EST,
FR,
HR,
HE,
HU,
IS,
IT,
@ -56,6 +57,7 @@ namespace PowerAccent.Core
Language.EST => GetDefaultLetterKeyEST(letter), // Estonian
Language.FR => GetDefaultLetterKeyFR(letter), // French
Language.HR => GetDefaultLetterKeyHR(letter), // Croatian
Language.HE => GetDefaultLetterKeyHE(letter), // Hebrew
Language.HU => GetDefaultLetterKeyHU(letter), // Hungarian
Language.IS => GetDefaultLetterKeyIS(letter), // Iceland
Language.IT => GetDefaultLetterKeyIT(letter), // Italian
@ -448,6 +450,21 @@ namespace PowerAccent.Core
};
}
// Hebrew
private static string[] GetDefaultLetterKeyHE(LetterKey letter)
{
return letter switch
{
LetterKey.VK_A => new string[] { "שׂ", "שׁ" },
LetterKey.VK_G => new string[] { "ױ" },
LetterKey.VK_H => new string[] { "ײ" },
LetterKey.VK_U => new string[] { "וֹ", "וּ" },
LetterKey.VK_Y => new string[] { "װ" },
LetterKey.VK_COMMA => new string[] { "”", "״", "־", "", "֫", "ֽ", "ֿ" },
_ => Array.Empty<string>(),
};
}
// Hungarian
private static string[] GetDefaultLetterKeyHU(LetterKey letter)
{

View File

@ -2725,6 +2725,9 @@ Activate by holding the key for the character you want to add an accent to, then
<data name="QuickAccent_SelectedLanguage_German.Content" xml:space="preserve">
<value>German</value>
</data>
<data name="QuickAccent_SelectedLanguage_Hebrew.Content" xml:space="preserve">
<value>Hebrew</value>
</data>
<data name="QuickAccent_SelectedLanguage_French.Content" xml:space="preserve">
<value>French</value>
</data>

View File

@ -34,6 +34,7 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
"EST",
"FR",
"DE",
"HE",
"HU",
"IS",
"IT",

View File

@ -71,6 +71,7 @@
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Estonian" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_French" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_German" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Hebrew" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Hungarian" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Icelandic" />
<ComboBoxItem x:Uid="QuickAccent_SelectedLanguage_Italian" />