Run settings elevated when PT is running elevated (#22815)

* Run settings elevated when PT is running elevated

* Address PR comment
This commit is contained in:
Stefan Markovic 2022-12-16 15:14:50 +01:00 committed by GitHub
parent f574694cc0
commit a6c13dcfbe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -383,17 +383,22 @@ void run_settings_window(bool show_oobe_window, bool show_scoobe_window, std::op
BOOL process_created = false;
if (is_process_elevated())
{
auto res = RunNonElevatedFailsafe(executable_path, executable_args, get_module_folderpath());
process_created = res.has_value();
if (process_created)
{
process_info.dwProcessId = res->processID;
process_info.hProcess = res->processHandle.release();
g_isLaunchInProgress = false;
}
}
// Commented out to fix #22659
// Running settings non-elevated and modules elevated when PowerToys is running elevated results
// in settings making changes in one file (non-elevated user dir) and modules are reading settings
// from different (elevated user) dir
//if (is_process_elevated())
//{
// auto res = RunNonElevatedFailsafe(executable_path, executable_args, get_module_folderpath());
// process_created = res.has_value();
// if (process_created)
// {
// process_info.dwProcessId = res->processID;
// process_info.hProcess = res->processHandle.release();
// g_isLaunchInProgress = false;
// }
//}
if (FALSE == process_created)
{