From bad435bb26edfe6f4744c94bf4247133b0744989 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 17 Mar 2022 13:19:16 -0400 Subject: [PATCH] [spellcheck]Spelling cleanup (#17099) Co-authored-by: Josh Soref --- .github/actions/spell-check/expect.txt | 39 +------------------ .github/actions/spell-check/patterns.txt | 19 ++++++++- .pipelines/release.yml | 2 +- .../ShortcutGuide/ShortcutGuide/d2d_window.h | 2 +- .../KeyboardManagerEditorLibrary/KeyDelay.h | 2 +- .../ShortcutControl.cpp | 2 +- .../OSLevelShortcutRemappingTests.cpp | 6 +-- .../Programs/Win32Program.cs | 8 ++-- .../Properties/Resources.Designer.cs | 8 ++-- .../PowerLauncher/Properties/Resources.resx | 4 +- .../launcher/PowerLauncher/SettingsReader.cs | 2 +- .../HTMLParsingExtensionTest.cs | 12 +++--- .../Icons/On-NotInUse Dark.svg | 2 +- .../Icons/On-NotInUse Light.svg | 2 +- .../VideoConferenceModule/Toolbar.cpp | 6 +-- 15 files changed, 47 insertions(+), 69 deletions(-) diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index e173062fbe..6ec373861c 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -10,7 +10,6 @@ accctrl Acceleratorkeys ACCEPTFILES ACCESSDENIED -accessibile accessibilityinsights Acl aclapi @@ -30,7 +29,6 @@ AFeature AFX AGGREGATABLE AHybrid -Aissue Akrotiri Aktobe ALarger @@ -45,7 +43,6 @@ altform alwaysontop amd AMF -Amicrosoft AModifier AMPROPERTY AMPROPSETID @@ -56,7 +53,6 @@ ansicolor ANull AOC aocfnapldcnfbofgmbbllojgocaelgdd -Aopen APARTMENTTHREADED APeriod api @@ -137,19 +133,15 @@ AYUV backend backtracer BADD -BAEC -BAF bak Bashkortostan Bayan bbwe bck Bcl -BEEE Belarus betadele betsegaw -BFB BGR bgra BGSOUNDS @@ -176,7 +168,6 @@ BNumber Bokm BOKMAL boolalpha -Boostrapper bootstrapper BOOTSTRAPPERINSTALLFOLDER Bopomofo @@ -196,7 +187,6 @@ Bto buf BUFSIZE bugreport -Buid BUILDARCH buildtransitive Burkina @@ -206,7 +196,6 @@ bytearray Caiguna CALG callbackptr -Camer Cangjie CANRENAME CAPTURECHANGED @@ -215,7 +204,6 @@ CAtl cch CCom CContext -CDBECF cdecl CDeclaration CDEF @@ -375,7 +363,6 @@ cxxopts cyberrex CYSMICON CYVIRTUALSCREEN -czf cziplib Dac dacl @@ -388,8 +375,6 @@ Datavalue DATAW davidegiacometti Dayof -DBCD -DBDA Dbg Dbghelp DBLCLKS @@ -426,7 +411,6 @@ depersist deprioritized deps deref -deseralization deserialization deserialize deserialized @@ -442,7 +426,6 @@ devenum DEVMON devpkey DEVSOURCE -DFactory dhcp diffing difftime @@ -472,24 +455,19 @@ doctype DONOTROUND DONTVALIDATEPATH dotnet -DOverlay DOWNLOADONLY DPICHANGED DPIs DPolicy -DPopup DPSAPI DQTAT DQTYPE DRAWFRAME drawingcolor dreamsofameaningfullife -DRect drivedetectionwarning dshow dst -DSVG -DText dutil DVASPECT DVASPECTINFO @@ -499,7 +477,6 @@ dvr DVSD DVSL DVTARGETDEVICE -DWindow DWINRT dwm dwmapi @@ -519,18 +496,13 @@ dwrite dxgi dxgiformat dxguid -EAF -EBA -EBE ecount -ededf EDITKEYBOARD editkeyboardwindow editorconfig EDITSHORTCUTS editshortcutswindow EFile -egistry ekus elif elseif @@ -542,7 +514,6 @@ endif endl endpointvolume endregion -Enque ENTERSIZEMOVE entrypoint ENU @@ -598,10 +569,7 @@ FANCYZONESEDITOR Farbraum Faroe FARPROC -FBF -FCCD fdw -FEEBD feimage ffaa fff @@ -638,7 +606,6 @@ FORCEMINIMIZE FORCEOFFLINE foreach formatetc -FPower FRAMECHANGED FRAMEDOWNLOAD franky @@ -1465,7 +1432,6 @@ OWNDC PACL pagos PAINTSTRUCT -PAIT PALEBLUE PALETTEWINDOW paramref @@ -1667,7 +1633,6 @@ regex REGFILTER REGFILTERPINS REGISTERCLASSFAILED -Registery registrypath regkey REGPINTYPES @@ -2062,7 +2027,6 @@ tracelogging traies transcoded Transnistria -transparrent TRAYMOUSEMESSAGE triaging TRK @@ -2238,7 +2202,6 @@ Whichdoes whitespaces WIC wifi -wih wiki wikipedia wil @@ -2380,4 +2343,4 @@ zoneset ZONESETCHANGE Zoneszonabletester Zonev -zzz \ No newline at end of file +zzz diff --git a/.github/actions/spell-check/patterns.txt b/.github/actions/spell-check/patterns.txt index 66274dccd7..06b64dcd10 100644 --- a/.github/actions/spell-check/patterns.txt +++ b/.github/actions/spell-check/patterns.txt @@ -12,6 +12,10 @@ https?://(?:(?:www\.|)youtube\.com|youtu.be)/[-a-zA-Z0-9?&=]* # msdn \b(?:download\.visualstudio|docs|msdn)\.microsoft\.com/[-_a-zA-Z0-9()=./]* +# medium +link\.medium\.com/[a-zA-Z0-9]+ +\bmedium\.com/\@[^/]+/[-\w]+ + publicKeyToken=(['"]|)[0-9a-f]+\g{-1} \@sha256:[0-9a-f]{64}\b @@ -19,12 +23,15 @@ publicKeyToken=(['"]|)[0-9a-f]+\g{-1} (['"])data:.*?\g{-1} data:[-a-zA-Z=;:/0-9+]*,\S* -# uuid: -L?(["']|[-<({>]|\b)[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}(?:\g{-1}|[<})>]) +# uuid: (or CompGUIDPrefix) +L?(["']|[-<({>]|\b)[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{10,12}(?:\g{-1}|[<})>]) # c99 hex digits (not the full format, just one I've seen) 0x[0-9a-fA-F](?:\.[0-9a-fA-F]*|)[pP] +# URL escaped characters +\%[0-9A-F]{2} + # wregex std::wregex\(L"[^"]*"\) @@ -51,6 +58,8 @@ TestCase\("[^"]+" \\netstandard \\notifications \\recyclebin +\\Registry +\\registry \\reinstall \\Resize \\resource @@ -78,8 +87,14 @@ TestCase\("[^"]+" # TestCase strings intentionally have non dictionary items \[TestCase\(new string.*\] +# D2D +D2D + # marker for ignoring a comment to the end of the line ^.*/\* #no-spell-check-line \*/.*$ // #no-spell-check.*$ http://tes/ + +# tar arguments +\b(?:\\n|)tar(?:\s+-[a-zA-Z]+|\s[a-z]+)+ diff --git a/.pipelines/release.yml b/.pipelines/release.yml index 4e89bf1ab0..d7d899aacf 100644 --- a/.pipelines/release.yml +++ b/.pipelines/release.yml @@ -312,7 +312,7 @@ jobs: script: '.\installer\packages\WiX.3.11.2\tools\insignia.exe -ab installer\engine.exe installer\PowerToysSetup\$(BuildPlatform)\$(BuildConfiguration)\PowerToysSetup-${{ parameters.versionNumber }}-$(BuildPlatform).exe -o installer\PowerToysSetup\$(BuildPlatform)\$(BuildConfiguration)\PowerToysSetup-${{ parameters.versionNumber }}-$(BuildPlatform).exe' - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 - displayName: Sign Boostrapper + displayName: Sign Bootstrapper inputs: ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection' FolderPath: 'installer/PowerToysSetup/$(BuildPlatform)\$(BuildConfiguration)' diff --git a/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h b/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h index d343719a0a..ac2f44ab06 100644 --- a/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h +++ b/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h @@ -31,7 +31,7 @@ protected: virtual void init() = 0; // resize - when called, window_width and window_height will have current window size virtual void resize() = 0; - // render - called on WM_PAIT, BeginPaint/EndPaint is handled by D2DWindow + // render - called on WM_PAINT, BeginPaint/EndPaint is handled by D2DWindow virtual void render(ID2D1DeviceContext5* d2d_dc) = 0; // on_show, on_hide - called when the window is about to be shown or about to be hidden virtual void on_show() = 0; diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDelay.h b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDelay.h index 89490f589e..214fd282dc 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDelay.h +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDelay.h @@ -40,7 +40,7 @@ public: _onLongPressReleased(onLongPressReleased), _delayThread(&KeyDelay::DelayThread, this){}; - // Enque new KeyTimedEvent and notify the condition variable. + // Enqueue new KeyTimedEvent and notify the condition variable. void KeyEvent(LowlevelKeyboardEvent* ev); ~KeyDelay(); diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp index ac57a8967c..a5e9ce0987 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp @@ -177,7 +177,7 @@ void ShortcutControl::AddNewShortcutControlRow(StackPanel& parent, std::vector RegisteryAppProgramPaths(IList suffixes) + private static IEnumerable RegistryAppProgramPaths(IList suffixes) { // https://msdn.microsoft.com/en-us/library/windows/desktop/ee872121 const string appPaths = @"SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths"; @@ -788,9 +788,9 @@ namespace Microsoft.Plugin.Program.Programs private static IEnumerable GetPathsFromRegistry(RegistryKey root) => root .GetSubKeyNames() - .Select(x => GetPathFromRegisterySubkey(root, x)); + .Select(x => GetPathFromRegistrySubkey(root, x)); - private static string GetPathFromRegisterySubkey(RegistryKey root, string subkey) + private static string GetPathFromRegistrySubkey(RegistryKey root, string subkey) { var path = string.Empty; try @@ -909,7 +909,7 @@ namespace Microsoft.Plugin.Program.Programs (true, () => CustomProgramPaths(settings.ProgramSources, settings.ProgramSuffixes)), (settings.EnableStartMenuSource, () => StartMenuProgramPaths(settings.ProgramSuffixes)), (settings.EnableDesktopSource, () => DesktopProgramPaths(settings.ProgramSuffixes)), - (settings.EnableRegistrySource, () => RegisteryAppProgramPaths(settings.ProgramSuffixes)), + (settings.EnableRegistrySource, () => RegistryAppProgramPaths(settings.ProgramSuffixes)), }; // Run commands are always set as AppType "RunCommand" diff --git a/src/modules/launcher/PowerLauncher/Properties/Resources.Designer.cs b/src/modules/launcher/PowerLauncher/Properties/Resources.Designer.cs index e67df7b86b..839ac53a24 100644 --- a/src/modules/launcher/PowerLauncher/Properties/Resources.Designer.cs +++ b/src/modules/launcher/PowerLauncher/Properties/Resources.Designer.cs @@ -108,18 +108,18 @@ namespace PowerLauncher.Properties { /// /// Looks up a localized string similar to Settings will be reset to default and program will continue to function.. /// - public static string deseralization_error_message { + public static string deserialization_error_message { get { - return ResourceManager.GetString("deseralization_error_message", resourceCulture); + return ResourceManager.GetString("deserialization_error_message", resourceCulture); } } /// /// Looks up a localized string similar to PowerToys Run deserialization error. /// - public static string deseralization_error_title { + public static string deserialization_error_title { get { - return ResourceManager.GetString("deseralization_error_title", resourceCulture); + return ResourceManager.GetString("deserialization_error_title", resourceCulture); } } diff --git a/src/modules/launcher/PowerLauncher/Properties/Resources.resx b/src/modules/launcher/PowerLauncher/Properties/Resources.resx index 6353c2dea9..f2554c59db 100644 --- a/src/modules/launcher/PowerLauncher/Properties/Resources.resx +++ b/src/modules/launcher/PowerLauncher/Properties/Resources.resx @@ -179,10 +179,10 @@ Title - + PowerToys Run deserialization error - + Settings will be reset to default and program will continue to function. diff --git a/src/modules/launcher/PowerLauncher/SettingsReader.cs b/src/modules/launcher/PowerLauncher/SettingsReader.cs index 7d7777ac0f..588ef793ef 100644 --- a/src/modules/launcher/PowerLauncher/SettingsReader.cs +++ b/src/modules/launcher/PowerLauncher/SettingsReader.cs @@ -159,7 +159,7 @@ namespace PowerLauncher // current file and replace it with a correct json value. _settingsUtils.DeleteSettings(PowerLauncherSettings.ModuleName); CreateSettingsIfNotExists(); - ErrorReporting.ShowMessageBox(Properties.Resources.deseralization_error_title, Properties.Resources.deseralization_error_message); + ErrorReporting.ShowMessageBox(Properties.Resources.deserialization_error_title, Properties.Resources.deserialization_error_message); } else { diff --git a/src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HTMLParsingExtensionTest.cs b/src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HTMLParsingExtensionTest.cs index 31fdc0577b..92fafd2aa2 100644 --- a/src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HTMLParsingExtensionTest.cs +++ b/src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HTMLParsingExtensionTest.cs @@ -11,7 +11,7 @@ namespace PreviewPaneUnitTests [TestClass] public class HTMLParsingExtensionTest { - private static MarkdownPipeline BuidPipeline(IMarkdownExtension extension) + private static MarkdownPipeline BuildPipeline(IMarkdownExtension extension) { MarkdownPipelineBuilder pipelineBuilder = new MarkdownPipelineBuilder().UseAdvancedExtensions(); pipelineBuilder.Extensions.Add(extension); @@ -25,7 +25,7 @@ namespace PreviewPaneUnitTests // Arrange string mdString = "| A | B |\n| -- | -- | "; HTMLParsingExtension htmlParsingExtension = new HTMLParsingExtension(() => { }); - MarkdownPipeline markdownPipeline = BuidPipeline(htmlParsingExtension); + MarkdownPipeline markdownPipeline = BuildPipeline(htmlParsingExtension); // Act string html = Markdown.ToHtml(mdString, markdownPipeline); @@ -41,7 +41,7 @@ namespace PreviewPaneUnitTests // Arrange string mdString = "> Blockquotes."; HTMLParsingExtension htmlParsingExtension = new HTMLParsingExtension(() => { }); - MarkdownPipeline markdownPipeline = BuidPipeline(htmlParsingExtension); + MarkdownPipeline markdownPipeline = BuildPipeline(htmlParsingExtension); // Act string html = Markdown.ToHtml(mdString, markdownPipeline); @@ -57,7 +57,7 @@ namespace PreviewPaneUnitTests // arrange string mdString = "![text](a.jpg \"Figure\")"; HTMLParsingExtension htmlParsingExtension = new HTMLParsingExtension(() => { }, "C:\\Users\\"); - MarkdownPipeline markdownPipeline = BuidPipeline(htmlParsingExtension); + MarkdownPipeline markdownPipeline = BuildPipeline(htmlParsingExtension); // Act string html = Markdown.ToHtml(mdString, markdownPipeline); @@ -73,7 +73,7 @@ namespace PreviewPaneUnitTests // arrange string mdString = "^^^ This is a caption"; HTMLParsingExtension htmlParsingExtension = new HTMLParsingExtension(() => { }, "C:/Users/"); - MarkdownPipeline markdownPipeline = BuidPipeline(htmlParsingExtension); + MarkdownPipeline markdownPipeline = BuildPipeline(htmlParsingExtension); // Act string html = Markdown.ToHtml(mdString, markdownPipeline); @@ -90,7 +90,7 @@ namespace PreviewPaneUnitTests int count = 0; string mdString = "![text](http://dev.nodeca.com \"Figure\")"; HTMLParsingExtension htmlParsingExtension = new HTMLParsingExtension(() => { count++; }); - MarkdownPipeline markdownPipeline = BuidPipeline(htmlParsingExtension); + MarkdownPipeline markdownPipeline = BuildPipeline(htmlParsingExtension); // Act string html = Markdown.ToHtml(mdString, markdownPipeline); diff --git a/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Dark.svg b/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Dark.svg index f2b667444e..268decd93b 100644 --- a/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Dark.svg +++ b/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Dark.svg @@ -12,7 +12,7 @@ Camera not in use - + Microphone on diff --git a/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Light.svg b/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Light.svg index 9ce95b772a..d9d340c034 100644 --- a/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Light.svg +++ b/src/modules/videoconference/VideoConferenceModule/Icons/On-NotInUse Light.svg @@ -12,7 +12,7 @@ Camera not in use - + Microphone on diff --git a/src/modules/videoconference/VideoConferenceModule/Toolbar.cpp b/src/modules/videoconference/VideoConferenceModule/Toolbar.cpp index 46d0f5c828..02a596d519 100644 --- a/src/modules/videoconference/VideoConferenceModule/Toolbar.cpp +++ b/src/modules/videoconference/VideoConferenceModule/Toolbar.cpp @@ -275,11 +275,11 @@ void Toolbar::show(std::wstring position, std::wstring monitorString) GetModuleHandleW(nullptr), nullptr); - auto transparrentColorKey = RGB(0, 0, 255); - HBRUSH brush = CreateSolidBrush(transparrentColorKey); + auto transparentColorKey = RGB(0, 0, 255); + HBRUSH brush = CreateSolidBrush(transparentColorKey); SetClassLongPtr(hwnd, GCLP_HBRBACKGROUND, (LONG_PTR)brush); - SetLayeredWindowAttributes(hwnd, transparrentColorKey, 0, LWA_COLORKEY); + SetLayeredWindowAttributes(hwnd, transparentColorKey, 0, LWA_COLORKEY); SetWindowPos(hwnd, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE);