Ship icons and assets in nuget packages

src/common/utils/modulesRegistry.h

@@ -262,7 +262,7 @@ inline registry::ChangeSet getRegistryPreviewChangeSet(const std::wstring instal
     changes.push_back({ scope, L"Software\\Classes\\regfile\\shell\\preview\\command", std::nullopt, command });
 
     std::wstring icon_path = installationDir;
-    icon_path.append(L"\\WinUI3Apps\\Assets\\RegistryPreview\\app.ico");
+    icon_path.append(L"\\WinUI3Apps\\Assets\\RegistryPreview\\RegistryPreview.ico");
     changes.push_back({ scope, L"Software\\Classes\\regfile\\shell\\preview", L"icon", icon_path });
 
     return { changes };

src/modules/registrypreview/RegistryPreview/RegistryPreview.csproj

@@ -18,7 +18,7 @@
     <SelfContained>true</SelfContained>
     <OutputPath>..\..\..\..\$(Platform)\$(Configuration)\WinUI3Apps</OutputPath>
     <AssemblyName>PowerToys.RegistryPreview</AssemblyName>
-    <ApplicationIcon>Assets\RegistryPreview\app.ico</ApplicationIcon>
+    <ApplicationIcon>Assets\RegistryPreview\RegistryPreview.ico</ApplicationIcon>
     <!-- MRT from windows app sdk will search for a pri file with the same name of the module before defaulting to resources.pri -->
     <ProjectPriFileName>PowerToys.RegistryPreview.pri</ProjectPriFileName>
   </PropertyGroup>

src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml

@@ -39,7 +39,7 @@
                 Width="16"
                 Height="16"
                 VerticalAlignment="Center"
-                Source="../Assets/RegistryPreview/app.ico" />
+                Source="../Assets/RegistryPreview/RegistryPreview.ico" />
             <TextBlock
                 x:Name="titleBarText"
                 Grid.Column="1"

src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml.cs

@@ -40,7 +40,7 @@ namespace RegistryPreview
             IntPtr windowHandle = WinRT.Interop.WindowNative.GetWindowHandle(this);
             Microsoft.UI.WindowId windowId = Win32Interop.GetWindowIdFromWindow(windowHandle);
             appWindow = Microsoft.UI.Windowing.AppWindow.GetFromWindowId(windowId);
-            appWindow.SetIcon("Assets\\RegistryPreview\\app.ico");
+            appWindow.SetIcon("Assets\\RegistryPreview\\RegistryPreview.ico");
 
             // TODO(stefan)
             appWindow.Closing += AppWindow_Closing;

src/modules/registrypreview/RegistryPreview/Strings/en-us/Resources.resw

@@ -59,7 +59,10 @@
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
-  <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
+  <xsd:schema id="root"
+    xmlns=""
+    xmlns:xsd="http://www.w3.org/2001/XMLSchema"
+    xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
     <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
     <xsd:element name="root" msdata:IsDataSet="true">
       <xsd:complexType>
@@ -117,7 +120,4 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
-  <data name="test" xml:space="preserve">
-    <value>a</value>
-  </data>
 </root>