From 4f3d7009a816ee03989925e4bbc849ab6110b73e Mon Sep 17 00:00:00 2001 From: Sanskar Gupta Date: Wed, 20 Nov 2024 22:54:04 +0530 Subject: [PATCH 1/3] Simplify language and structure for clarity and ease of use. (#35943) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. Clearer Section Headings: Renamed sections like "Indicating Interest in Issues" to improve readability. 2. Conciseness and Flow: Shortened sentences and rephrased for directness. 3. Improved Organization: Streamlined instructions in sections like “Filing an Issue” and “Contributing Fixes/Features.” 4. Reduced Redundancy: Simplified repetitive language, especially in localization and contribution details. 5. Enhanced Call to Action: Adjusted "Help Wanted" and "Becoming a Collaborator" to guide users clearly on next steps. --- CONTRIBUTING.md | 68 ++++++++++++++++++++++++------------------------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 43eb58e7e0..02f8746a78 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,53 +1,53 @@ # PowerToys Contributor's Guide -Below is our guidance for how to report issues, propose new features, and submit contributions via Pull Requests (PRs). Our philosophy is heavily based around understanding the problem and scenarios first, this is why we follow this pattern before work has started. +Below is our guidance for reporting issues, proposing new features, and submitting contributions via Pull Requests (PRs). Our philosophy is to understand the problem and scenarios first, which is why we follow this pattern before work starts. -1. There is an issue -2. There has been a conversation -3. There is agreement on the problem, the fit for PowerToys, and the solution to the problem (implementation) +1. There is an issue. +2. There has been a conversation. +3. There is agreement on the problem, the fit for PowerToys, and the solution to the problem (implementation). -## Filing an issue +## Filing an Issue -Please follow this simple rule to help us eliminate any unnecessary wasted effort & frustration, and ensure an efficient and effective use of everyone's time - yours, ours, and other community members': +**Importance of Filing an Issue First** -> 👉 If you have a question, think you've discovered an issue, would like to propose a new feature, etc., then find/file an issue **BEFORE** starting work to fix/implement it. +Please follow this rule to help eliminate wasted effort and frustration, and to ensure an efficient and effective use of everyone’s time: -When requesting new features / enhancements, understanding problem and scenario around it is extremely important. Having additional evidence, data, tweets, blog posts, research, ... anything is extremely helpful. This information provides context to the scenario that may otherwise be lost. +> 👉 If you have a question, think you've discovered an issue, or would like to propose a new feature, please find/file an issue **BEFORE** starting work to fix/implement it. -* Don't know whether you're reporting an issue or requesting a feature? File an issue -* Have a question that you don't see answered in docs, videos, etc.? File an issue -* Want to know if we're planning on building a particular feature? File an issue -* Got a great idea for a new utility or feature? File an issue/request/idea -* Don't understand how to do something? File an issue/Community Guidance Request -* Found an existing issue that describes yours? Great - upvote and add additional commentary / info / repro-steps / etc. +When requesting new features or enhancements, providing additional evidence, data, tweets, blog posts, or research is extremely helpful. This information gives context to the scenario that may otherwise be lost. -A quick search before filing an issue also could be helpful. It is likely someone else has found the problem you're seeing, and someone may be working on or have already contributed a fix! +* Unsure whether it’s an issue or feature request? File an issue. +* Have a question that isn't answered in the docs, videos, etc.? File an issue. +* Want to know if we’re planning a particular feature? File an issue. +* Got a great idea for a new utility or feature? File an issue/request/idea. +* Don’t understand how to do something? File an issue/Community Guidance Request. +* Found an existing issue that describes yours? Great! Upvote and add additional commentary, info, or repro steps. -### How to tell the PowerToys team this is an interesting thing to focus on +A quick search before filing an issue could be helpful. It’s likely someone else has found the same problem, and they may even be working on or have already contributed a fix! -Upvote the original issue by clicking its [+😊] button and hitting 👍 (+1) icon or a different one. This way allows us to measure how impactful different issues are compared to others. The issue with comments like "+1", "me too", or similar is they actually make it harder to have a conversation and harder to quickly determine trending important requests. +### Indicating Interest in Issues + +To let the team know which issues are important, upvote by clicking the [+😊] button and the 👍 icon on the original issue post. Avoid comments like "+1" or "me too" as they clutter the discussion and make it harder to prioritize requests. --- -## Contributing fixes / features +## Contributing Fixes/Features -Please comment on [our "Would you like to contribute to PowerToys?" thread](https://github.com/microsoft/PowerToys/issues/28769) to let us know you're interested in working on something before you start the work. Not only does this avoid multiple people unexpectedly working on the same thing at the same time but it enables us to make sure everyone is clear on what should be done to implement any new functionality. It's less work for everyone, in the long run, to establish this up front. +Please comment on our ["Would you like to contribute to PowerToys?"](https://github.com/microsoft/PowerToys/issues/28769) thread to let us know you're interested in working on something before you start. This helps avoid multiple people unexpectedly working on the same thing and ensures everyone is clear on what should be done. It's less work for everyone to establish this up front. -### Localization issues +### Localization Issues -Please file localization issues, so our internal localization team can identify and fix them. However we currently don't accept community Pull Requests fixing localization issues. Localization is handled by the internal Microsoft team only. +For localization issues, please file an issue to notify our internal localization team, as community PRs for localization aren't accepted. Localization is handled exclusively by the internal Microsoft team. -### To Spec or not to Spec +### To Spec or Not to Spec -A key point is for everyone to understand the approach that will be taken. We want to be sure if anyone does work, we will accept it in. Items that are larger in scope we'll want some type of spec to understand what is being planned and have a discussion. Specs help collaborators discuss different approaches to solve a problem, describe how the feature will behave, how the feature will impact the user, what happens if something goes wrong, etc. Driving towards agreement in a spec, before any code is written, often results in simpler code, and less wasted effort in the long run. +A key point is for everyone to understand the approach that will be taken. We want to be sure that any work done will be accepted. Larger-scope items will require a spec to outline the approach and allow for discussion. Specs help collaborators consider different solutions, describe feature behavior, and plan for errors. Achieving agreement in a spec before writing code often results in simpler code and less wasted effort. -For such scenarios, once a team member has agreed with your approach, skip ahead to the section headed "Development" section below. - -Team members will be happy to help review specs and guide them to completion. +Once a team member has agreed with your approach, proceed to the "Development" section below. Team members are happy to help review specs and guide them to completion. ### Help Wanted -Once the team has approved an issue/spec approach to solving, development can proceed. If no developers are immediately available, the spec can be parked ready for a developer to get started. Parked specs' issues will be labeled "Help Wanted". To find a list of development opportunities waiting for developer involvement, visit the Issues and filter on [the Help-Wanted label](https://github.com/microsoft/PowerToys/labels/Help%20Wanted). +Once the team has approved an issue/spec approach, development can proceed. If no developers are immediately available, the spec may be parked and labeled "Help Wanted," ready for a developer to get started. For development opportunities, visit [Issues labeled Help Wanted](https://github.com/microsoft/PowerToys/labels/Help%20Wanted). --- @@ -55,18 +55,18 @@ Once the team has approved an issue/spec approach to solving, development can pr Follow the [development guidelines](https://github.com/microsoft/PowerToys/blob/main/doc/devdocs/readme.md). -### Naming of features and functionality +### Naming Features and Functionality -Naming should be descriptive and straight forward. We want names to be clear about functionality and usefulness moving forward. +Names should be descriptive and straightforward, clearly reflecting functionality and usefulness. -### How can I become a collaborator on the PowerToys team +### Becoming a Collaborator on the PowerToys Team -Be a great community member. Just help out a lot and make useful additions, filing bugs/suggestions, help develop fixes and features, code reviews, and always, docs. Lets continue to make the PowerToys repository a great spot to learn and make a great set of utilities. +Be an active community member! Make helpful contributions by filing bugs, offering suggestions, developing fixes and features, conducting code reviews, and updating documentation. -When the time comes, Microsoft will reach out and help make you a formal team member. Just make sure they can reach out to you :) +When the time comes, Microsoft will reach out to you about becoming a formal team member. Just make sure they have a way to contact you. 😊 --- -## Thank you +## Thank You -Thank you in advance for your contribution! +Thank you in advance for your contribution! We appreciate your help in making PowerToys a better tool for everyone. From d31934b7de56f01d90dce6a5e278b5a2611b348e Mon Sep 17 00:00:00 2001 From: Ethan Fang <117125208+ethanfangg@users.noreply.github.com> Date: Wed, 20 Nov 2024 09:25:21 -0800 Subject: [PATCH 2/3] [DATA_AND_PRIVACY.md] updating the list of diagnostic data events (#35922) * updating the list of diagnostic data events * updating the list of events --- DATA_AND_PRIVACY.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/DATA_AND_PRIVACY.md b/DATA_AND_PRIVACY.md index 9390d37722..5570729c20 100644 --- a/DATA_AND_PRIVACY.md +++ b/DATA_AND_PRIVACY.md @@ -67,6 +67,10 @@ _If you want to find diagnostic data events in the source code, these two links Microsoft.PowerToys.TrayFlyoutModuleRunEvent Logs when a utility from the tray flyout menu is run. + + Microsoft.PowerToys.Uninstall_Success + Logs when PowerToys is successfully uninstalled (who would do such a thing!). + ### OOBE (Out-of-box experience) @@ -139,6 +143,10 @@ _If you want to find diagnostic data events in the source code, these two links Microsoft.PowerToys.AdvancedPasteInAppKeyboardShortcutEvent Triggered when a keyboard shortcut is used within the Advanced Paste interface. + + Microsoft.PowerToys.AdvancedPasteSemanticKernelFormatEvent + Triggered when Advanced Paste leverages the Semantic Kernel. + ### Always on Top From f66450f6a8593ebf13a9ab0b5e085f042125d10f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=A1=9C=E4=BA=95=20=E3=83=9B=E3=82=BF=E3=83=AB?= Date: Thu, 21 Nov 2024 01:25:35 +0800 Subject: [PATCH 3/3] [PTRun][Docs] Add Bilibili to Third-Party plugins (#35926) * Update thirdPartyRunPlugins.md * Update names.txt --- .github/actions/spell-check/allow/names.txt | 3 +++ doc/thirdPartyRunPlugins.md | 1 + 2 files changed, 4 insertions(+) diff --git a/.github/actions/spell-check/allow/names.txt b/.github/actions/spell-check/allow/names.txt index 20a09d2241..4c038bdf1c 100644 --- a/.github/actions/spell-check/allow/names.txt +++ b/.github/actions/spell-check/allow/names.txt @@ -144,6 +144,7 @@ TBM tilovell Triet waaverecords +Whuihuan Xpg ycv Yuniardi @@ -154,6 +155,8 @@ Zykova # OTHERS +Bilibili +BVID cmdow Controlz cortana diff --git a/doc/thirdPartyRunPlugins.md b/doc/thirdPartyRunPlugins.md index ad9b417b39..bd179eea25 100644 --- a/doc/thirdPartyRunPlugins.md +++ b/doc/thirdPartyRunPlugins.md @@ -58,3 +58,4 @@ Below are community created plugins that target a website or software. They are | [PowerSearch for 1Password](https://github.com/KairuDeibisu/PowerToysRunPlugin1Password) | [KairuDeibisu](https://github.com/KairuDeibisu) | An unofficial plugin for searching 1Password for usernames and passwords | | [HackMD](https://github.com/8LWXpg/PowerToysRun-HackMD) | [8LWXpg](https://github.com/8LWXpg) | Open HackMD notes | | [SSH](https://github.com/8LWXpg/PowerToysRun-SSH) | [8LWXpg](https://github.com/8LWXpg) | Connect to ssh clients | +| [Bilibili](https://github.com/Whuihuan/PowerToysRun-Bilibili) | [Whuihuan](https://github.com/Whuihuan) | Use AVID or BVID to parse and jump to Bilibili |