mirror/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2024-11-24 04:12:32 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[Settings]Ensure PTRun plugin icon paths are well formed / add unhandled exception handler (#33374)

Browse Source 
* Fixed production crash with bad icon paths in Launcher plugins

* Bumped MSBuildCacheCacheUniverse
This commit is contained in:
Ani 2024-06-16 17:58:25 +02:00 committed by GitHub
parent deb6234d72
commit f019163083
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/settings-ui/Settings.UI/SettingsXAML/App.xaml.cs
View File

@ -76,9 +76,16 @@ namespace Microsoft.PowerToys.Settings.UI
/// </summary>
public App()
{
Logger.InitializeLogger("\\Settings\\Logs");
Logger.InitializeLogger(@"\Settings\Logs");
this.InitializeComponent();
InitializeComponent();
UnhandledException += App_UnhandledException;
}
private void App_UnhandledException(object sender, Microsoft.UI.Xaml.UnhandledExceptionEventArgs e)
{
Logger.LogError("Unhandled exception", e.Exception);
}
public static void OpenSettingsWindow(Type type = null, bool ensurePageIsSelected = false)

7
src/settings-ui/Settings.UI/ViewModels/PowerLauncherPluginViewModel.cs
View File

@ -179,10 +179,9 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
return $"{Name}. {Description}";
}
public string IconPath
{
get => isDark() ? settings.IconPathDark : settings.IconPathLight;
}
#nullable enable
public Uri? IconPath => Uri.TryCreate(isDark() ? settings.IconPathDark : settings.IconPathLight, UriKind.Absolute, out var uri) ? uri : null;
#nullable restore
public event PropertyChangedEventHandler PropertyChanged;