* Changed EnumerateFileSystemInfos to EnumerationOptions we don't have to catch the exceptions ourself.
* Change Matchtype to mimic old search method.
Co-authored-by: p-storm <paul.de.man@gmail.com>
* Matching explorer.exe also for explorer
Added unit test
Optimized multiple iterations for IProgram
* Fixed linter
Co-authored-by: p-storm <paul.de.man@gmail.com>
* Fixed the error that Files were named Folder
* Add and use resources in Results.
* Last item without resources in Plugin.Folder
* Changed to CurrentCulture, added N0 to Folder truncate warning.
Co-authored-by: p-storm <paul.de.man@gmail.com>
* Add exception handling to prevent program from failing due to error in one program
* Error handling for program path function
* Fix incorrect log value in ProgramLogger
* Made Plugin Folder Unit tests. Fixes '>' not recursive searching (with max). Added that paths with an UnauthorizedAccessException are ignored. Added expanding enviroment search.
* Fixed some merging errors
* Added feedback from review
* Made the change that ryanbodrug-microsoft suggested
* Stupid merge request... fixed
Co-authored-by: p-storm <paul.de.man@gmail.com>
* add a separate task to dequeue and create an app on installation
* Added tests to validate the behavior of the event handler
* release unmanaged memory
* 1) Making Directory Methods private.
2) Removing the CreateDirectory / DeleteDirectory functionality from all Settings Unit Tests.
* Abstracting disk access via IIOProvider to be able to provide mocks for unit tests instead of writing to disk. This also prevents developers who are running unit tests from interfering with the PowerToys settings on their local dev box.
* Dependency Injecting stub SettingsUtils for all tests
* Removing ISettingsUtils from constructors of objects that need to be deserialized (ColorPickerSettings/PowerLauncherSettings) as this breaks System.Text.Json
* Removing unused namespace reference
* Removing redifined mock
* As per PR feedback. Stub Settings utils should work with any settings type if the intent is to compile / avoid null ref exceptions.
Strangely when implementing this fix it became apparent that a stub settings isn't enough, and disk access needed to be mocked. I can't explain why the tests were passing previously.
* Leveraging GetMockIOProviderForSaveLoadExists
* Added a keyboard hook to the runner
* Update RootKeyboardHook
* Enable reading the whole JsonObject property
* Renamed RootKeyboardHook to CentralizedKeyboardHook
* Fixed build break, changed callback return type to bool
* Added Hotkey struct which somehow went missing
+ Cherry-pick fixes
* Reorganized the kb hook
* Basic version works
* Various fixes
* Finishing touches
* Fix potential threading issue
* int -> size_t
* Add default initializers to the Hotkey struct
* Added a suggested comment
* Unified a constant
* Use C# classes instead of native calls for sync
* Added a claryfing comment
* Use std::move
* Renamed a method
* Possible fix for compilation errors
* Fix a regression
* Show a message on failure
* Added DISABLE_LOWLEVEL_HOOK support
* Allow running Launcher as standalone
* Rename string constants
* Implemented possibility to add commandline arguments in the Program Plugin
* Add missing return statement inc ommandArgumentParser loop
* Fix typos
* Fix Additional Typo
* Changed -c to /c to make it a valid cmd argument
* Added small comment about importance of order in _programArgumentParsers
Co-authored-by: Roy <royvou@hotmailcom>
* Updated UnregisteredApps code
* Added file type checking code and Folder and File classifications
* Added more file formats
* Removed run as admin for lnk folders
* Added script files as executable and changed hashset to case insensitive
* Removed runasadmin for generic files
* Removed FileTypes enum
* Extended ApplicationTypes enum
* Fix file format error
* Cleaned use of ApplicationType enum to public and match AppType and used ApplicationType in OnAppRenamed
* Modify tests to use ApplicationType enum
* Added tests for new App types
* Modified dummy appref
* Mock Directory.Exists and add tests for GetAppTypeFromPath
* Combined tests
* Adding FxCop to Microsoft.Plugin.WindowWalker
* Delete WindowResult.cs -- Fix for CA1812 WindowResult is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it static (Shared in Visual Basic).
* Fix for CA1806 UpdateOpenWindowsList calls EnumWindows but does not use the HRESULT or error code that the method returns. This could lead to unexpected behavior in error conditions or low-resource situations. Use the result in a conditional statement, assign the result to a variable, or pass it as an argument to another method.
* Fix for: CA1066 Type Microsoft.Plugin.WindowWalker.Components.InteropAndHelpers.RECT should implement IEquatable<T> because it overrides Equals
* Fix for: CA1052 Type 'FuzzyMatching' is a static holder type but is neither static nor NotInheritable
* Suppress for CA1069 - These values are defined in
https://docs.microsoft.com/en-us/windows/win32/winmsg/extended-window-styles.
CA1069 The enum member 'WS_EX_LTRREADING' has the same constant value '0' as member 'WS_EX_LEFT'
CA1069 The enum member 'WS_EX_RIGHTSCROLLBAR' has the same constant value '0' as member 'WS_EX_LEFT'
* Supress CA1069
Code Description
CA1069 The enum member 'SWP_NOREPOSITION' has the same constant value '512' as member 'SWP_NOOWNERZORDER'
CA1069 The enum member 'SWP_FRAMECHANGED' has the same constant value '32' as member 'SWP_DRAWFRAME'
* Suprress CA1069 for ShowWindow values. See
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-showwindow
CA1069 The enum member 'ShowMaximized' has the same constant value '3' as member 'Maximize'
* Fix code formatting error
* Fix for CA2235: Making POINT serializable
CA2235 Field MinPosition is a member of type WINDOWPLACEMENT which is serializable but is of type Microsoft.Plugin.WindowWalker.Components.InteropAndHelpers.POINT which is not serializable
CA2235 Field MaxPosition is a member of type WINDOWPLACEMENT which is serializable but is of type Microsoft.Plugin.WindowWalker.Components.InteropAndHelpers.POINT which is not serializable
* Fix CA2235 Making RECT serializable
CA2235 Field NormalPosition is a member of type WINDOWPLACEMENT which is serializable but is of type Microsoft.Plugin.WindowWalker.Components.InteropAndHelpers.RECT which is not serializable
* Fixes for CA2101 Specify marshaling for P/Invoke string arguments.
* Fixes for CA2007 Consider calling ConfigureAwait on the awaited task
* Fixes for the following (CA1822 / CA1801):
CA1822 Member 'OnOpenWindowsUpdate' does not access instance data and can be marked as static
Code Description
CA1801 Parameter value of method add_OnOpenWindowsUpdate is never used. Remove the parameter or use it in the method body.
CA1801 Parameter value of method remove_OnOpenWindowsUpdate is never used. Remove the parameter or use it in the method body.
* Fix: CA1710 Rename OpenWindowsUpdateHandler to end in 'EventHandler'
* Fix CA1822 Member 'GetProcessIDFromWindowHandle' does not access instance data and can be marked as static
* Fix CA1062 In externally visible method 'List<int> FuzzyMatching.FindBestFuzzyMatch(string text, string searchText)', validate parameter 'searchText' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
* Fixes for CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings.
CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'FuzzyMatching.FindBestFuzzyMatch(string, string)' with a call to 'string.ToLower(CultureInfo)'.
Code Description
CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'FuzzyMatching.FindBestFuzzyMatch(string, string)' with a call to 'string.ToLower(CultureInfo)'.
* Supressing warning for CA1814: Prefer jagged arrays over multidimensional however this might be something to consider if needing to optimize the window walker search.
* Fix: CA1062 In externally visible method 'List<List<int>> FuzzyMatching.GetAllMatchIndexes(bool[,] matches)', validate parameter 'matches' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
* Fix for CA1062 In externally visible method 'int FuzzyMatching.CalculateScoreForMatches(List<int> matches)', validate parameter 'matches' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
* Fixes for CA1806 Calls x... but does not use the HRESULT or error code that the method returns. This could lead to unexpected behavior in error conditions or low-resource situations. Use the result in a conditional statement, assign the result to a variable, or pass it as an argument to another method.
Using discard for methods that return void, and checking the hresult before returning parameters.
* Fix for CA1820 Test for empty strings using 'string.Length' property or 'string.IsNullOrEmpty' method instead of an Equality check
* Supress CA1031 Modify 'get_WindowIcon' to catch a more specific allowed exception type, or rethrow the exception
* Code Description
CA1062 In externally visible method 'List<Result> Main.Query(Query query)', validate parameter 'query' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
* Fixes For CA1304 The behavior of 'string.ToUpper()' could vary based on the current user's locale settings.
CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'SearchController.SearchText.set' with a call to 'string.ToLower(CultureInfo)'.
CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Window.ProcessName.get' with a call to 'string.ToLower(CultureInfo)'.
CA1304 The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Window.SwitchToWindow()' with a call to 'string.ToLower(CultureInfo)'.
CA1304 The behavior of 'string.ToUpper()' could vary based on the current user's locale settings. Replace this call in 'Window.ToString()' with a call to 'string.ToUpper(CultureInfo)'.
CA1307 The behavior of 'string.Equals(string?)' could vary based on the current user's locale settings. Replace this call in 'Microsoft.Plugin.WindowWalker.Components.Window.SwitchToWindow()' with a call to 'string.Equals(string?, System.StringComparison)'.
* Fix: CA1710 Rename SearchResultUpdateHandler to end in 'EventHandler'
* Fix CA1060 Move pinvokes to native methods class
* Fix: CS0067 The event 'OpenWindows.OnOpenWindowsUpdateEventHandler' is never used
1) Remove SearchController::OpenWindowsUpdateHandler(object sender, SearchResultUpdateEventArgs e) as it wasn't being called and was redundant with Update Search Text.
2) In Main.cs calling UpdateOpenWindowsList before UpdateSearchText so that the latest enumerated windows will be called.
3) Removing unused OnOpenWindowsUpdateEventHandler and related code.
* Revert "Fixes for CA2101 Specify marshaling for P/Invoke string arguments."
This reverts commit b3dfe07915.
* Fixing CA2101 by turning off best fit mapping for methods that require ANSI marshalling.
See: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2101?view=vs-2019
* Previous fix for CA1806 misunderstood int result as hresult. The actual return value is number of characters written.
NativeMethods.GetWindowText(hwnd, titleBuffer, sizeOfTitle);
* Previous fix for CA1806 misunderstood int result as hresult. The actual return value is number of characters written.
NativeMethods.GetClassName(Hwnd, windowClassName, windowClassName.MaxCapacity);
* Removing unused window code. This was done instead of validating fxcop changes in WindowIcon.
* Fixing typos in Window.cs (charachter -> character)
* Refactored logic and made it unit testable
* Changes after code review
* Added to build steps, and modified bracket to new class with unittest. Validates complexer cases now.
Co-authored-by: p-storm <paul.de.man@gmail.com>
* Updated error message when SetWindowsHookEx fails to show correct error message
* Added telemetry for exception in SG, FZ and KBM
* Rename exception to error
* Removed xaml files, added resx file and removed references for PowerLauncher project
* Added resx file for wox.plugin
* Moved Calculator resources to resx
* Migrated resources for Folder and Indexer plugins
* Migrated resources for Program and Shell plugin
* Migrated resources for URI and Window Walker
* Removed GetTranslation, tests need to be refactored
* Removed internationalization classes
* Removed Wox.Core.Resource references
* Fixed Programs plugin tests
* Fixed tests
* Removed language xaml files from installer
* Added locProject.json files
* Fixed resource not found error
* Remove unused strings from PowerLauncher
* Removed all unused strings
* Reverted addition of resx file for Wox.Plugin
* Added more resources for Folder plugin
* Added resources for Folder and Indexer plugin
* Added resources for Program, Shell, Uri and WW plugins
* Changed string from Wox to PT Run
* managed common files
* Added context menu to first folder result
* Added context menu to first folder result
* Add localization for string in folder plugin
* Fixed issue with context menu not showing on first selected item
* Add exception logging
* Removed xaml files, added resx file and removed references for PowerLauncher project
* Added resx file for wox.plugin
* Moved Calculator resources to resx
* Migrated resources for Folder and Indexer plugins
* Migrated resources for Program and Shell plugin
* Migrated resources for URI and Window Walker
* Removed GetTranslation, tests need to be refactored
* Removed internationalization classes
* Removed Wox.Core.Resource references
* Fixed Programs plugin tests
* Fixed tests
* Removed language xaml files from installer
* Added locProject.json files
* Fixed resource not found error
* Reverted addition of resx file for Wox.Plugin
* Screen reader detecting List view
* Fixed narrator text for listview items and context menu items
* Renamed custom textbox to a more meanigful name
* Renamed custom textbox to a more meanigful name
* Fix formatting of LauncherControl.xaml
* Added support to control multiple elements
* Added localization code to pipeline and created one LocProject json for Settings
* Fixed typo
* Reordered nuget source
* Moved nuget install to restore step
* Added FZ.rc file to LocProj
* Added FZ resx file and modified rc file
* Fixed file names
* Changed to check folder for LocProject files
* Updated folder
* Changed directory
* Changed to src directory
* Changed language set and name format, removed rc file localization
* Added all projects with resx/resw files
* Added newline to end of file
* Removed nuget source as it is not used
* Updated comments
* Updated keyboard manager to use resx file
* Tweaked resources.resx and added it to project files
* Added comments and added in string table to resx script
* Remove change from bad merge
* Fix syntax error in convert stringtable
* Changed file type to None
* Migrated color picker's resources
* Migrated resources for Microsoft.Launcher
* Migrated resources for fancy zones
* Revert fancyzones changes
* Migrated resources for ImageResizer and modified script to add language specific code
* Added try catch and checks for modification to avoid unnecessary file creation
* Changed tab insertion to 4 spaces to avoid mixed file types in rc file
* Migrated resources for power preview project
* Added LocProject.json file for 5 projects
* added resgen exception check
* Moved non-localizable strings out of resx for powerpreview
* Added wox code for tiling
* nit fixes in plating function
* Added feature to plate images based on theme
* Improve code readability
* added altform based paths
* Error handling in fetching logo
* Re add fix sequence empty exception on calling max in program plugin
* Move path and logo setting code to setIcon function
* Add corner radius to packaged apps icon
* Revert "Add corner radius to packaged apps icon"
This reverts commit 9be496e662.
* Returning individual queries for each plugin
* Changed cancellation token from Query type to directly using the rawQuery
* Changed the way we get the plugins for which we execute the query
* updated UpdateResultView to take a string instead of query
* Changed the way we set a query for each plugin
* removed todo comment
* global plugins are added as a part of the query builder
* Fix for plugin.json of Folder plugin being copied into the shell plugin
* >,< and : are not allowed in file paths and indexer creates a query which searches compares if a file name is greater than or lesser than the query
* Reformatted the regex
* catching the exception
* fixed existing tests
* modified it so that it works with action keyword as well as action keywords
* Added unit tests for non global plugins
* fixed test
* add back whitespace that was removed by mistake
* fix regex
* modified the cold start query
* remove extra condition
* terms being modified as expected
* used key value pairs to iterate through the dictionary
* renamed variable
* added check for an empty dictionary
* remove : because it may appear in the file path
* fix some whitespace warnings that were being treated as errors
* Removing non thread safe member variables, as well as the check to ensure that they have been disposed.
* Removing 'ExecuteQuery_ShouldDisposeAllConnections_AfterFunctionCall'.
This call previously required the use of member variables that were not thread safe. There is no reason to share this state across threads. Arguably this test verifies an internal implementation detail and is not suitable for a unit test anyway.
* Added localization code to pipeline and created one LocProject json for Settings
* Fixed typo
* Reordered nuget source
* Moved nuget install to restore step
* Added FZ.rc file to LocProj
* Added FZ resx file and modified rc file
* Fixed file names
* Changed to check folder for LocProject files
* Updated folder
* Changed directory
* Changed to src directory
* Changed language set and name format, removed rc file localization
* Added all projects with resx/resw files
* Added newline to end of file
* Removed nuget source as it is not used
* Updated comments
* Fixed formatting of json file
* Move loc step to end
* attempting to run CI unittests as seperate passes for .netframework and .netcore, based on assemblies.
* Mocking CSearchManager to avoid the following exception running in CI.
Retrieving the COM class factory for component with CLSID {7D096C5F-AC08-4F1F-BEB7-5C22C517CE39} failed due to the following error: 80070422 The service cannot be started, either because it is disabled or because it has no enabled devices associated with it. (0x80070422).
* Setting proper connection string for unit test.
* Mocking sqlQuery with FilePath vs m*
* Temporarily Ignoring test that is throwing exception in CI.
* Implemented "hidden files" flag in native Windows Search
* add missing file
* Change InitQueryHelper back to static
* Fix Line Endings
* Add files via github
Co-authored-by: Roy <royvou@hotmailcom>
* Added the version number for all launcher projects so that they are in sync with the powerToys version number
* Removed internals visible to Wox.dll as we no longer have that library
* Adding FxCop to Microsoft.Plugin.Program.UnitTests
* CA1707: Identifiers should not contain underscores
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1707?view=vs-2019
* CA1307: Specify StringComparison
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019
* CA1812: Avoid uninstantiated internal classes
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1812?view=vs-2019
* More CA1707: Identifiers should not contain underscores fixes now that class is public
* More fixes for https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1812?view=vs-2019
List Repository and Win32ProgramRepository
* More CA1707: Identifiers should not contain underscores fixes now that class is public
ListRepository and Win32ProgramRepository tests
* Adding `ConfigureAwait(false)` and removing Assert.DoesNotThrowAsync as thowing an exception will fail the test anyway, and the DoesNotThrowAsync method can't be awaited.
Fix for CA2007: Do not directly await a Task (Consider calling ConfigureAwait on the task).
CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
* Setting treat warning as errors to true for release and debug.
* Added regex code
* Added regex based method to remove all LIKE queries
* Made regex readonly
* Added plugin interface and code to execute slower plugins after the fast plugins
* Added scoring for indexer and added statement to remove old indexer results
* Refactored from master and added thread sleep for debugging
* Removed lock from indexer plugin and added checks to avoid exceptions
* Remove debug statement
* Removed selected index update and fixed tests not building
* Added tests
* Removed scoring
* Removed lock
* Resolve merge conflicts
* Moved dispatcher code to function and add parallel foreach loop
* Removed DelayedExec metadata and modified QueryForPlugin to run only delayed exec plugins when bool param is true
* Removed metadata from plugin.json
* url handler plugin
* updates
* Add seperate interface classes
rename to uri module
* Update path
* Update implementation to remove slow DNS lookup ( and let browser handle it)
* tabs to spaces
* - Update icon/assets
- Finalize Project
* Update wix project
* Implement UpdateBrowserIconPath
* Implemented Microsoft.CodeAnalysis.FxCopAnalyzers
* Add Language component to installer
* Update logic to determine icon
* Update Translation File to "Open in browser"
* Added test for typing http://test.com and which result to expect on each keystoke
* Implement StyleCop
* Added ipv6 tests
* Fix Solution LineBreaks
* Added Microsoft.Plugin.Uri as build Dependency
* Use ArgumentNullException instead of InvalidOperationException
* Fix wrong Directory in wix installer
Co-authored-by: Roy <royvou@hotmailcom>
* set the name automation properties for the result elements
* Added name properties to search box
* removed the name for the grid
* localized the automation property names of the launcher control
* Localized the automation name property for the result list
* Uncommented out the Hide() function which was commented out to run Accessibility Insights
* modified resources from static to dynamic
* reverted access modifier to internal as we are no longer using this
* updated csproj file
* fixing MSB3052
* adding back in to unblock build
* More agressive refactor. Moved the define constant to wixproj and actual version into src file version prop
Co-authored-by: Clint Rutkas <crutkas@microsoft.com>
* getting app to not use it, now installer
* removed windowinput.dll from inputsimulator nuget package
Co-authored-by: Clint Rutkas <crutkas@microsoft.com>
* Enabling code analysis, and treating warnings as errors
* Error CA1724 The type name Settings conflicts in whole or in part with the namespace name 'Microsoft.PowerToys.Settings'. Change either name to eliminate the conflict. Microsoft.Plugin.Indexer C:\repos\powertoys\src\modules\launcher\Plugins\Microsoft.Plugin.Indexer\Settings.cs 9 Active
* Removing keyword "Interface" from namespace to fix fxcop warnings
* Fixing static analysis warnings on ContextMenuLoader
* Fixing general exception warnings for static analysis
* Fixing public list variables, non static methods, and general exception warning
* Implementing IDisposable on OleDBSearch although in practice these objects were already being disposed.
Also Validated we were not using user input directly for sql strings.
* Removing VS generated comments from dispose methods as per PR feedback.
* Setting translated text to use current culture as per PR feedback.
* Explicity specifying 'internal' access modifier for Indexer 'Main' class, as per PR feedback
* Updating to FxCop 3.0.0
* updated to Microsoft.Windows.CppWinRT.2.0.200729.8
* actually adding in packages.config and updating
Co-authored-by: Clint Rutkas <crutkas@microsoft.com>
* Removing hardcoded version numbers from c# telemetry events.
* Removing dependency on powertoysInterop for getting version string.
* Defensive checks around getting assembly version
* Added fast observable collection
* Updated to use 1 collection changed event per query
* Moved result updating to background thread
* Changed collapsed to hidden for virtualization
* Moved all token cancellations inside try catch
* Fixed freeze on deleting first letter
* nit fixes
* Moved update logic to plugin result loop
* Updated doc comment for AddResults function
* fix result clear on empty query
* fix report window error icon
* fix for launching web page to create new issue
* Made icon theme aware
* removed exception that was added by mistake
* modified the issue reporting link to match that in the settings page
* added comment
* Renaming properties
* Update PowerLauncherProperties.cs
trying to kick CI
* PowerLauncher is way for naming.
Co-authored-by: Clint Rutkas <crutkas@microsoft.com>
* minor text refinement
* removed the word Detected
* Revert "Merge branch 'tweakUIText_DriveDetectionWarning' of https://github.com/alekhyareddy28/PowerToys into tweakUIText_DriveDetectionWarning"
This reverts commit b193905d00, reversing
changes made to 0d0db138f8.
* Revert "Revert "Merge branch 'tweakUIText_DriveDetectionWarning' of https://github.com/alekhyareddy28/PowerToys into tweakUIText_DriveDetectionWarning""
This reverts commit b653814eec.
Co-authored-by: Clint Rutkas <clint@rutkas.com>
* Added functionality for left/right key navigation
* Update Behviour of left/right navigation
* Code cleanup
* Null check for results VM
* Added tests for results view model
* Update test namings
* Turning on static analysis and removing warning for NoMages.
* Fixing static analysis errors in NumberTranslator.cs
* Fix: Severity Code Description Project File Line Suppression State
Error CA1810 Initialize all static fields in 'Main' when those fields are declared and remove the explicit static constructor Microsoft.Plugin.Calculator C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Calculator\Main.cs 30 Active
* Throwing exception if arguments are null to fix static analysis errors.
* Ignoring CA1031
* Logging exceptions for Calculator queries.
* Remove os-detection project
* Removed os-detection project from sln
* Added os-detection to PowerToysInterop
* Removed references to os-detection and added PowerToysInterop.dll to the ImageResizer folder
* We should not deny other processes access to this item
* added a catch block for argument exception
* using memory stream instead of URI
* removed denyNone as it is the default config
* opens new settings search options
* Catching file not found exception
* removed unnecessary header files
* Added display strings and cleaned up code
* reduced the number of max results to 30
* added log statement for exception
* Added drive detection to settings ui but still doesn't reflect on toggling it
* added getter setter for DriveDetectionWarning
* Got UI and backend to work as expected
* Reading value from registry working as expected
* Added test for settings
* Added tests for drive detection
* rename drive detection
* Localized indexer string
* formatting
* resolving merge conflict
* Added theme aware warning icon
* changed text for the warning
* Added the warning images to the installer
* Added file system wrapper and interface
* added win32program repository which would load store app and also handle new apps being added/deleted
* Added event handlers to win32 program repo
* added paths to monitor and setting FSWs for each location
* Events firing as expected
* filter extensions added, events fire as expected
* override gethashcode so that duplicates don't show up. OnCreated and OnDeleted events trigger as expected
* implemented setter for filters in FileSystemWatcher
* Rename adds item but does not seem to delete the previous app
* catching an exception when a duplicate item is inserted
* Removed notify filter for directory because we only need to monitor files
* Added exe programs to be indexed in the desktop and startmenu
* created a new class to init FileSystemHelpers instead of main
* Added fix for shortcut applications to work as expected while renaming and deleting them
* Added wrappers for file system operations
* Added some tests
* Added all tests for appref-ms and added a condition to search in sub directories
* Added tests for Exe applications
* Added lnk app tests
* Added tests for shortcut applications
* removed unnecessary wrappers
* override Equals for win32
* removed debug statements
* Fixed exe issue
* Fixed internet shortcut exception
* fixed renaming shortcut apps
* Added a retry block for ReadAllLines
* capitalized method name - RetrieveTargetPath
* made naming consistent, helper variables start with underscore
* Added the exception condition back
* renamed Win32ProgramRepositoryHelper to Win32ProgramFileSystemWatchers
* made win32Program repository variable static
* changed list to ilist
* disposed file system watchers
* make retrieveTargetPath upper case in tests
* Implemented Clear Input On Launch
* Move logic to seperate command on viewmodel
* Added Settings Sync
Moved logic from OnDeactivated to OnActivated
* Complete after testing
Co-authored-by: Roy <royvou@hotmailcom>
* Updated (plugin) icons with MDL2
* Image wasn't updating
* Based on feedback, updated app icon and windowwalker icon
* Updated app icon
* Updated Window Walker icon
* Change build action / Copy to output directory to None and Do Not Copy - like it was originally
* Fix
* Fix
* Resized images
* Added theme awereness based on somil55s PR
* Added theming to Shell and WindowWalker
* Revert "Added theming to Shell and WindowWalker"
This reverts commit f492c4efdb.
* Revert "Added theme awereness based on somil55s PR"
This reverts commit 8edd3226be.
* Typo fix
* Added new theming support for the new Calculator, Shell and WindowWalker icons
* Added Unit test reference back in
* Added wrapper for PackageManager and Package class
* Added tests for package in development and framework mode
* Renamed UWP test file
* Improved readability of UWP tests
* Added custom tooltip style (with theming support) that represents the UWP tooltip style.
* Removed unnecessary space in text
* Fixed run as admin casing
* Fixed casing for Indexer plugin
* Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests
* Fixing message format for exception
* Changing test structure. Need to add unit tests.
* Updating packagerepository comment based on pr feedback
* Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary.
* Removing unecessary implementation of IRepository interface as this is implemented by the base class.
* Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor.
* Fixing comments
* Adding newline to end of file for IProgramRepository
* Revert "Adding newline to end of file for IProgramRepository"
This reverts commit d55cac80bf.
* Revert "Fixing comments"
This reverts commit a1ecdc9bfa.
* Revert "Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor."
This reverts commit 0e8c1cb0fd.
* Revert "Removing unecessary implementation of IRepository interface as this is implemented by the base class."
This reverts commit 1c724280f5.
* Revert "Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary."
This reverts commit 9ff8246a9d.
* Revert "Updating packagerepository comment based on pr feedback"
This reverts commit 2c45956030.
* Revert "Changing test structure. Need to add unit tests."
This reverts commit 1c267a55d5.
* Revert "Fixing message format for exception"
This reverts commit f60bdc3dd4.
* Revert "Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests"
This reverts commit 030dfc2370.
* Added run as admin context menu item to apps returned by indexer plugin
* Added a test and localized strings
* localize strings
* Add more tests for folder and other file types
* fixed run as admin -> run as administrator
* resolved merge conflict
* refactored tests
* moved common code to helper and added logs
* moved start process to the helper class
* added more info in a comment
* fixed count in tests as open in console was added
* removed additional code that was added while fixing merge conflicts
* Added open in console for indexer
* Added open in console fpr indexer and folder plugin
* Added open in console to program plugin
* Added string localization for program plugin
* Added test for win32 program
* Added test for win32 programs
* Added test for indexer plugin
* Localization for context menu title
* Added tests for folder plugin
* Added tests for indexer plugin
* Code cleanup
* Improved logging and nit fixes
* Updated tooltip for open in console
* Updates tests
* Removed subtitle property from contextmenuresult class
* Improved logging for context menu loaders
* Added tests to verify that the name is always set as the title and never the description
* removed AppType as an argument
* refactored code
* added comments
* localized strings
* removed empty constructor
* made setsubtitle private
* removed the mock Win32 class used for unit testing
* removed the UWP tests
* Fix multiline title issue
* Added code to display tooltip for program and indexer plugin
* Added tests for Result class
* Theme based color for tooltip
* Added colors for tooltip
* Added string tags to tooltip
* Add initial show delay
* Seperated textbox for title and path
* Folder plugin - copy path
* indexer plugin - localized
* removed program plugin reference as it was not needed
* program plugin localized
* shell plugin localized
* removed extra semi colon
* Added loc files in other languages as well for indexer
* Added the inotifyPropertyChanged to all the properties and that stops the memory for shooting up
* some more inotify properties added
(cherry picked from commit 26fa05d9b661dadc5ab0257d540ab838a07c43a6)
* Revert "some more inotify properties added"
This reverts commit 845a94c9b2.
* Removed unnecessary inotifypropertychanged interfaces and cleaned up the code
* removed the ctrl+c from folder plugin
* removed unnecessary init
* Added unit test to check if PropertyChanged is called
* renamed var
* refactored the tests
* formatting and adding comments
* changed access modifier in test
* Used observable collection instead of a list
* clearing the observable collection instead of setting it to a new one
* Migrate theme manager to infrastructure and added it as input to public API instance
* Working event-delegate for PublicAPIInstance
* Theme aware UWP applications
* Theme aware program plugin
* Update query icon on theme change
* Theme aware calculator plugin
* Fix issue with query running before theme change
* Theme based changes in ImageLoader
* Removed ErrorIcon direct references and added references from ImageLoader
* Nit fixes
* Removed unnecessary TODO in UWP.cs
* Added preference to theme based icons
* Added IDisposable interfaces to unsubscribe events
* Clean termination of powertoys process.
* Fixed issue with run not responding to WM_CLOSE
* Fixed serialization error in pinyin and image cache
* Fixed merge conflict
* Fixed nit wrt to master
* Basic framework of clearing up of cache is working
* formatting
* removed the default argument of load
* fixed nit comment
* rewriting the PowerToys version
* Each storage file has an associated version file which helps decide whether or not to delete that file on loading
* removed unnecessary reference
* renamed file to StoragePowerToysVersionInfo
* adding log files
* Checking whether the version strings are null, if so, we would clear the cache
* Added filepath to log files to make it more informative
* fixed nit naming
* using lesser than to compare instead of portable version
Co-authored-by: Divyansh Srivastava <somm14divi@gmail.com>
* reducing storage of images
* Added task.run
* cleaned up code and added comments
* Renamed variable
* refactored code
* Removed task.run because it was leading to race conditions in the concurrent dictionary and it was taking only upto 10 ms for reordering the dictionary
* Added comments and fixed variable name
* Clean termination of powertoys process.
* Fixed issue with run not responding to WM_CLOSE
* Fixed serialization error in pinyin and image cache
* Fixed merge conflict
* Fixed nit wrt to master
* Fixed undeterministic behaviour of Environment.Exit function
* Update timing for terminate process
Error CS0436 The type 'ActionKeywords' in 'C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\ActionKeywords.xaml.cs' conflicts with the imported type 'ActionKeywords' in 'Wox, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\ActionKeywords.xaml.cs'. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\ActionKeywords.xaml 7 Active
Severity Code Description Project File Line Suppression State
Warning CA1060 Move pinvokes to native methods class PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs 24 Active
Warning CA1812 ReportWindow is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it static (Shared in Visual Basic). PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\ReportWindow.xaml.cs 15 Active
Warning CA1307 The behavior of 'string.IndexOf(string)' could vary based on the current user's locale settings. Replace this call in 'PowerLauncher.MainWindow.ListView_FirstItem(string)' with a call to 'string.IndexOf(string, System.StringComparison)'. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs 269 Active
Severity Code Description Project File Line Suppression State
Warning CA1823 Unused field '_progressBarStoryboard'. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs 27 Active
Severity Code Description Project File Line Suppression State
Warning CA2007 Consider calling ConfigureAwait on the awaited task PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs 305 Active
Warning CA1801 Parameter text of method DelayedCheck is never used. Remove the parameter or use it in the method body. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs 303 Active
Warning CA1820 Test for empty strings using 'string.Length' property or 'string.IsNullOrEmpty' method instead of an Equality check. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs 291 Active
Warning CA1031 Modify '.ctor' to catch a more specific allowed exception type, or rethrow the exception. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\SettingsWatcher.cs 33 Active
Settings.json is locked by the settings application and throws a system IO Exception. This should be syncronized with the settings application, but for now I'm just fixing the exception to be more specific and not hide unexpected exceptions.
System.IO.IOException: 'The process cannot access the file 'C:\Users\ryanbod\AppData\Local\Microsoft\PowerToys\PowerToys Run\settings.json' because it is being used by another process.'
Severity Code Description Project File Line Suppression State
Warning CA1031 Modify 'OverloadSettings' to catch a more specific allowed exception type, or rethrow the exception. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\SettingsWatcher.cs 76 Active
Severity Code Description Project File Line Suppression State
Warning CA1822 Member 'ConvertHotkey' does not access instance data and can be marked as static PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\SettingsWatcher.cs 85 Active
Severity Code Description Project File Line Suppression State
Warning CA1822 Member 'WaitForPowerToysRunner' does not access instance data and can be marked as static PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs 130 Active
Severity Code Description Project File Line Suppression State
Warning CA1401 P/Invoke method 'OpenProcess' should not be visible PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs 125 Active
Warning CA1806 Main calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs 45 Active
Warning CA1062 In externally visible method 'void App.Main(string[] args)', validate parameter 'args' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs
Warning CA1001 Type 'MainWindow' owns disposable field(s) '_firstDeleteTimer' but is not disposable PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\MainWindow.xaml.cs
Warning CA1816 Change App.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. PowerLauncher C:\Repos\PowerToys\src\modules\launcher\PowerLauncher\App.xaml.cs
* Search for programs in the path env variable
* removing list of disabled programs
* Added env variable string to classify apps
* reverted the fullpath change
* removing full paths while calculating dups
* removed dups
* removed debugging code
* Renamed to run command
* Added condition to filter run commands unless there is an exact match
* renamed occurances to RUN COMMAND
* localized the subtitle - Run command
* Added tests
* add fullpath back to hash calculation
* renamed the function
* Added support to index desktop app
* Fixed dedup for url files
* Added internet shortcut scheme for epic games
* Added test for internet shortcut dedup
* Updated hostname for steam game
