Commit Graph

2949 Commits

Author SHA1 Message Date
Jaime Bernardo
53133f0904
[HotFix]Revert "[FancyZones]Filtering popup windows for all operations (#28975)" (#29532)
This reverts commit 1b333dfee0.
2023-10-31 11:08:18 +00:00
Michael Nadeau
cded4efff7
[PTRun][Dev]Fix additional option default values not taking settings values (#29480) 2023-10-31 09:24:54 +00:00
Stefan Markovic
66f4f69841
[EnvVar]Mark and disable editing of user variables that are applied by a profile (#29451)
* [EnvVar] Mark profile variable in user variables

* Mark backup variables

* Add tooltip to icon, put in header and disable editing of applied var

* Use completed icon instead

* Better var name and comments

---------

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
2023-10-27 11:59:52 +01:00
Stefan Markovic
1dde699688
[EnvVar]Do not expand variables when looking for backup variables (#29431)
* [EnvVar] Do not expand when looking for backup variable

* Revert unneeded change
2023-10-26 11:01:26 +01:00
Stefan Markovic
04a7adf6a4
[EnvVar]Fix how expanded variables are processed (#29418)
* Read variables from registry (without expanding), not by using Environment API
Fix seting variables to registry

* Expand in Applied variables list

* Remove using

* Add comments
2023-10-25 19:03:15 +01:00
Andrey Nekrasov
ef6b17c5d1
[PowerRename]Save data from the last run outside of the settings file (#28861)
* [PowerRename] Sync settings before saving last window size

* address review comments
2023-10-24 21:49:09 +01:00
Zuo Zongyuan
cd7a9cc696
[PTRun][VSCode]Fix support for VSCodium and add support for Remote - Tunnels (#28742)
* feat: fix support for VSCodium stable & insider

* feat: add support for Remote Tunnels
2023-10-24 17:03:02 +01:00
Davide Giacometti
5a06bcb473
[Peek]Add wrap and formatting options for Monaco previewer (#29378)
* add options for monaco previewer

* fix formatting
2023-10-24 14:32:35 +01:00
Stefan Markovic
9693fd7035
[EnvVar] Add separator between variable value textbox and list in edit variable dialog (#29332)
* [EnvVar] Add separator between variable value textbox and list in edit list variable dialog

* Update Edit variable dialog labels

* Comment localization updates
2023-10-24 12:39:59 +02:00
Fredrik Salomonsson
8eb48676f2
[MouseHighlighter]Remove lower limit of fade delay and duration (#29352)
* Removed limit for MouseHighlighter Animation Duration and Animation Delay.
(If user sets these values to 0ms, it will actually be set to 1ms to avoid crashing the app)

* Update MouseHighlighter.cpp

Removed the hack ;D

* Update MouseHighlighter.cpp

* Update MouseUtilsPage.xaml

Changed the values to 1

* Update MouseHighlighter.cpp

Reintroducing workaround

* Update MouseUtilsPage.xaml

Changed the minimum values for FadeDelayMs and FadeDuration back to 0.
2023-10-24 11:11:29 +01:00
Stefan Markovic
6a092548b1
[Refactor]Use same improved BringToForeground across the solution (#28532)
* Use single BringToForeground across the solution

* Close flyout manually

* Try with sending input, if it fails try threads
2023-10-23 17:16:11 +01:00
Stefan Markovic
f718bef45c
[EnvVar]Do not allow Edit/Remove system var if not running elevated (#29333) 2023-10-23 17:14:56 +01:00
Seraphima Zykova
78a94aecb9
[FancyZones]Fix moving windows on other virtual desktops (#29059)
* clean up obsolete vd check

* clean up

* replace virtual desktop id usage

* check current vd
2023-10-23 15:13:24 +01:00
Stefan Markovic
812b343776
🚧 [new module] Environment variables editor (#28722)
* Init EnvironmentVariables UI project

* Models
TitleBar
MainPage init
Icon

* User and system variables

* Profiles init

* XAML cleanup

* Missing ItemTemplate

* EditDialog

* ModuleInterface

* Signing and processes lists

* Installer

* spellcheck

* Fix ARM64 build and consolidate packages

* spellcheck2

* Fix installer

* Single instance. C# telemetry. Wait on PT pid

* ElevationHelper

* Add profile wip

* Init EnvironmentVariables UI project

* Models
TitleBar
MainPage init
Icon

* User and system variables

* Profiles init

* XAML cleanup

* Missing ItemTemplate

* EditDialog

* ModuleInterface

* Signing and processes lists

* Installer

* spellcheck

* Fix ARM64 build and consolidate packages

* spellcheck2

* Fix installer

* Single instance. C# telemetry. Wait on PT pid

* ElevationHelper

* Add profile wip

* show run as administrator in title (#28516)

* Environment Variables added to Run plugin (#28466)

* UI tweaks

* Remove style

* Add profile - init working

* Applied variables

* Read/Write profiles

* Fixes

* Add separator and fix loading profiles

* Only allow to edit System vars if running elevated

* Add tmp progress ring to show applying changes progress
Ignore not needed json fields

* Remove variable and profile logic

* Do not read data async
Update System and User variables on change

* Add isCorrectlyApplied()

* Sort variables in Applied variables

* WIP WndProc

* spellcheck

* Revert "WIP WndProc"

This reverts commit 0c0b6c67de.

* WHY CRASH???

* UI tweaks

* WIP modified state warning

* Add cancel button in dialogs

* Add buttons validations

* Set variables - fire and forget notify

* Revert "Revert "WIP WndProc""

This reverts commit 1b2306eeb7.

* Listen to WM_SETTINGSCHANGED
Add Infobar reload button

* spellcheck

* spellcheck again

* Fix build

* InfoBar runAsAdmin visibility

* Fix comment

* Confirm dialog when deleting variable
Fix add variable button when creating profile

* Edit profile

* Sort variables on Load

* Select existing variables on edit

* Add default variable

* Fix adding existing vars to profile

* update notice.md

* Handle PATH properly

* Add tooltips and fix dialogs text wrapping

* Fix applied values for duplicates
Fix add/eddit variable txt box validation

* Add horizontal scroll bar for applied values

* Fix duplicate variables handling
Fix user variable handling and preview

* spellcheck

* Try fix spellcheck

* Revert "spellcheck"

This reverts commit ee76231974.

* Revert "Try fix spellcheck"

This reverts commit dc8f04afb9.

* Fix path and duplicates conflict

* Fix PATH handling
Fix unapply on delete active variable
Fix ordering in applied variables

* Show variables as lists and add drag-to-reorder feature

* Only show specific variables as list
Update list in edit dialog on editing the value

* spellcheck

* Update GPO policy

* Add Edit and Remove variable buttons
Remove context menu

* Remove drag&drop when editing list variable and add buttons to move up/down

* Fix Edit profile dialog title

* Fix backup and restore variables when editing variable from applied profile

* Apply var to system WIP

* Tweaks

* Simplify edit variable logic

* Minor fixes

* Spellcheck

* Update src/modules/EnvironmentVariables/EnvironmentVariables/app.manifest

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>

* spellcheck 2

* Remove unneeded string

* Add more telemetry

* Do not allow adding existing variables with the same name into the profile

* Adding icon

* Fix the crash when opening existing variables dialog

* Update Settings and OOBE screenshots

* Fix crash when malformed profiles.json and jsonignore not needed properties

* Fix selecting duplicates in existing variables dialog

* Add user variable name limit (<255 chars)
Check if profile is applicable on apply
Show message if profile is not applicable

* XamlStyling

* Better Flyout positioning
Add Cancel button to the flyout

* Fix UI glitches by using ItemsControl (no virtualization)

* Fix spellcheck

* Fix XAML style

* Add horizontal scrollbar to applied variables

* Revert to ItemsRepeater

* Fix UI glitches by adding a decent minimum cache

* Fixing UI bugs

* Fix spellcheck

* Fix crash while trying to edit a User variable when there's no Parent
profile

* Fix issue overwriting backup var when you edit var on applied profile

* Fix nuking of variables when adding to applied profile

* Fix profile not being saved when deleting a variable

* Fix ValuesList empty crash, issues and no serialization

* fix spellcheck

* Allow in-line edit of list variables

* Fix xaml style

* Fix add profile variable cancel button logic

* Fix add profile variable cancel button logic - clean the list

* Bump VerticalCacheLength to 10

as in some cases UI glitch on expanding System variables was still present

* Fix profile Add variable button enable/disable logic

* Remove unneeded using

* Add to Dashboard

---------

Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Davide Giacometti <davide.giacometti@outlook.it>
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
2023-10-20 16:28:07 +02:00
Randy
8c22f0c485
[RegistryPreview]Fix wrong key path transversal when a key was a substring of a parent (#29311)
Replaced String.Replace with String.Substring to avoid the removal of multiple instances of a string, rather than just the last one.
2023-10-20 11:59:21 +01:00
Jaime Bernardo
6e598f54af
[KBM]Disable utility by default on new install (#29278) 2023-10-19 17:00:40 +01:00
Jaime Bernardo
f0b460312a
[Build]Fix building on Visual Studio 17.8 (#29303)
* Add definition to ignore deprecated stdext checked_array_iterator

* Disable warning to ignore direct mention of dll in C# headers

* Fix PowerAccent Keyboard Service build errors

* Remove unused event variables

* Fix uninitialized events

* Remove unused telemetry events

* Fix building ShortcutGuide

* Fix C-style casts

* Fix spellcheck
2023-10-19 15:04:09 +01:00
Fredrik Salomonsson
3c10542c4c
[ColorPicker]End picker session on right click (#29075)
* ColorPicker will now end user session on right click.

* Update IMouseInfoProvider.cs

changed RMouse to SecondaryMouse

* Update IMouseInfoProvider.cs

* Update MouseHook.cs

Changed names from RMouse to SecondaryMouse

* Update MouseInfoProvider.cs

changed names from RMouse to SecondaryMouse

* Update MouseInfoProvider.cs

* Update MainViewModel.cs

changed names from RMouse to SecondaryMouse

* Added handler for SecondaryMouseDown and made it start user session to avoid issues with right click to terminate ColorPicker

* Secondary Mouse Up will now end user session without opening context menus as a result of right clicking.

* Add comment about consuming the right mouse event
2023-10-19 15:01:58 +01:00
Seraphima Zykova
b6fa827e78
[Build]Fix broken FZEditor test after concurrent merges(#29282)
* no longer needed test

* update
2023-10-18 12:27:39 +01:00
Davide Giacometti
a370c17918
[Peek] Fix previous video flashing when peek is invoked (#29243) 2023-10-18 12:01:41 +01:00
Davide Giacometti
8b92789f78
[Peek] Fix first preview stuck loading (#29183)
* fix first preview stuck loading

* comment
2023-10-18 11:33:10 +01:00
Garrett Vernon
6a9d44fb4d
[FZ Editor] Replace list with a dictionary for the DefaultLayouts (#29135)
* Dictionary Implementation to fix temporal coupling. Swapped the setting order as proof
* changed Dictionary to use the monitor config and not int
2023-10-18 12:14:16 +02:00
Heiko
50cb279d2a
[PTRun][TimeDate]Unix Time in milliseconds, fix negative unix time input, error message improvement (#29149)
* add unix time in ms

* update dev docs

* unit tests

* fix spell check

* tool tip

* fix negative unix time input, improve regex, update unit tests, improve error message

* Update error handling and tests

* add tests and fix spelling

* small fixes
2023-10-18 10:45:00 +01:00
Garrett Vernon
cd99a2e848
[FZ Editor]Add tests to editor #197 + feedback (#29051)
* here are the tests for the fancy zones

* Wrote tests for GridLayoutModel

* Move FancyZonesEditor tests to right place, tests for default layout model

* fixed SettingTheVerticalLayoutShouldBeTheDefault test

* removed coverlet in the test project

* Fixes for comments on pr

* squashed and updated for comments

* Added the test to the pipeline

---------

Co-authored-by: Drew Gordon <andrewbengordon@gmail.com>
Co-authored-by: Caleb Wightman <agentcboy@gmail.com>
2023-10-18 08:07:48 +01:00
gokcekantarci
ec47805634
[STLThumbnail]Fix crashes on invalid files (#29172)
* [StlThumbnailProvider] STL reader is added to try catch block. Model checks are increased.

* [StlThumbnailProvider] Spellcheck fix
2023-10-17 17:53:20 +01:00
Andrey Nekrasov
413624397e
[VCM]Do not trigger cascade of un/mute changes (#29131) 2023-10-17 17:35:49 +01:00
Seraphima Zykova
d25edc33a2
[FancyZones] Replace "Keep windows in their zones" option to include work area and turn on by default (#29105) 2023-10-17 16:28:32 +02:00
Seraphima Zykova
1b333dfee0
[FancyZones]Filtering popup windows for all operations (#28975)
* updated popup check

* removed temporary fix

* spelling

* improve readability
2023-10-12 18:58:44 +01:00
Michael Clayton
93d80f542c
[MouseJump]Long lived background process (#28380)
* [MouseJump] Long lived background exe

* [MouseJump] Long lived background exe

* [MouseJump] Long lived background exe

* [MouseJump] Long lived background exe

* [MouseJump] Close long lived background exe when parent runner exits

* [MouseJump] Close long lived background exe when parent runner exits

* [MouseJump] long lived background exe - fixing build

* [MouseJump] - add FileSystemWatcher for config (#26703)

* Fix telemetry event
2023-10-11 15:58:19 +01:00
Heiko
602a3ff090
[PTRun][Enterprise]GPO for plugin enabled state (#27468)
* try code for gpo with pluginID param

* fix typo

* fixes

* update admx

* Add second policy to admx

* spelling fixes

* admx clean up

* add gpo code

* small fixes

* fixes

* fix cast

* update settings code

* bug fixes

* fix plugins disabled warning

* Info bar in settings

* settings ui fixes

* code clean up

* fix spelling

* fix spelling

* code optimization

* changes

* fix code

* switch to char*

* update comments

* validate plugin ID

* spell fixes

* spell fixes

* fix IPlugin interface

* Update Directory.Packages.props

hopefully fixes unit tests

* revert change of nuget pkg

* fixes

* fix spell check

* add todo comment

* improve gpo.h

* improve gpo.h

* update gpo.h

* clean up code in gpo.h

* fix build

* try to fix build

* xaml fix

* Fix getting string value from the registry

* communicate policy state suing settings.json

* various changes and gpo docs

* spell fixes

* PT Run: Policy handling

* spell fix

* fix logging

* fix admx revision

* revision fix 2

* review feedback 1

* review feedback 2

* dev docs update

* fix typo
2023-10-11 15:37:15 +01:00
Heiko
19827d0093
[PTRun][Shell]Shell selection and combobox improvements (#28972)
* Make combobox items sortable

* Update plugin settings

* settings description

* fix settings hang on outdated plugin code

* spell fixes, shell implementation, translation improvements

* rename property

* backward compatibility

* comment changes

* comment changes

* review feedback 1

* review feedback 2

* Code clean up
2023-10-11 13:54:49 +01:00
Davide Giacometti
5d669df21a
[FancyZonesEditor] XamlStyler formatting (#29126) 2023-10-11 11:34:06 +01:00
Davide Giacometti
ad392290bd
[Dev][Build]Fix XAML formatting for successful builds (#29132) 2023-10-10 20:14:56 +01:00
PesBandi
78f03932a0
[QuickAccent]Add Greek letters with tonos (#29013) 2023-10-10 17:02:37 +01:00
Dylan Briedis
e1944df89a
[Peek]Add support for Explorer preview handlers (#28690)
* Add support for preview handlers

* Fix spelling

* Fix DPI resizing and redraw

* Make source into an ObservableProperty

* Add handler visibility property

* Better error handling

* Add support for IInitializeWithItem

* Run preview handlers in separate processes

* Fix redrawing when switching previewers
2023-10-10 15:51:36 +01:00
Andrey Nekrasov
2991da5d70
[PowerRename][Dev]Suppress redundant midl warning (#29070)
* [PowerRename] Suppress redundant midl warning

* spelling

* f: spelling #2

* spelling 3
2023-10-09 16:21:18 +01:00
Davide Giacometti
6482e9b0de
[Build]Use XamlStyler to check XAML formatting (#28643)
* Use XamlStyler to check XAML formatting

* fix spellcheck

* fix

* format XAML FLS, Hosts, ImageResizer, MeasureTool, PowerRename

* format XAML Peek

* exclude settings XAML and make CI pass

* doc
2023-10-09 15:58:13 +01:00
Randy
898644f6f6
[RegistryPreview]Fix opening non-ascii filenames and spaces around assignments (#28786)
* BugFixes

Fixes for #26029 and #28147

* Adding fix for 28820
2023-10-06 14:48:39 +01:00
Quyen Le Van
99882508bc
[VCM]Add options to hide after timeout and startup action (#28658)
* VideoConference add new option ToolbarHide After timeout

* VideoConference add new behavior option startup action
2023-10-06 08:48:36 +01:00
Davide Giacometti
53ec08ebc0
[PTRun]Fix clear query on launch for action invoked from keyboard (#28822) 2023-10-04 12:47:46 +01:00
Blake
f03f838692
[QuickAccent]Add Asturian characters to the Spanish charset (#28966) 2023-10-04 11:53:07 +01:00
Brian Teeman
fd8d4b9387
[ShortcutGuide]Fix typo (#28990)
Fixes simple typo/grammar errors

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:10:58 +01:00
Brian Teeman
88e8696b4d
[File Explorer add-ons]Fix typo (#28989)
Fixes simple typo/grammar errors

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:09:23 +01:00
Brian Teeman
8a376225ce
[Peek] Fix comments typo (#28987)
Fixes simple typo/grammar errors

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:08:33 +01:00
Brian Teeman
20fa3740bd
[PTRun] Fix comments typos (#28986)
Fixes simple typo/grammar errors

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:07:40 +01:00
Brian Teeman
0f8a4ae6f4
[ImageResizer]Fix comment typos (#28985)
Fixes simple typo/grammar error which otherwise could be read as height

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:05:06 +01:00
Brian Teeman
98e2a62c21
[Hosts]Fix typo (#28984)
Fixes simple typo/grammar error.

It's easier to understand if it is spelled correctly. This is especially important for those for whom english may not be their first language.

Signed-off-by: brian teeman <brian@teeman.net>
2023-10-04 11:02:37 +01:00
Deepak Sangle
7f8e9072c9
[Peek]Fix file and folder sizes to be similar to Explorer (#28089)
* [Peek] displaying file size in correct grammatical format

* Update Directory.Packages.props

* removed unnecessary file

* [Peek] Added new symbols in resources.resw

* [Peek] added commas separation

* modified spell check

* [Peek] Changed 1024 factor to 1000 factor

* modified spell check

* made string country specific

* fix: used 1024 and fixed precision

* spellcheck fixed

* Update src/modules/peek/Peek.UI/Strings/en-us/Resources.resw

* Update src/modules/peek/Peek.UI/Strings/en-us/Resources.resw
2023-10-03 16:32:34 +01:00
John Erickson
5e2733ece9
[Build]Add missing dependencies on version.h (#28619)
* Fix version.h dependencies

* fix for build_vcm_x86
2023-10-03 16:31:14 +01:00
Andrey Nekrasov
e14ff34b37
[SVGPreview]Handle comments properly (#28863)
* [SVGPreview] Handle comments properly

* f: spelling

* f: add tolerance to the bitmap eq test

* f: remove bitmap eq testing, since it doesn't work on CI for some reason

* f: parsing issue
2023-10-02 21:42:31 +01:00