21 Commits

Author	SHA1	Message	Date
Clint Rutkas	83e8799610	init checkin (#6100)	2020-08-21 12:40:31 -07:00
Clint Rutkas	d055ba1c3b	whitespace forced changes (#6002)	2020-08-17 10:00:56 -07:00
Clint Rutkas	e0a1b478a1	Program plugin fully on stylecop (#5964)	2020-08-14 12:46:23 -07:00
Clint Rutkas	913615f1c2	more braces and whitespace style errors (#5951)	2020-08-14 09:22:12 -07:00
Clint Rutkas	e02977edc0	Whitespace and type fixes (#5917)	2020-08-13 15:31:14 -07:00
Clint Rutkas	95e82ca359	[stylecop] program plugin/unit test first pass (#5908) ... * initial pass * multiple whitespace fixes	2020-08-12 11:46:11 -07:00
ryanbodrug-microsoft	ac10c988b9	Enable Static Analysis on programs plugin (#5847) ... * Removing unused ProgramSettings constructor paramaters. * Fix for: Severity Code Description Project File Line Suppression State Error CA1829 Use the "Count" property instead of Enumerable.Count(). Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 182 Active Severity Code Description Project File Line Suppression State Error CA1827 Count() is used where Any() could be used instead to improve performance. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 287 Active * Fixes for CA1031: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * More fixes(Suppression) for CA1031 (Catching base exception) https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * Fix for nested types being externally visible. CA1034 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Fix for CA1028 If possible, make the underlying type of Hresult System.Int32 instead of uint. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Programs\UWP.cs 236 Active * Fix for CA2227 Collection properties should be readonly. https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2227?view=vs-2019 Fix rror CA2211 Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * CA2208: Instantiate argument exceptions correctly https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2208?view=vs-2019 * Win32.cs Static analysis fixes: CA2200: Rethrow to preserve stack details https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200?view=vs-2019 CA1825: Avoid zero-length array allocations https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1825?view=vs-2019 CA2211: Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * More Win32.cs static analysis fixes: CA1307: Specify StringComparison https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019 Verifying query is not null before using it. CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 * UWPApplication. CA2007: Do not directly await a Task https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019 * Error CA2010 Consume the hresult returned by method 'Microsoft.Plugin.Program.Programs.AppxPackageHelper.IAppxManifestApplication.GetStringValue(string, out string)' and call Marshal.ThrowExceptionForHR. Note: CA2010 has been removed from future FXCop versions as it can provide incorrect advice for methods that don't return hresult (possibly when [PreserveSig] has been incorrectly labeled.) I've verified the methods in question do still return hresults. * More fixes for Error CA2010 Consume the hresult returned by method and call Marshal.ThrowExceptionForHR. * Fixes for: Error CA2000 Call System.IDisposable.Dispose on object created before all references to it are out of scope. * Suppress CA1031:Do not catch general exception types * Fixes for Error CA1034 Do not nest type ... * Fixing Unit tests that were broken as per a previous fix. * Fix for: CA1034: Nested types should not be visible: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Suppressing CA1707 for native/com types. CA1707:Identifiers should not contain underscores * Fix for Error CA1307 The behavior of 'string.Replace(string, string?)' could vary based on the current user's locale settings. * Fixes for Error CA1825 Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. * Fix for: Error CA1823 Unused field 'IndexLock'. * Fixes for CA1822: Mark members as static: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822?view=vs-2019 * Fix for Error CA1819 Properties should not return arrays * Fix for Error CA1806 ContextMenus calls Trim but does not use the new string instance that the method returns. Pass the instance as an argument to another method, assign the instance to a variable, or remove the call if it is unnecessary. * Fix for Error CA1801 Parameter settings of method UpdateSettings is never used. Remove the parameter or use it in the method body. * Fix for Error CA1724 The type name Settings conflicts in whole or in part with the namespace name 'Microsoft.PowerToys.Settings'. * Includes FxCop for static analysis * Fix for Error CA1717 Only FlagsAttribute enums should have plural names * Suppress Stgm flags: Error CA1714 Flags enums should have plural names Microsoft.Plugin.Program * Rename Win32 to Win32Program Fix for: Error CA1724 The type name Win32 conflicts in whole or in part with the namespace name 'Microsoft.Win32' defined in the .NET Framework. Rename the type to eliminate the conflict. * Fixes for Error CA1507 Use nameof in place of string literal * Using ordinal instead of invariant culture when not symbolic comparison * CA1308: Normalize strings to uppercase https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1308?view=vs-2019 * CA1304: Specify CultureInfo CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1304?view=vs-2019 * CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 * CA1056: URI properties should not be strings https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1056?view=vs-2019 Fix: Making LogoURi private, as it is only used internally and operated on as a string * Warning CA1052 Type 'AppxPackageHelper' is a static holder type but is neither static nor NotInheritable * CA1060: Move P/Invokes to NativeMethods class https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1060?view=vs-2019 * Programs Plugin - Treat warnings as errors true * CA1031:Do not catch general exception types Missed release only compile issue. Making debug and release behave the same. * Renaming 'Create' to 'CreateWin32Program' based on PR feedback.	2020-08-11 09:08:44 -07:00
Clint Rutkas	14247fa75a	Dev/crutkas/fixing warnings (#5161) ... * new lines & braces * Tabs /space auto fix Co-authored-by: Clint Rutkas <crutkas@microsoft.com>	2020-07-22 13:27:17 -07:00
Alekhya	b59ec5e78b	Fix for internet shortcut app not showing up on installation (#5131) ... * added changed for internet shortcut app * Added AppChanged event for url files * Tests added * refactoring	2020-07-22 10:58:01 -07:00
Alekhya	d09253e532	Functionality to detect Win32 apps which are installed, deleted or renamed while PowerToys is running (#4960) ... * Added file system wrapper and interface * added win32program repository which would load store app and also handle new apps being added/deleted * Added event handlers to win32 program repo * added paths to monitor and setting FSWs for each location * Events firing as expected * filter extensions added, events fire as expected * override gethashcode so that duplicates don't show up. OnCreated and OnDeleted events trigger as expected * implemented setter for filters in FileSystemWatcher * Rename adds item but does not seem to delete the previous app * catching an exception when a duplicate item is inserted * Removed notify filter for directory because we only need to monitor files * Added exe programs to be indexed in the desktop and startmenu * created a new class to init FileSystemHelpers instead of main * Added fix for shortcut applications to work as expected while renaming and deleting them * Added wrappers for file system operations * Added some tests * Added all tests for appref-ms and added a condition to search in sub directories * Added tests for Exe applications * Added lnk app tests * Added tests for shortcut applications * removed unnecessary wrappers * override Equals for win32 * removed debug statements * Fixed exe issue * Fixed internet shortcut exception * fixed renaming shortcut apps * Added a retry block for ReadAllLines * capitalized method name - RetrieveTargetPath * made naming consistent, helper variables start with underscore * Added the exception condition back * renamed Win32ProgramRepositoryHelper to Win32ProgramFileSystemWatchers * made win32Program repository variable static * changed list to ilist * disposed file system watchers * make retrieveTargetPath upper case in tests	2020-07-17 22:32:21 -07:00
Alekhya	f59abe23c3	Fix for File Not Found exception while indexing invalid Package App (#4971) ... * Catching file not found exception * removed unnecessary header files * Added a string.empty check for installed location * reusing package wrapper instead of package installing event args	2020-07-14 11:44:50 -07:00
Divyansh Srivastava	653ae777d5	Packaged apps test (#4921) ... * Added wrapper for PackageManager and Package class * Added tests for package in development and framework mode * Renamed UWP test file * Improved readability of UWP tests	2020-07-10 13:43:02 -07:00
ryanbodrug-microsoft	b1d662a5b1	Improving performance of Adding and Removing Packaged Apps (#4521) (#4900) ... * Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests * Fixing message format for exception * Changing test structure. Need to add unit tests. * Updating packagerepository comment based on pr feedback * Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary. * Removing unecessary implementation of IRepository interface as this is implemented by the base class. * Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor. * Fixing comments * Adding newline to end of file for IProgramRepository	2020-07-09 13:14:53 -07:00
ryanbodrug-microsoft	12d9d59d85	Revert "Improving performance of Adding and Removing Packaged Apps" (#4898) ... * Revert "Adding newline to end of file for IProgramRepository" This reverts commit d55cac80bf. * Revert "Fixing comments" This reverts commit a1ecdc9bfa. * Revert "Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor." This reverts commit 0e8c1cb0fd. * Revert "Removing unecessary implementation of IRepository interface as this is implemented by the base class." This reverts commit 1c724280f5. * Revert "Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary." This reverts commit 9ff8246a9d. * Revert "Updating packagerepository comment based on pr feedback" This reverts commit 2c45956030. * Revert "Changing test structure. Need to add unit tests." This reverts commit 1c267a55d5. * Revert "Fixing message format for exception" This reverts commit f60bdc3dd4. * Revert "Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests" This reverts commit 030dfc2370.	2020-07-09 12:10:48 -07:00
ryanbodrug-microsoft	d55cac80bf	Adding newline to end of file for IProgramRepository	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	1c724280f5	Removing unecessary implementation of IRepository interface as this is implemented by the base class.	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	9ff8246a9d	Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary.	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	2c45956030	Updating packagerepository comment based on pr feedback	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	1c267a55d5	Changing test structure. Need to add unit tests.	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	f60bdc3dd4	Fixing message format for exception	2020-07-09 07:02:19 -07:00
ryanbodrug-microsoft	030dfc2370	Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests	2020-07-09 07:02:19 -07:00