Commit Graph

3 Commits

Author SHA1 Message Date
Josh Soref
72d92413a2
Upgrade check-spelling to 0.0.17-alpha (#10173)
* spelling: snapped

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: split

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* ci: update to Spell check to 0.0.17a

In the past, plurals `foo`+`s` and past tenses `foo`+`ed` were
automatically tolerated. This turned out to be a bad design choice on my
part.

The basic example is that `potatos` would sometimes be treated as a
mistake and sometimes not (depending on the presence of `potato`).

You can see in this PR, that this logic resulted in `SNAPED` being
accepted as a word along with `actioned` -- there's nothing
intrinsically wrong w/ the latter, but unfortunately in order to screen
out the former, my shortcut just couldn't stick around. This means that
the `expect` files will grow perhaps by a tiny bit, but as
you can see, not really by much.

When GitHub initially introduced GitHub Actions, the event for
`pull_request` was created without enough permission for a tool like
this to work properly. I worked around that by using the `schedule`
event. In 2020, they introduced a replacement event
`pull_request_target` which has enough permission. This means that I can
stop relying on the `schedule` event.
2021-03-17 19:27:30 +01:00
Clint Rutkas
33866c124e
Add CodeQL Analysis (#8598) (#8653)
* Add CodeQL Analysis (#8598)

* Create codeql-analysis.yml

* Add manual build steps for C++

* Add nuget restore

* Remove autobuild for C#

* Add CodeQL and Javascript to spell check

* Update to run daily only

Since the build performance is around an hour, this is a bit too slow for a PR build.

* Update codeql-analysis.yml

testing on push, will remove later

* Update codeql-analysis.yml

removing python

* Update codeql-analysis.yml

adding in comments then will remove push once this is verified working

* Update codeql-analysis.yml

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-12-28 13:30:04 -08:00
Josh Soref
1e58ae0e63 Set up spell-checking action 2020-05-20 23:19:08 -04:00