3856 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Clint Rutkas	f1bb533321	[StyleCop] Wox.Plugin - last amount needed to fully integrate (#5853) ... * StyleCop for Plugin * getting release mode working	2020-08-11 13:41:41 -07:00
Clint Rutkas	2c49df4be3	more fixes for getting styleCop up, this will need one more push to get another 15 that will require renaming of vars (#5875)	2020-08-11 13:40:26 -07:00
Roy	90502f7553	Add Microsoft.Plugin.Uri.UnitTests to CI + Fix Tests (#5878) ... Co-authored-by: Roy <royvou@hotmailcom>	2020-08-11 11:49:44 -07:00
Mehmet Murat Akburak	18f5c7f691	[PowerRename] Use the same label size for all options (#5870)	2020-08-11 21:31:16 +03:00
Clint Rutkas	649606f32e	Update bug_report.md	2020-08-11 11:19:39 -07:00
Clint Rutkas	0f54cc147e	Update bug_report.md	2020-08-11 11:19:30 -07:00
Clint Rutkas	7781f41ebf	Update bug_report.md	2020-08-11 11:19:13 -07:00
Divyansh Srivastava	2d2cb22806	Stable sorting of ResultCollection (#5850) ... * Stable sorting of ResultCollection * nit fixes for resultsViewModel and ResultCollection	2020-08-11 10:24:56 -07:00
ryanbodrug-microsoft	ac10c988b9	Enable Static Analysis on programs plugin (#5847) ... * Removing unused ProgramSettings constructor paramaters. * Fix for: Severity Code Description Project File Line Suppression State Error CA1829 Use the "Count" property instead of Enumerable.Count(). Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 182 Active Severity Code Description Project File Line Suppression State Error CA1827 Count() is used where Any() could be used instead to improve performance. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 287 Active * Fixes for CA1031: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * More fixes(Suppression) for CA1031 (Catching base exception) https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * Fix for nested types being externally visible. CA1034 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Fix for CA1028 If possible, make the underlying type of Hresult System.Int32 instead of uint. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Programs\UWP.cs 236 Active * Fix for CA2227 Collection properties should be readonly. https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2227?view=vs-2019 Fix rror CA2211 Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * CA2208: Instantiate argument exceptions correctly https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2208?view=vs-2019 * Win32.cs Static analysis fixes: CA2200: Rethrow to preserve stack details https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200?view=vs-2019 CA1825: Avoid zero-length array allocations https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1825?view=vs-2019 CA2211: Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * More Win32.cs static analysis fixes: CA1307: Specify StringComparison https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019 Verifying query is not null before using it. CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 * UWPApplication. CA2007: Do not directly await a Task https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019 * Error CA2010 Consume the hresult returned by method 'Microsoft.Plugin.Program.Programs.AppxPackageHelper.IAppxManifestApplication.GetStringValue(string, out string)' and call Marshal.ThrowExceptionForHR. Note: CA2010 has been removed from future FXCop versions as it can provide incorrect advice for methods that don't return hresult (possibly when [PreserveSig] has been incorrectly labeled.) I've verified the methods in question do still return hresults. * More fixes for Error CA2010 Consume the hresult returned by method and call Marshal.ThrowExceptionForHR. * Fixes for: Error CA2000 Call System.IDisposable.Dispose on object created before all references to it are out of scope. * Suppress CA1031:Do not catch general exception types * Fixes for Error CA1034 Do not nest type ... * Fixing Unit tests that were broken as per a previous fix. * Fix for: CA1034: Nested types should not be visible: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Suppressing CA1707 for native/com types. CA1707:Identifiers should not contain underscores * Fix for Error CA1307 The behavior of 'string.Replace(string, string?)' could vary based on the current user's locale settings. * Fixes for Error CA1825 Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. * Fix for: Error CA1823 Unused field 'IndexLock'. * Fixes for CA1822: Mark members as static: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822?view=vs-2019 * Fix for Error CA1819 Properties should not return arrays * Fix for Error CA1806 ContextMenus calls Trim but does not use the new string instance that the method returns. Pass the instance as an argument to another method, assign the instance to a variable, or remove the call if it is unnecessary. * Fix for Error CA1801 Parameter settings of method UpdateSettings is never used. Remove the parameter or use it in the method body. * Fix for Error CA1724 The type name Settings conflicts in whole or in part with the namespace name 'Microsoft.PowerToys.Settings'. * Includes FxCop for static analysis * Fix for Error CA1717 Only FlagsAttribute enums should have plural names * Suppress Stgm flags: Error CA1714 Flags enums should have plural names Microsoft.Plugin.Program * Rename Win32 to Win32Program Fix for: Error CA1724 The type name Win32 conflicts in whole or in part with the namespace name 'Microsoft.Win32' defined in the .NET Framework. Rename the type to eliminate the conflict. * Fixes for Error CA1507 Use nameof in place of string literal * Using ordinal instead of invariant culture when not symbolic comparison * CA1308: Normalize strings to uppercase https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1308?view=vs-2019 * CA1304: Specify CultureInfo CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1304?view=vs-2019 * CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 * CA1056: URI properties should not be strings https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1056?view=vs-2019 Fix: Making LogoURi private, as it is only used internally and operated on as a string * Warning CA1052 Type 'AppxPackageHelper' is a static holder type but is neither static nor NotInheritable * CA1060: Move P/Invokes to NativeMethods class https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1060?view=vs-2019 * Programs Plugin - Treat warnings as errors true * CA1031:Do not catch general exception types Missed release only compile issue. Making debug and release behave the same. * Renaming 'Create' to 'CreateWin32Program' based on PR feedback.	2020-08-11 09:08:44 -07:00
Ivan Stošić	83de1686c0	Don't wait for ColorPicker.exe to close (#5866)	2020-08-11 17:06:28 +02:00
vldmr11080	145347f7ae	[FancyZones] Clasify strings in FancyZones to localizable and non-localizable (#5315) ... * Clasify strings in FancyZones to localizable and non-localizable * Address PR comments * Better handling of FirePropertyChanged event * Address PR comments * Update properties	2020-08-11 13:51:06 +02:00
Ivan Stošić	b8b6dbe791	Potential fix for a crash in OnThreadExecutor (#5840)	2020-08-11 10:39:18 +02:00
Divyansh Srivastava	d21201e996	Reduce program plugin results (#5743) ... * Added minimum score threshold * nit fix for program plugin	2020-08-10 16:25:34 -07:00
Clint Rutkas	dc35fc450b	Update community.md	2020-08-10 15:57:43 -07:00
Clint Rutkas	c4140dd38b	Update community.md	2020-08-10 15:57:31 -07:00
Roy	ba2ef23414	[PowerToys Run] Add Support for Uris (#5160) ... * url handler plugin * updates * Add seperate interface classes rename to uri module * Update path * Update implementation to remove slow DNS lookup ( and let browser handle it) * tabs to spaces * - Update icon/assets - Finalize Project * Update wix project * Implement UpdateBrowserIconPath * Implemented Microsoft.CodeAnalysis.FxCopAnalyzers * Add Language component to installer * Update logic to determine icon * Update Translation File to "Open in browser" * Added test for typing http://test.com and which result to expect on each keystoke * Implement StyleCop * Added ipv6 tests * Fix Solution LineBreaks * Added Microsoft.Plugin.Uri as build Dependency * Use ArgumentNullException instead of InvalidOperationException * Fix wrong Directory in wix installer Co-authored-by: Roy <royvou@hotmailcom>	2020-08-10 15:53:43 -07:00
Divyansh Srivastava	3781d1e06b	Consolidate folder and shell plugin (#5843) ... * Added folder plugin functionality to shell plugin * Added QueryTextDisplay for shell plugin * Remove QueryTextDisplay change * Fix merge conflict issues	2020-08-10 15:51:02 -07:00
Clint Rutkas	082a78bd92	Getting remaining Tests on stylecop (#5846)	2020-08-10 15:49:36 -07:00
Clint Rutkas	7bfd0823db	Enabling StyleCop for folder plugin (#5844)	2020-08-10 13:28:22 -07:00
Enrico Giordani	013ffe1626	Now working on 0.20.2 (#5834)	2020-08-10 16:30:25 +02:00
Divyansh Srivastava	b2006f2466	Remove all plugin results on query change (#5796)	2020-08-07 19:27:52 -07:00
Niels Laute	7d8931696d	Localized Image resizer tooltip (#5529) ... Co-authored-by: Niels Laute <niels9001@hotmail.com>	2020-08-07 17:54:56 -07:00
Niels Laute	e88812458e	[Settings] Updated adaptive trigger behavior (#5434) ... * Updated adaptive trigger behavior * Fixed wrapping for KBM subtitle textblock * Fix Co-authored-by: Niels Laute <niels9001@hotmail.com>	2020-08-07 12:00:48 -07:00
Clint Rutkas	ada42f6e94	in theory this fixes all SA1649 issues now with any project with stylecop enabled (#5786)	2020-08-07 11:56:28 -07:00
Clint Rutkas	34c3b50b48	Incremental fix for StyleCop on Infra (#5729) ... * Fixes file names and classes don't match. All but PluginsSettings * making it pluginsettings * fixing due to conflict	2020-08-07 10:45:50 -07:00
Andrey Nekrasov	63c36d0dbf	runner: don't try to restart explorer (#5763)	2020-08-07 15:26:34 +03:00
Andrey Nekrasov	bd80bb6bb3	bootstrapper: add support for silent arg (#5590)	2020-08-07 12:00:14 +03:00
Ivan Stošić	8f98866d71	[FancyZones] Feature to create zone layouts spanning multiple monitors (#5289) ... * Added the setting * Added a property to Editor Settings This will be used later * Fixed a bug in the previous commit * Simplified a method * Added snapping points to the editor * Simplified a method in ZoneSet * Updated ZoneSet testcases * Add a method to FancyZones / ZoneWindowHost * Almost works * The editor now launches, but FZ does not understand the results * Refactored some code * Snapping to a zone by dragging seems to work * Hotkeys seem to work * Refresh the work area handler after changing settings * Fixed zones not snapping to monitor edges when moved * Remove unused method in FancyZones.h * Fixed an issue with DPI awareness * Renamed setting to spanZonesAcrossMonitors * Renamed a function * Fixed a bug with the magnetic effect * Fix restoring window positions on layout changes	2020-08-07 10:06:25 +02:00
Clint Rutkas	26bf05dd7e	whitespace changes (#5750)	2020-08-06 20:38:49 -07:00
Clint Rutkas	b815718c26	whitespace only (#5747)	2020-08-06 16:52:25 -07:00
Clint Rutkas	d7994ca67d	style cop wox.core whitespace changes (#5744) ... * whitespace changes * undoing csproj tweak to keep stylecop off	2020-08-06 16:51:47 -07:00
Arjun Balgovind	b95a1fb604	Unlinked the MaxResults value from settings and set to fixed value of 30 (#5742)	2020-08-06 16:44:13 -07:00
martinchrzan	b04bb2ef8d	Color picker respects right monitor side boundaries and does not go outside of the view (#5480)	2020-08-06 20:54:26 +02:00
martinchrzan	066aeec1e6	Fixed jerky zoom animation (#5483)	2020-08-06 20:53:16 +02:00
Clint Rutkas	d6e46d73b5	whitespace stylecop fixes for Wox.Infra (#5689) ... * Limited to whitespace * removing stylecop again	2020-08-06 11:28:13 -07:00
Clint Rutkas	7b767df0b5	getting stylecop undercontrol for UI warnings (#5630)	2020-08-06 11:16:25 -07:00
Clint Rutkas	ed36447bdf	Fixing stylecop violations (#5629)	2020-08-06 10:10:44 -07:00
Clint Rutkas	0f90af3c7d	URL audit (#5685)	2020-08-06 10:09:50 -07:00
stefansjfw	f50a8e5252	Fix difference in editor and applied focus layout zones size and increments (#5601)	2020-08-06 16:41:15 +02:00
vldmr11080	1d8ca28152	Don't restore minimized windows after layout is updated (#5603)	2020-08-06 16:22:47 +02:00
vldmr11080	6c4129d02a	[FancyZones] Do not restore maximized windows (#5597) ... * Do not restore maximized windows * Fix show command comparison * Move maximized check outside of RestoreWindowSize function	2020-08-06 15:12:49 +02:00
Andrey Nekrasov	9b4574ad06	CI: add installer (#5698)	2020-08-06 16:12:20 +03:00
Nkateko	4543b32bef	fix settings path (#5692) ... * fix settings path * Update settings_window.cpp * rollback commit #5487	2020-08-06 00:49:40 -07:00
Clint Rutkas	ff69f6ed7f	fixing most whitespace issues, reordering namespaces and adding in headers (#5677)	2020-08-05 14:06:55 -07:00
Clint Rutkas	92a2b83bc8	smaller stylecop fixes in Wox.Core and Wox.Infra (#5671) ... * Headers unneeded usings files need blank line at bottom Fixed double returns Returns after braces * commenting out stylecop	2020-08-05 14:06:42 -07:00
Alekhya	30b65028fe	Fix Code Related PT Run Accessibility issues (#5610) ... * set the name automation properties for the result elements * Added name properties to search box * removed the name for the grid * localized the automation property names of the launcher control * Localized the automation name property for the result list * Uncommented out the Hide() function which was commented out to run Accessibility Insights * modified resources from static to dynamic * reverted access modifier to internal as we are no longer using this * updated csproj file	2020-08-05 13:43:47 -07:00
Clint Rutkas	4b72b291ef	0.20.1 readme (#5669)	2020-08-05 12:23:12 -07:00
Andrey Nekrasov	59ebe30b72	runner: initialize COM security, so toast notifications work in elevated context from non-admin account (#5314)	2020-08-05 19:06:50 +03:00
Alekhya	814f6213fa	Added null check before using unregister hotkey function (#5627)	2020-08-05 08:06:03 -07:00
Andrey Nekrasov	dce3ee440b	bootstrapper: use a dedicated solution (#5318)	2020-08-05 17:20:50 +03:00