mirror of
https://github.com/microsoft/PowerToys.git
synced 2024-12-26 10:48:23 +08:00
ff1e04b957
* Added union class * Added key to shortcut backend implementation * Added tests * Added tests for CapsLock/modifier workaround for key to shortcut * Added correct JSON loading step * Cleaned shortcut remap code to use helper function for modifier keys * Removed RemapKey class * Enable Key to Shortcut in UI along with Type Shortcut in Remap key window * Fixed orphaning and unsuccessful remap dialog * Fixed column width * Renamed second type key button * Fixed Type Shortcut issues * Fixed shortcut to key backend logic and manually tested most scenarios * Added s2k in UI, manually verified its working * Added one more k2s test * Added tests for s2k * Added tests for Caps Lock workaround in shortcut remaps * Fixed formatting * Fixed formatting * Removed safety code since it can cause issues with code generated key up events * Added test for key up scenario * Tweaked warning text * Tweaked text * Tweaked text to fit in two lines * telemetry additions
317 lines
13 KiB
C++
317 lines
13 KiB
C++
#include "pch.h"
|
|
#include "CppUnitTest.h"
|
|
#include "MockedInput.h"
|
|
#include <keyboardmanager/common/KeyboardManagerState.h>
|
|
#include <keyboardmanager/dll/KeyboardEventHandlers.h>
|
|
#include "TestHelpers.h"
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
|
|
namespace RemappingLogicTests
|
|
{
|
|
TEST_CLASS (AppSpecificShortcutRemappingTests)
|
|
{
|
|
private:
|
|
MockedInput mockedInputHandler;
|
|
KeyboardManagerState testState;
|
|
std::wstring testApp1 = L"testtrocess1.exe";
|
|
std::wstring testApp2 = L"testprocess2.exe";
|
|
|
|
public:
|
|
TEST_METHOD_INITIALIZE(InitializeTestEnv)
|
|
{
|
|
// Reset test environment
|
|
TestHelpers::ResetTestEnv(mockedInputHandler, testState);
|
|
|
|
// Set HandleOSLevelShortcutRemapEvent as the hook procedure
|
|
std::function<intptr_t(LowlevelKeyboardEvent*)> currentHookProc = std::bind(&KeyboardEventHandlers::HandleAppSpecificShortcutRemapEvent, std::ref(mockedInputHandler), std::placeholders::_1, std::ref(testState));
|
|
mockedInputHandler.SetHookProc(currentHookProc);
|
|
}
|
|
|
|
// Test if the app specific remap takes place when the target app is in foreground
|
|
TEST_METHOD (AppSpecificShortcut_ShouldGetRemapped_WhenAppIsInForeground)
|
|
{
|
|
// Remap Ctrl+A to Alt+V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
Shortcut dest;
|
|
dest.SetKey(VK_MENU);
|
|
dest.SetKey(0x56);
|
|
testState.AddAppSpecificShortcut(testApp1, src, dest);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl and A key states should be unchanged, Alt and V key states should be true
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_MENU), true);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x56), true);
|
|
}
|
|
|
|
// Test if the app specific remap takes place when the target app is not in foreground
|
|
TEST_METHOD (AppSpecificShortcut_ShouldNotGetRemapped_WhenAppIsNotInForeground)
|
|
{
|
|
// Remap Ctrl+A to Alt+V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
Shortcut dest;
|
|
dest.SetKey(VK_MENU);
|
|
dest.SetKey(0x56);
|
|
testState.AddAppSpecificShortcut(testApp1, src, dest);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp2);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl and A key states should be true, Alt and V key states should be false
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), true);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), true);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_MENU), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x56), false);
|
|
}
|
|
|
|
// Test if the the keyboard manager state's activated app is correctly set after an app specific remap takes place
|
|
TEST_METHOD (AppSpecificShortcut_ShouldSetCorrectActivatedApp_WhenRemapOccurs)
|
|
{
|
|
// Remap Ctrl+A to Alt+V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
Shortcut dest;
|
|
dest.SetKey(VK_MENU);
|
|
dest.SetKey(0x56);
|
|
testState.AddAppSpecificShortcut(testApp1, src, dest);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Activated app should be testApp1
|
|
Assert::AreEqual(testApp1, testState.GetActivatedApp());
|
|
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = 0x41;
|
|
input[0].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = VK_CONTROL;
|
|
input[1].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
|
|
// Release A then Ctrl
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Activated app should be empty string
|
|
Assert::AreEqual(std::wstring(KeyboardManagerConstants::NoActivatedApp), testState.GetActivatedApp());
|
|
}
|
|
// Test if the key states get cleared if foreground app changes after app-specific shortcut is invoked and then released
|
|
TEST_METHOD (AppSpecificShortcut_ShouldClearKeyStates_WhenForegroundAppChangesAfterShortcutIsPressedOnRelease)
|
|
{
|
|
// Remap Ctrl+A to Alt+Tab
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
Shortcut dest;
|
|
dest.SetKey(VK_MENU);
|
|
dest.SetKey(VK_TAB);
|
|
testState.AddAppSpecificShortcut(testApp1, src, dest);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp2);
|
|
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = 0x41;
|
|
input[0].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = VK_CONTROL;
|
|
input[1].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
|
|
// Release A then Ctrl
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl, A, Alt and Tab should all be false
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_MENU), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_TAB), false);
|
|
}
|
|
|
|
// Test if the app specific shortcut to key remap takes place when the target app is in foreground
|
|
TEST_METHOD (AppSpecificShortcutToSingleKey_ShouldGetRemapped_WhenAppIsInForeground)
|
|
{
|
|
// Remap Ctrl+A to V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
testState.AddAppSpecificShortcut(testApp1, src, 0x56);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl and A key states should be unchanged, V key states should be true
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x56), true);
|
|
}
|
|
|
|
// Test if the app specific shortcut to key remap takes place when the target app is not in foreground
|
|
TEST_METHOD (AppSpecificShortcutToSingleKey_ShouldNotGetRemapped_WhenAppIsNotInForeground)
|
|
{
|
|
// Remap Ctrl+A to V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
testState.AddAppSpecificShortcut(testApp1, src, 0x56);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp2);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl and A key states should be true, V key state should be false
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), true);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), true);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x56), false);
|
|
}
|
|
|
|
// Test if the the keyboard manager state's activated app is correctly set after an app specific shortcut to key remap takes place
|
|
TEST_METHOD (AppSpecificShortcutToSingleKey_ShouldSetCorrectActivatedApp_WhenRemapOccurs)
|
|
{
|
|
// Remap Ctrl+A to V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
testState.AddAppSpecificShortcut(testApp1, src, 0x56);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Activated app should be testApp1
|
|
Assert::AreEqual(testApp1, testState.GetActivatedApp());
|
|
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = 0x41;
|
|
input[0].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = VK_CONTROL;
|
|
input[1].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
|
|
// Release A then Ctrl
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Activated app should be empty string
|
|
Assert::AreEqual(std::wstring(KeyboardManagerConstants::NoActivatedApp), testState.GetActivatedApp());
|
|
}
|
|
// Test if the key states get cleared if foreground app changes after app-specific shortcut to key shortcut is invoked and then released
|
|
TEST_METHOD (AppSpecificShortcutToSingleKey_ShouldClearKeyStates_WhenForegroundAppChangesAfterShortcutIsPressedOnRelease)
|
|
{
|
|
// Remap Ctrl+A to V
|
|
Shortcut src;
|
|
src.SetKey(VK_CONTROL);
|
|
src.SetKey(0x41);
|
|
testState.AddAppSpecificShortcut(testApp1, src, 0x56);
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp1);
|
|
|
|
const int nInputs = 2;
|
|
INPUT input[nInputs] = {};
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = VK_CONTROL;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = 0x41;
|
|
|
|
// Send Ctrl+A keydown
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Set the testApp as the foreground process
|
|
mockedInputHandler.SetForegroundProcess(testApp2);
|
|
|
|
input[0].type = INPUT_KEYBOARD;
|
|
input[0].ki.wVk = 0x41;
|
|
input[0].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
input[1].type = INPUT_KEYBOARD;
|
|
input[1].ki.wVk = VK_CONTROL;
|
|
input[1].ki.dwFlags = KEYEVENTF_KEYUP;
|
|
|
|
// Release A then Ctrl
|
|
mockedInputHandler.SendVirtualInput(nInputs, input, sizeof(INPUT));
|
|
|
|
// Ctrl, A, V should all be false
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(VK_CONTROL), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x41), false);
|
|
Assert::AreEqual(mockedInputHandler.GetVirtualKeyState(0x56), false);
|
|
}
|
|
};
|
|
}
|