ant-design/.github/PULL_REQUEST_TEMPLATE.md

23 lines
983 B
Markdown
Raw Normal View History

2017-06-13 14:38:34 +08:00
First of all, thank you for your contribution! :-)
2016-02-23 09:43:21 +08:00
2017-06-13 14:38:34 +08:00
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
2016-02-23 09:43:21 +08:00
2017-06-13 14:38:34 +08:00
* [ ] Make sure that you propose PR to right branch: bugfix for `master`, feature for latest active branch `feature-x.x`.
* [ ] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).
* [ ] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.
* [ ] Rebase before creating a PR to keep commit history clear.
* [ ] Add some descriptions and refer relative issues for you PR.
2017-06-13 14:38:34 +08:00
Extra checklist:
2017-06-13 14:40:09 +08:00
**if** *isBugFix* **:**
2017-06-13 14:38:34 +08:00
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
2017-06-13 14:40:09 +08:00
**elif** *isNewFeature* **:**
2017-06-13 14:38:34 +08:00
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update TypeScript definition for the component.
* [ ] Add unit tests for the feature.