mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2025-08-06 16:06:28 +08:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

perf: Radio Group usePrevious instead of useState (#25122)

Browse Source 
* perf: Radio Group usePrevious instead of useState

* fix: only re-run if value changes

* perf: put usePrevious custom Hook in _util/ref.ts

* Generics instead of any

* update
This commit is contained in:
jesse 2020-06-30 10:45:16 +08:00 committed by GitHub
parent 2321cc6df5
commit 09bb61e738
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
components/_util/ref.ts
View File

@ -15,3 +15,13 @@ export function composeRef<T>(...refs: React.Ref<T>[]): React.Ref<T> {
});
};
}
export function usePrevious<T = undefined>(value: T): T | undefined {
const ref = React.useRef<T>();
React.useEffect(() => {
ref.current = value;
}, [value]);
return ref.current;
}

4
components/radio/group.tsx
View File

@ -5,6 +5,7 @@ import { RadioGroupProps, RadioChangeEvent, RadioGroupButtonStyle } from './inte
import { ConfigContext } from '../config-provider';
import SizeContext from '../config-provider/SizeContext';
import { RadioGroupContextProvider } from './context';
import { usePrevious } from '../_util/ref';
const RadioGroup: React.FC<RadioGroupProps> = props => {
const { getPrefixCls, direction } = React.useContext(ConfigContext);
@ -17,10 +18,9 @@ const RadioGroup: React.FC<RadioGroupProps> = props => {
initValue = props.defaultValue;
}
const [value, setValue] = React.useState(initValue);
const [prevPropValue, setPrevPropValue] = React.useState(props.value);
const prevPropValue = usePrevious(props.value);
React.useEffect(() => {
setPrevPropValue(props.value);
if (props.value !== undefined || prevPropValue !== props.value) {
setValue(props.value);
}