mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2024-11-24 02:59:58 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

chore: remove lodash/debounce (#39602)

Browse Source 
* chore: remove lodash/debounce

* fix test case
This commit is contained in:
lijianan 2022-12-16 15:02:32 +08:00 committed by GitHub
parent b82c4bf205
commit 1f5ab2d6a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
components/spin/__tests__/delay.test.tsx
View File

@ -1,12 +1,12 @@
import React from 'react';
import { render } from '@testing-library/react';
import debounce from 'lodash/debounce';
import { debounce } from 'throttle-debounce';
import Spin from '..';
import { waitFakeTimer } from '../../../tests/utils';
jest.mock('lodash/debounce');
jest.mock('throttle-debounce');
(debounce as jest.Mock).mockImplementation((...args: any[]) =>
jest.requireActual('lodash/debounce')(...args),
jest.requireActual('throttle-debounce').debounce(...args),
);
describe('delay spinning', () => {

8
components/spin/index.tsx
View File

@ -1,5 +1,5 @@
import classNames from 'classnames';
import debounce from 'lodash/debounce';
import { debounce } from 'throttle-debounce';
import omit from 'rc-util/lib/omit';
import * as React from 'react';
import type { ConfigConsumerProps } from '../config-provider';
@ -75,7 +75,7 @@ const Spin: React.FC<SpinClassProps> = (props) => {
const {
spinPrefixCls: prefixCls,
spinning: customSpinning = true,
delay,
delay = 0,
className,
size = 'default',
tip,
@ -91,9 +91,9 @@ const Spin: React.FC<SpinClassProps> = (props) => {
);
React.useEffect(() => {
const updateSpinning = debounce<() => void>(() => {
const updateSpinning = debounce(delay, () => {
setSpinning(customSpinning);
}, delay);
});
updateSpinning();
return () => {
updateSpinning?.cancel?.();

6
package.json
View File

@ -119,7 +119,6 @@
"classnames": "^2.2.6",
"copy-to-clipboard": "^3.2.0",
"dayjs": "^1.11.1",
"lodash": "^4.17.21",
"rc-cascader": "~3.8.0",
"rc-checkbox": "~2.3.0",
"rc-collapse": "~3.4.2",
@ -154,7 +153,8 @@
"rc-upload": "~4.3.0",
"rc-util": "^5.25.2",
"scroll-into-view-if-needed": "^3.0.3",
"shallowequal": "^1.1.0"
"shallowequal": "^1.1.0",
"throttle-debounce": "^5.0.0"
},
"devDependencies": {
"@ant-design/tools": "^16.1.0-alpha.2",
@ -189,6 +189,7 @@
"@types/react-sticky": "^6.0.4",
"@types/react-window": "^1.8.2",
"@types/shallowequal": "^1.1.1",
"@types/throttle-debounce": "^5.0.0",
"@types/warning": "^3.0.0",
"@typescript-eslint/eslint-plugin": "^5.40.0",
"@typescript-eslint/parser": "^5.40.0",
@ -238,6 +239,7 @@
"jsonml-to-react-element": "^1.1.11",
"jsonml.js": "^0.1.0",
"lint-staged": "^13.0.3",
"lodash": "^4.17.21",
"lz-string": "^1.4.4",
"mockdate": "^3.0.0",
"open": "^8.0.1",