mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2025-06-07 17:44:35 +08:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

Enhanced InputNumber props with HTMLInputElement attributes. (#10608)

Browse Source 
* Enhanced InputNumber props with HTMLInputElement attributes.

It is possibile to use additional props supported by the inner input
element:

```
const inputEl = <InputNumber autoFocus />
```

Before this commit the type checker did not recognize the `autoFocus`
prop.

Some attributes must be omitted because they conflict with props
defined on `InputNumberProps` interface

* Renamed type

Probably they conflicts with a reserved name?
@see https://travis-ci.org/ant-design/ant-design/jobs/381668406
> components/input-number/index.tsx(9,93): error TS4022: 'extends' clause of exported interface 'InputNumberProps' has or is using private name 'OmitAttributes'.

* Replace InputNumber onKeyDown typing with the typed one.

Extending HTMLInputElement attributes the `onKeyDown` props now have a
better typing.

For example before this commit accessing to the event `key` attribute resulted
in a type error.
@see https://reactjs.org/docs/events.html#keyboard-events

* Exporting type OmitAttrs on InputNumber component.

This is an attempt to solve the ci error:
> components/input-number/index.tsx(9,93): error TS4022: 'extends' clause of exported
> interface 'InputNumberProps' has or is using private name 'OmitAttrs'.

@see https://travis-ci.org/ant-design/ant-design/jobs/381678316
This commit is contained in:
Walter Barbagallo 2018-05-22 04:46:20 +02:00 committed by 偏右
parent bb4bc61556
commit 4077ffb58c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
components/input-number/index.tsx
View File

@ -2,7 +2,12 @@ import * as React from 'react';
import classNames from 'classnames'; import classNames from 'classnames';
import RcInputNumber from 'rc-input-number'; import RcInputNumber from 'rc-input-number';
export interface InputNumberProps { import { Omit } from '../_util/type';
// omitting this attrs because they conflicts with the ones defined in InputNumberProps
export type OmitAttrs = 'defaultValue' | 'onChange' | 'size';
export interface InputNumberProps extends Omit<React.InputHTMLAttributes<HTMLInputElement>, OmitAttrs> {
prefixCls?: string; prefixCls?: string;
min?: number; min?: number;
max?: number; max?: number;
@ -10,7 +15,6 @@ export interface InputNumberProps {
step?: number | string; step?: number | string;
defaultValue?: number; defaultValue?: number;
tabIndex?: number; tabIndex?: number;
onKeyDown?: React.FormEventHandler<any>;
onChange?: (value: number | string | undefined) => void; onChange?: (value: number | string | undefined) => void;
disabled?: boolean; disabled?: boolean;
size?: 'large' | 'small' | 'default'; size?: 'large' | 'small' | 'default';