mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2025-08-06 16:06:28 +08:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

chore: Add warn of value not provided in Cascader (#17511)

Browse Source 
* add warn of `value` not provided

* adjust desc & logic
This commit is contained in:
zombieJ 2019-07-08 10:57:34 +08:00 committed by GitHub
parent 4f288489ec
commit 4a1d68c87f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
components/cascader/__tests__/index.test.js
View File

@ -429,4 +429,13 @@ describe('Cascader', () => {
); );
}); });
}); });
it('should warning if not find `value` in `options`', () => {
const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
mount(<Cascader options={[{ label: 'a', value: 'a', children: [{ label: 'b' }] }]} />);
expect(errorSpy).toHaveBeenCalledWith(
'Warning: [antd: Cascader] Not found `value` in `options`.',
);
errorSpy.mockRestore();
});
}); });

12
components/cascader/index.tsx
View File

@ -204,6 +204,14 @@ function flattenTree(
const defaultDisplayRender = (label: string[]) => label.join(' / '); const defaultDisplayRender = (label: string[]) => label.join(' / ');
function warningValueNotExist(list: CascaderOptionType[], fieldNames: FieldNamesType = {}) {
(list || []).forEach(item => {
const valueFieldName = fieldNames.value || 'value';
warning(valueFieldName in item, 'Cascader', 'Not found `value` in `options`.');
warningValueNotExist(item[fieldNames.children || 'children'], fieldNames);
});
}
class Cascader extends React.Component<CascaderProps, CascaderState> { class Cascader extends React.Component<CascaderProps, CascaderState> {
static defaultProps = { static defaultProps = {
placeholder: 'Please select', placeholder: 'Please select',
@ -229,6 +237,10 @@ class Cascader extends React.Component<CascaderProps, CascaderState> {
newState.flattenOptions = flattenTree(nextProps.options, nextProps); newState.flattenOptions = flattenTree(nextProps.options, nextProps);
} }
if (process.env.NODE_ENV !== 'production' && nextProps.options) {
warningValueNotExist(nextProps.options, getFieldNames(nextProps));
}
return newState; return newState;
} }