mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2024-11-28 13:09:40 +08:00
Code Issues Actions 50 Packages Projects Releases Wiki Activity

adjust Carousel children change goto Logic (#16756)

Browse Source
This commit is contained in:
zombieJ 2019-05-23 23:08:03 +08:00 committed by GitHub
parent 7884ea72f0
commit 5ab2783ff0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
components/carousel/__tests__/index.test.js
View File

@ -106,12 +106,28 @@ describe('Carousel', () => {
warnSpy.mockRestore(); warnSpy.mockRestore();
}); });
it('should active when children change', () => { describe('should active when children change', () => {
const wrapper = mount(<Carousel />); it('should active', () => {
wrapper.setProps({ const wrapper = mount(<Carousel />);
children: <div />, wrapper.setProps({
children: <div />,
});
wrapper.update();
expect(wrapper.find('.slick-active').length).toBeTruthy();
});
it('should keep initialSlide', () => {
const wrapper = mount(<Carousel initialSlide={1} />);
wrapper.setProps({
children: [<div key="1" />, <div key="2" />, <div key="3" />],
});
wrapper.update();
expect(
wrapper
.find('.slick-dots li')
.at(1)
.hasClass('slick-active'),
).toBeTruthy();
}); });
wrapper.update();
expect(wrapper.find('.slick-active').length).toBeTruthy();
}); });
}); });

2
components/carousel/index.tsx
View File

@ -73,7 +73,7 @@ export default class Carousel extends React.Component<CarouselProps, {}> {
componentDidUpdate(prevProps: CarouselProps) { componentDidUpdate(prevProps: CarouselProps) {
if (React.Children.count(this.props.children) !== React.Children.count(prevProps.children)) { if (React.Children.count(this.props.children) !== React.Children.count(prevProps.children)) {
this.goTo(0, false); this.goTo(this.props.initialSlide || 0, false);
} }
} }