mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2025-01-24 02:20:01 +08:00
Code Issues Actions 29 Packages Projects Releases Wiki Activity

fix: notification should hide close icon when closeIcon={null} (#42791)

Browse Source
This commit is contained in:
afc163 2023-06-25 12:11:40 +08:00 committed by GitHub
parent 90ad14ef2d
commit 93a6ee1b40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
components/notification/__tests__/index.test.tsx
View File

@ -272,6 +272,30 @@ describe('notification', () => {
expect(document.querySelectorAll('.test-customize-icon').length).toBe(1);
});
it('support closeIcon to be null', () => {
act(() => {
notification.open({
message: 'Notification Title',
duration: 0,
closeIcon: null,
});
});
expect(document.querySelectorAll('.test-customize-icon').length).toBe(0);
});
it('support closeIcon to be false', () => {
act(() => {
notification.open({
message: 'Notification Title',
duration: 0,
closeIcon: false,
});
});
expect(document.querySelectorAll('.test-customize-icon').length).toBe(0);
});
it('support config closeIcon', () => {
notification.config({
closeIcon: <span className="test-customize-icon" />,

7
components/notification/index.tsx
View File

@ -252,10 +252,13 @@ function getRCNoticeProps(args: ArgsProps, prefixCls: string, iconPrefixCls?: st
});
}
const closeIconToRender = (
const closeIconToRender =
typeof closeIcon === 'undefined' ? (
<span className={`${prefixCls}-close-x`}>
{closeIcon || <CloseOutlined className={`${prefixCls}-close-icon`} />}
<CloseOutlined className={`${prefixCls}-close-icon`} />
</span>
) : (
closeIcon
);
const autoMarginTag =