mirror of
https://github.com/ant-design/ant-design.git
synced 2024-11-24 02:59:58 +08:00
docs: spelling and grammar fixes (#44807)
* refactor: convertLegacyProps function moved to buttonHelpers * docs: spelling and grammar fixes
This commit is contained in:
parent
ceae7de9db
commit
b2b961e058
@ -52,7 +52,7 @@ Back to the topic, what should we do if we find snapshot test failed after chang
|
||||
npm run test -u
|
||||
```
|
||||
|
||||
2. However, we should find what's going wrong if the diff of snapshot is not only cause by your modification this time. For example, you only modified the text, but found that classnames in snapshots have changed, which obviously does not meet expectations.
|
||||
2. However, we should find what's going wrong if the diff of snapshot is not only caused by your modification this time. For example, you only modified the text, but found that classnames in snapshots have changed, which obviously does not meet expectations.
|
||||
|
||||
The common causes are as follows:
|
||||
|
||||
|
@ -25,7 +25,7 @@ In the v5 alpha version, in order to cover the SSR style rendering, we refer to
|
||||
|
||||
This implementation is simple and effective, the only downside is style pollution for `:nth` selections. But considering that antd components rarely use this selector, the side effects can be ignored.
|
||||
|
||||
It worked well at the beginning, and the official website of antd directly supports the SSR style without modification and meet the SEO needs. But as our components gradually migrated to the CSS-in-JS version, we found that the site's buddle size became very large and slowly became unusable. After looking at the HTML, we found that the default inline method is not good, it will cause the style to be doubled inline, for example, if there are 3 Buttons in a page, then it will repeat the inline 3 times:
|
||||
It worked well at the beginning, and the official website of antd directly supports the SSR style without modification and meet the SEO needs. But as our components gradually migrated to the CSS-in-JS version, we found that the site's bundle size became very large and slowly became unusable. After looking at the HTML, we found that the default inline method is not good, it will cause the style to be doubled inline, for example, if there are 3 Buttons in a page, then it will repeat the inline 3 times:
|
||||
|
||||
```html
|
||||
<div>
|
||||
|
@ -40,7 +40,7 @@ As a feature on the GitHub platform, issues serve as a centralized information h
|
||||
|
||||
### Ensuring the Quality of Issues
|
||||
|
||||
Ensuring issues contain sufficient information helps us to analyze and prioritize. We provide an [issue assistant](http://new-issue.ant.design) to standardize the process of creating issues. Additionally, we use GitHub Actions to check the issues created to auto close if it not pass the assistant's checks. Which will be labeled as [Invalid](https://github.com/ant-design/ant-design/issues?q=label%3AInvalid), aand leaving comment to remind the creator how to ask a question proporly.
|
||||
Ensuring issues contain sufficient information helps us to analyze and prioritize. We provide an [issue assistant](http://new-issue.ant.design) to standardize the process of creating issues. Additionally, we use GitHub Actions to check the issues created to auto close if it not pass the assistant's checks. Which will be labeled as [Invalid](https://github.com/ant-design/ant-design/issues?q=label%3AInvalid), and leaving comment to remind the creator how to ask a question properly.
|
||||
|
||||
![invalid-issue-preview](https://user-images.githubusercontent.com/32004925/231660945-509cf97c-43eb-4a1c-acd2-81eeedfe4a73.png)
|
||||
|
||||
|
@ -30,7 +30,7 @@ When we find relevant updates, we will install the previous version for comparis
|
||||
|
||||
### Schedule build
|
||||
|
||||
As you see, the above troubleshooting method has a certain lag. We hope to reduce additional human labor by building regularly, and at the same time allow us to find problems faster. So we reused the [create-next-app-antd](https://github.com/ant-design/ant-design-examples/tree/main/examples/with-nextjs-inline-style) project as the base (in this way, if something goes wrong with the template project, we can also be detected in advance). Created a `mock-project-build.yml` CI that executes every half hour, which periodically pulls [create-next-app-antd](https://github.com/ant-design/create-next-app-antd) repo to build:
|
||||
As you can see, the above troubleshooting method has a certain lag. We hope to reduce additional human labor by building regularly, and at the same time allow us to find problems faster. So we reused the [create-next-app-antd](https://github.com/ant-design/ant-design-examples/tree/main/examples/with-nextjs-inline-style) project as the base (in this way, if something goes wrong with the template project, we can also be detected in advance). Created a `mock-project-build.yml` CI that executes every half hour, which periodically pulls [create-next-app-antd](https://github.com/ant-design/create-next-app-antd) repo to build:
|
||||
|
||||
```yml
|
||||
on:
|
||||
|
@ -8,7 +8,7 @@ yuque_url: https://www.yuque.com/ant-design/ant-design/gkkyx81eihftzzq7
|
||||
|
||||
> `message.success` is working well, why do you warn me to use hooks? antd is getting worse and worse, goodbye!
|
||||
|
||||
We've heard some complain about hooks replacement of static methods. We know it's painful, but after years of consideration, we still decide to do a cut in v5 (yes, this discussion is even older than hooks, but there was no simple way to implement it before hooks, so we just put it aside).
|
||||
We've heard some complaints about hooks replacement of static methods. We know it's painful, but after years of consideration, we still decide to do a cut in v5 (yes, this discussion is even older than hooks, but there was no simple way to implement it before hooks, so we just put it aside).
|
||||
|
||||
## Static methods
|
||||
|
||||
@ -16,7 +16,7 @@ For the early JS, there already exists a simple and easy-to-use API `alert`. You
|
||||
|
||||
<img width="300" alt="Fetch Failed" src="https://user-images.githubusercontent.com/5378891/234574678-44b12d00-9318-4ff9-b234-08129c82fc78.png" />
|
||||
|
||||
But from the perspective of data flow, this actually couples UI and data layer. It's just look like it doesn't directly depend on the UI context when it's called, so it looks harmless. And for the perspective of testing, this kind of coupling also makes the test complicated.
|
||||
But from the perspective of data flow, this actually couples UI and data layer. It just looks like it doesn't directly depend on the UI context when it's called, so it looks harmless. And for the perspective of testing, this kind of coupling also makes the test complicated.
|
||||
|
||||
### Pain of context lost
|
||||
|
||||
|
@ -260,7 +260,7 @@ If you encounter the above error, please check the current project `tsconfig.jso
|
||||
}
|
||||
```
|
||||
|
||||
The above problem occurs if `strictNullChecks` is set to `true`, If you can determine the project don't need this configuration (see [strictNullChecks](https://www.typescriptlang.org/zh/tsconfig#strictNullChecks) to judge whether need the configuration). You can try changing to `false` to turn off the control strict check. However, if you do need to enable this feature, you can avoid this situation by using other types instead of `null` when designing types
|
||||
The above problem occurs if `strictNullChecks` is set to `true`, If you can determine the project don't need this configuration (see [strictNullChecks](https://www.typescriptlang.org/zh/tsconfig#strictNullChecks) to judge whether need the configuration). You can try changing to `false` to turn off the control strict check. However, if you do need to enable this feature, you can avoid this situation by using other types instead of `null` when defining types
|
||||
|
||||
## The antd component reported an error when using the App Router of Next.js
|
||||
|
||||
|
@ -77,7 +77,7 @@ The following languages are currently supported:
|
||||
| Malay (Malaysia) | ms_MY |
|
||||
| Burmese | my_MM |
|
||||
| Norwegian | nb_NO |
|
||||
| Nepal | ne_NP |
|
||||
| Nepali | ne_NP |
|
||||
| Dutch (Belgium) | nl_BE |
|
||||
| Dutch | nl_NL |
|
||||
| Polish | pl_PL |
|
||||
|
Loading…
Reference in New Issue
Block a user