mirror/ant-design
1
0
Fork 0
mirror of https://github.com/ant-design/ant-design.git synced 2024-11-28 13:09:40 +08:00
Code Issues Actions 50 Packages Projects Releases Wiki Activity

Revert "fix: make upload action buttons focusable (#24604)" (#24608)

Browse Source 
This reverts commit 8e20fe6779.
This commit is contained in:
偏右 2020-05-31 11:50:26 +08:00 committed by GitHub
parent 882cec62d6
commit b95207d58e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 48 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
components/config-provider/__tests__/__snapshots__/components.test.js.snap
View File

@ -37634,7 +37634,7 @@ exports[`ConfigProvider components Upload configProvider 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -37737,7 +37737,7 @@ exports[`ConfigProvider components Upload configProvider componentSize large 1`]
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -37840,7 +37840,7 @@ exports[`ConfigProvider components Upload configProvider componentSize middle 1`
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -37943,7 +37943,7 @@ exports[`ConfigProvider components Upload configProvider virtual and dropdownMat
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -38046,7 +38046,7 @@ exports[`ConfigProvider components Upload normal 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -38149,7 +38149,7 @@ exports[`ConfigProvider components Upload prefixCls 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg

9
components/upload/UploadList.tsx
View File

@ -112,7 +112,7 @@ export default class UploadList extends React.Component<UploadListProps, any> {
});
}
return (
<span title={title} onClick={callback} role="button" tabIndex={0}>
<span title={title} onClick={callback}>
{customIcon}
</span>
);
@ -201,11 +201,7 @@ export default class UploadList extends React.Component<UploadListProps, any> {
() => this.handleClose(file),
locale.removeFile,
)) || (
<DeleteOutlined
title={locale.removeFile}
onClick={() => this.handleClose(file)}
tabIndex={0}
/>
<DeleteOutlined title={locale.removeFile} onClick={() => this.handleClose(file)} />
)
: null;
@ -220,7 +216,6 @@ export default class UploadList extends React.Component<UploadListProps, any> {
<DownloadOutlined
title={locale.downloadFile}
onClick={() => this.handleDownload(file)}
tabIndex={0}
/>
)
: null;

42
components/upload/__tests__/__snapshots__/demo.test.js.snap
View File

@ -181,7 +181,7 @@ exports[`renders ./components/upload/demo/crop-image.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -380,7 +380,7 @@ exports[`renders ./components/upload/demo/defaultFileList.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -459,7 +459,7 @@ exports[`renders ./components/upload/demo/defaultFileList.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -537,7 +537,7 @@ exports[`renders ./components/upload/demo/defaultFileList.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -792,7 +792,7 @@ exports[`renders ./components/upload/demo/file-type.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -906,7 +906,7 @@ exports[`renders ./components/upload/demo/file-type.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1021,7 +1021,7 @@ exports[`renders ./components/upload/demo/file-type.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1135,7 +1135,7 @@ exports[`renders ./components/upload/demo/file-type.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1241,7 +1241,7 @@ exports[`renders ./components/upload/demo/file-type.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1418,7 +1418,7 @@ exports[`renders ./components/upload/demo/fileList.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1525,7 +1525,7 @@ exports[`renders ./components/upload/demo/picture-card.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1615,7 +1615,7 @@ exports[`renders ./components/upload/demo/picture-card.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1705,7 +1705,7 @@ exports[`renders ./components/upload/demo/picture-card.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1795,7 +1795,7 @@ exports[`renders ./components/upload/demo/picture-card.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1910,7 +1910,7 @@ exports[`renders ./components/upload/demo/picture-card.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -2075,7 +2075,7 @@ exports[`renders ./components/upload/demo/picture-style.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -2167,7 +2167,7 @@ exports[`renders ./components/upload/demo/picture-style.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -2286,7 +2286,7 @@ exports[`renders ./components/upload/demo/picture-style.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -2378,7 +2378,7 @@ exports[`renders ./components/upload/demo/picture-style.md correctly 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -2618,8 +2618,6 @@ exports[`renders ./components/upload/demo/upload-custom-action-icon.md correctly
title="Download file"
>
<span
role="button"
tabindex="0"
title="Download file"
>
download
@ -2708,8 +2706,6 @@ exports[`renders ./components/upload/demo/upload-custom-action-icon.md correctly
title="Download file"
>
<span
role="button"
tabindex="0"
title="Download file"
>
download

26
components/upload/__tests__/__snapshots__/uploadlist.test.js.snap
View File

@ -77,7 +77,7 @@ exports[`Upload List handle error 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -183,7 +183,7 @@ exports[`Upload List should be uploading when upload a file 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -310,7 +310,7 @@ exports[`Upload List should be uploading when upload a file 2`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -448,7 +448,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -515,7 +515,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -602,7 +602,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -689,7 +689,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -756,7 +756,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -823,7 +823,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -890,7 +890,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -957,7 +957,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1024,7 +1024,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg
@ -1091,7 +1091,7 @@ exports[`Upload List should non-image format file preview 1`] = `
aria-label="delete"
class="anticon anticon-delete"
role="img"
tabindex="0"
tabindex="-1"
title="Remove file"
>
<svg

21
components/upload/style/index.less
View File

@ -176,21 +176,16 @@
&-card-actions {
position: absolute;
right: 0;
opacity: 0;
&.picture {
top: 25px;
line-height: 1;
}
&.picture .@{iconfont-css-prefix} {
opacity: 1;
}
.@{iconfont-css-prefix} {
margin-right: 6px;
padding-right: 6px;
color: @upload-actions-color;
opacity: 0;
}
.@{iconfont-css-prefix}:focus {
opacity: 1;
}
}
@ -228,10 +223,8 @@
opacity: 0;
transition: all 0.3s;
&:hover,
&:focus {
&:hover {
color: @text-color;
opacity: 1;
}
}
@ -243,7 +236,7 @@
opacity: 1;
}
&:hover &-card-actions .@{iconfont-css-prefix} {
&:hover &-card-actions {
opacity: 1;
}
@ -253,8 +246,10 @@
color: @error-color;
}
&-error &-card-actions .@{iconfont-css-prefix} {
color: @error-color;
&-error &-card-actions {
.@{iconfont-css-prefix} {
color: @error-color;
}
opacity: 1;
}