2020-06-06 04:01:53 +08:00
|
|
|
// Copyright 2020 The Gitea Authors. All rights reserved.
|
2022-11-28 02:20:29 +08:00
|
|
|
// SPDX-License-Identifier: MIT
|
2020-06-06 04:01:53 +08:00
|
|
|
|
2022-09-03 03:18:23 +08:00
|
|
|
package integration
|
2020-06-06 04:01:53 +08:00
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"net/http"
|
|
|
|
"testing"
|
|
|
|
|
2022-08-25 10:31:57 +08:00
|
|
|
activities_model "code.gitea.io/gitea/models/activities"
|
2023-01-18 05:46:03 +08:00
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
2021-12-10 09:27:50 +08:00
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
2021-11-16 16:53:21 +08:00
|
|
|
"code.gitea.io/gitea/models/unittest"
|
2021-11-24 17:49:20 +08:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2020-06-06 04:01:53 +08:00
|
|
|
api "code.gitea.io/gitea/modules/structs"
|
2022-09-03 03:18:23 +08:00
|
|
|
"code.gitea.io/gitea/tests"
|
2020-06-06 04:01:53 +08:00
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
2022-01-21 01:46:10 +08:00
|
|
|
const (
|
|
|
|
privateActivityTestAdmin = "user1"
|
|
|
|
privateActivityTestUser = "user2"
|
|
|
|
)
|
2020-06-06 04:01:53 +08:00
|
|
|
|
|
|
|
// user3 is an organization so it is not usable here
|
|
|
|
const privateActivityTestOtherUser = "user4"
|
|
|
|
|
|
|
|
// activity helpers
|
|
|
|
|
|
|
|
func testPrivateActivityDoSomethingForActionEntries(t *testing.T) {
|
2022-08-16 10:22:25 +08:00
|
|
|
repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})
|
2020-06-06 04:01:53 +08:00
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-05 02:57:16 +08:00
|
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)
|
2020-06-06 04:01:53 +08:00
|
|
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues?state=all&token=%s", owner.Name, repoBefore.Name, token)
|
|
|
|
req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateIssueOption{
|
|
|
|
Body: "test",
|
|
|
|
Title: "test",
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusCreated)
|
|
|
|
}
|
|
|
|
|
|
|
|
// private activity helpers
|
|
|
|
|
|
|
|
func testPrivateActivityHelperEnablePrivateActivity(t *testing.T) {
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
req := NewRequestWithValues(t, "POST", "/user/settings", map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, "/user/settings"),
|
|
|
|
"name": privateActivityTestUser,
|
|
|
|
"email": privateActivityTestUser + "@example.com",
|
2020-12-04 14:20:30 +08:00
|
|
|
"language": "en-US",
|
2020-06-06 04:01:53 +08:00
|
|
|
"keep_activity_private": "1",
|
|
|
|
})
|
2022-03-23 12:54:07 +08:00
|
|
|
session.MakeRequest(t, req, http.StatusSeeOther)
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleActivitiesInHTMLDoc(htmlDoc *HTMLDoc) bool {
|
|
|
|
return htmlDoc.doc.Find(".feeds").Find(".news").Length() > 0
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleActivitiesFromSession(t *testing.T, session *TestSession) bool {
|
|
|
|
req := NewRequestf(t, "GET", "/%s?tab=activity", privateActivityTestUser)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
return testPrivateActivityHelperHasVisibleActivitiesInHTMLDoc(htmlDoc)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleActivitiesFromPublic(t *testing.T) bool {
|
|
|
|
req := NewRequestf(t, "GET", "/%s?tab=activity", privateActivityTestUser)
|
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
return testPrivateActivityHelperHasVisibleActivitiesInHTMLDoc(htmlDoc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// heatmap UI helpers
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleHeatmapInHTMLDoc(htmlDoc *HTMLDoc) bool {
|
|
|
|
return htmlDoc.doc.Find("#user-heatmap").Length() > 0
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t *testing.T, session *TestSession) bool {
|
|
|
|
req := NewRequestf(t, "GET", "/%s?tab=activity", privateActivityTestUser)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
return testPrivateActivityHelperHasVisibleHeatmapInHTMLDoc(htmlDoc)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleDashboardHeatmapFromSession(t *testing.T, session *TestSession) bool {
|
|
|
|
req := NewRequest(t, "GET", "/")
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
return testPrivateActivityHelperHasVisibleHeatmapInHTMLDoc(htmlDoc)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasVisibleHeatmapFromPublic(t *testing.T) bool {
|
|
|
|
req := NewRequestf(t, "GET", "/%s?tab=activity", privateActivityTestUser)
|
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
return testPrivateActivityHelperHasVisibleHeatmapInHTMLDoc(htmlDoc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// heatmap API helpers
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasHeatmapContentFromPublic(t *testing.T) bool {
|
|
|
|
req := NewRequestf(t, "GET", "/api/v1/users/%s/heatmap", privateActivityTestUser)
|
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
2022-08-25 10:31:57 +08:00
|
|
|
var items []*activities_model.UserHeatmapData
|
2020-06-06 04:01:53 +08:00
|
|
|
DecodeJSON(t, resp, &items)
|
|
|
|
|
|
|
|
return len(items) != 0
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPrivateActivityHelperHasHeatmapContentFromSession(t *testing.T, session *TestSession) bool {
|
Redesign Scoped Access Tokens (#24767)
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-05 02:57:16 +08:00
|
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
2020-06-06 04:01:53 +08:00
|
|
|
|
|
|
|
req := NewRequestf(t, "GET", "/api/v1/users/%s/heatmap?token=%s", privateActivityTestUser, token)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
2022-08-25 10:31:57 +08:00
|
|
|
var items []*activities_model.UserHeatmapData
|
2020-06-06 04:01:53 +08:00
|
|
|
DecodeJSON(t, resp, &items)
|
|
|
|
|
|
|
|
return len(items) != 0
|
|
|
|
}
|
|
|
|
|
|
|
|
// check activity visibility if the visibility is enabled
|
|
|
|
|
|
|
|
func TestPrivateActivityNoVisibleForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromPublic(t)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoVisibleForUserItself(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoVisibleForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoVisibleForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
// check activity visibility if the visibility is disabled
|
|
|
|
|
|
|
|
func TestPrivateActivityYesInvisibleForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromPublic(t)
|
|
|
|
|
|
|
|
assert.False(t, visible, "user should have no visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesVisibleForUserItself(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesInvisibleForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.False(t, visible, "user should have no visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesVisibleForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleActivitiesFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible activities")
|
|
|
|
}
|
|
|
|
|
|
|
|
// check heatmap visibility if the visibility is enabled
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapVisibleForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
visible := testPrivateActivityHelperHasVisibleHeatmapFromPublic(t)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapVisibleForUserItselfAtProfile(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapVisibleForUserItselfAtDashboard(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleDashboardHeatmapFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapVisibleForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapVisibleForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
|
|
|
}
|
|
|
|
|
|
|
|
// check heatmap visibility if the visibility is disabled
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapInvisibleForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
visible := testPrivateActivityHelperHasVisibleHeatmapFromPublic(t)
|
|
|
|
|
|
|
|
assert.False(t, visible, "user should have no visible heatmap")
|
|
|
|
}
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
func TestPrivateActivityYesHeatmapVisibleForUserItselfAtProfile(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
func TestPrivateActivityYesHeatmapVisibleForUserItselfAtDashboard(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleDashboardHeatmapFromSession(t, session)
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapInvisibleForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
|
|
|
assert.False(t, visible, "user should have no visible heatmap")
|
|
|
|
}
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
func TestPrivateActivityYesHeatmapVisibleForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
visible := testPrivateActivityHelperHasVisibleProfileHeatmapFromSession(t, session)
|
|
|
|
|
2021-03-05 06:59:13 +08:00
|
|
|
assert.True(t, visible, "user should have visible heatmap")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// check heatmap api provides content if the visibility is enabled
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapHasContentForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromPublic(t)
|
|
|
|
|
|
|
|
assert.True(t, hasContent, "user should have heatmap content")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapHasContentForUserItself(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, hasContent, "user should have heatmap content")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapHasContentForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, hasContent, "user should have heatmap content")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityNoHeatmapHasContentForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
|
|
|
assert.True(t, hasContent, "user should have heatmap content")
|
|
|
|
}
|
|
|
|
|
|
|
|
// check heatmap api provides no content if the visibility is disabled
|
|
|
|
// this should be equal to the hidden heatmap at the UI
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapHasNoContentForPublic(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromPublic(t)
|
|
|
|
|
|
|
|
assert.False(t, hasContent, "user should have no heatmap content")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapHasNoContentForUserItself(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestUser)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
2020-12-22 10:53:37 +08:00
|
|
|
assert.True(t, hasContent, "user should see their own heatmap content")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapHasNoContentForOtherUser(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestOtherUser)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
2020-12-22 10:53:37 +08:00
|
|
|
assert.False(t, hasContent, "other user should not see heatmap content")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrivateActivityYesHeatmapHasNoContentForAdmin(t *testing.T) {
|
2022-09-03 03:18:23 +08:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2020-06-06 04:01:53 +08:00
|
|
|
testPrivateActivityDoSomethingForActionEntries(t)
|
|
|
|
testPrivateActivityHelperEnablePrivateActivity(t)
|
|
|
|
|
|
|
|
session := loginUser(t, privateActivityTestAdmin)
|
|
|
|
hasContent := testPrivateActivityHelperHasHeatmapContentFromSession(t, session)
|
|
|
|
|
2020-12-22 10:53:37 +08:00
|
|
|
assert.True(t, hasContent, "heatmap should show content for admin")
|
2020-06-06 04:01:53 +08:00
|
|
|
}
|