2021-01-21 22:51:52 +08:00
|
|
|
<form class="ui comment form stackable grid" id="new-issue" action="{{.Link}}" method="post">
|
2015-12-08 06:30:52 +08:00
|
|
|
{{.CsrfTokenHtml}}
|
|
|
|
|
{{if .Flash}}
|
|
|
|
|
<div class="sixteen wide column">
|
|
|
|
|
{{template "base/alert" .}}
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
<div class="twelve wide column">
|
2015-08-09 15:23:02 +08:00
|
|
|
<div class="ui comments">
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="comment">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{template "shared/user/avatarlink" Dict "Context" $.Context "user" .SignedUser}}
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="ui segment content">
|
|
|
|
|
<div class="field">
|
2022-06-28 04:58:46 +08:00
|
|
|
<input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" tabindex="3" autofocus required maxlength="255" autocomplete="off">
|
2018-08-14 03:04:39 +08:00
|
|
|
{{if .PageIsComparePull}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="title_wip_desc" data-wip-prefixes="{{Json .PullRequestWorkInProgressPrefixes}}">{{.locale.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</div>
|
2018-08-14 03:04:39 +08:00
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
2015-08-12 18:44:09 +08:00
|
|
|
{{template "repo/issue/comment_tab" .}}
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="text right">
|
2022-05-07 20:24:02 +08:00
|
|
|
<button class="ui green button loading-button" tabindex="6">
|
2015-08-31 15:24:28 +08:00
|
|
|
{{if .PageIsComparePull}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.pulls.create"}}
|
2015-08-31 15:24:28 +08:00
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.create"}}
|
2015-08-31 15:24:28 +08:00
|
|
|
{{end}}
|
2015-08-10 01:04:23 +08:00
|
|
|
</button>
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-10 01:04:23 +08:00
|
|
|
|
2015-08-09 15:23:02 +08:00
|
|
|
<div class="four wide column">
|
|
|
|
|
<div class="ui segment metas">
|
2017-08-24 20:30:27 +08:00
|
|
|
{{template "repo/issue/branch_selector_field" .}}
|
|
|
|
|
|
2015-08-10 18:57:57 +08:00
|
|
|
<input id="label_ids" name="label_ids" type="hidden" value="{{.label_ids}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-label dropdown">
|
2015-08-09 15:23:02 +08:00
|
|
|
<span class="text">
|
2022-06-28 04:58:46 +08:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.labels"}}</strong>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
2020-09-12 04:19:00 +08:00
|
|
|
{{svg "octicon-gear"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2015-08-09 15:23:02 +08:00
|
|
|
</span>
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="filter menu" data-id="#label_ids">
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_labels_title"}}</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if or .Labels .OrgLabels}}
|
|
|
|
|
<div class="ui icon search input">
|
2023-02-14 01:59:59 +08:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-28 04:58:46 +08:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_labels"}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
</div>
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_labels"}}</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if or .Labels .OrgLabels}}
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 03:17:39 +08:00
|
|
|
{{$previousExclusiveScope := "_no_scope"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{range .Labels}}
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 03:17:39 +08:00
|
|
|
{{$exclusiveScope := .ExclusiveScope}}
|
|
|
|
|
{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{$previousExclusiveScope = $exclusiveScope}}
|
2023-03-07 00:32:40 +08:00
|
|
|
<a class="{{if .IsChecked}}checked{{end}} item" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}" data-scope="{{$exclusiveScope}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{if $exclusiveScope}}{{svg "octicon-dot-fill"}}{{else}}{{svg "octicon-check"}}{{end}}</span> {{RenderLabel $.Context .}}
|
|
|
|
|
{{if .Description}}<br><small class="desc">{{.Description | RenderEmoji $.Context}}</small>{{end}}</a>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2020-06-10 05:31:15 +08:00
|
|
|
|
2020-04-04 13:39:48 +08:00
|
|
|
<div class="ui divider"></div>
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 03:17:39 +08:00
|
|
|
{{$previousExclusiveScope := "_no_scope"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{range .OrgLabels}}
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-19 03:17:39 +08:00
|
|
|
{{$exclusiveScope := .ExclusiveScope}}
|
|
|
|
|
{{if and (ne $previousExclusiveScope "_no_scope") (ne $previousExclusiveScope $exclusiveScope)}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{$previousExclusiveScope = $exclusiveScope}}
|
2023-03-07 00:32:40 +08:00
|
|
|
<a class="{{if .IsChecked}}checked{{end}} item" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}" data-scope="{{$exclusiveScope}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{if $exclusiveScope}}{{svg "octicon-dot-fill"}}{{else}}{{svg "octicon-check"}}{{end}}</span> {{RenderLabel $.Context .}}
|
|
|
|
|
{{if .Description}}<br><small class="desc">{{.Description | RenderEmoji $.Context}}</small>{{end}}</a>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
|
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">{{.locale.Tr "repo.issues.new.no_items"}}</div>
|
Add Organization Wide Labels (#10814)
* Add organization wide labels
Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).
This makes it possible for small organizations with many repos to use
labels effectively.
Fixes #7406
* Add migration
* remove comments
* fix tests
* Update options/locale/locale_en-US.ini
Removed unused translation string
* show org labels in issue search label filter
* Use more clear var name
* rename migration after merge from master
* comment typo
* update migration again after rebase with master
* check for orgID <=0 per guillep2k review
* fmt
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* remove unused code
* Make sure RepoID is 0 when searching orgID per code review
* more changes/code review requests
* More descriptive translation var per code review
* func description/delete comment when issue label deleted instead of hiding it
* remove comment
* only use issues in that repo when calculating number of open issues for org label on repo label page
* Add integration test for IssuesSearch API with labels
* remove unused function
* Update models/issue_label.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Use subquery in GetLabelIDsInReposByNames
* Fix tests to use correct orgID
* fix more tests
* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well
* update comment for clarity
* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition
* Don't sort repos by date in IssuesSearch API
After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45
Returns different results for MySQL than other engines. However, the similar query:
SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30
Returns the same results.
This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.
* linter is back!
* code review
* remove now unused option
* Fix newline at end of files
* more unused code
* update to master
* check for matching ids before query
* Update models/issue_label.go
Co-Authored-By: 6543 <6543@obermui.de>
* Update models/issue_label.go
* update comments
* Update routers/org/setting.go
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 12:14:46 +08:00
|
|
|
{{end}}
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2020-11-17 13:02:41 +08:00
|
|
|
{{template "repo/issue/labels/labels_sidebar" dict "root" $ "ctx" .}}
|
2015-08-10 18:57:57 +08:00
|
|
|
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
|
|
<input id="milestone_id" name="milestone_id" type="hidden" value="{{.milestone_id}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-milestone dropdown">
|
2015-08-09 15:23:02 +08:00
|
|
|
<span class="text">
|
2022-06-28 04:58:46 +08:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.milestone"}}</strong>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
2020-09-12 04:19:00 +08:00
|
|
|
{{svg "octicon-gear"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2015-08-09 15:23:02 +08:00
|
|
|
</span>
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="menu">
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_milestone_title"}}</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if or .OpenMilestones .ClosedMilestones}}
|
|
|
|
|
<div class="ui icon search input">
|
2023-02-14 01:59:59 +08:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-28 04:58:46 +08:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_milestones"}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_milestone"}}</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if and (not .OpenMilestones) (not .ClosedMilestones)}}
|
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.no_items"}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{else}}
|
|
|
|
|
{{if .OpenMilestones}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.open_milestone"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
</div>
|
|
|
|
|
{{range .OpenMilestones}}
|
2020-11-29 14:22:04 +08:00
|
|
|
<a class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}">
|
2023-02-14 01:59:59 +08:00
|
|
|
{{svg "octicon-milestone" 16 "gt-mr-2"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Name}}
|
|
|
|
|
</a>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if .ClosedMilestones}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.closed_milestone"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
</div>
|
|
|
|
|
{{range .ClosedMilestones}}
|
2020-11-29 14:22:04 +08:00
|
|
|
<a class="item" data-id="{{.ID}}" data-href="{{$.RepoLink}}/issues?milestone={{.ID}}">
|
2023-02-14 01:59:59 +08:00
|
|
|
{{svg "octicon-milestone" 16 "gt-mr-2"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Name}}
|
|
|
|
|
</a>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-10 18:57:57 +08:00
|
|
|
<div class="ui select-milestone list">
|
2023-02-19 12:06:14 +08:00
|
|
|
<span class="no-select item {{if .Milestone}}gt-hidden{{end}}">{{.locale.Tr "repo.issues.new.no_milestone"}}</span>
|
2015-08-10 18:57:57 +08:00
|
|
|
<div class="selected">
|
|
|
|
|
{{if .Milestone}}
|
2020-11-29 14:22:04 +08:00
|
|
|
<a class="item muted sidebar-item-link" href="{{.RepoLink}}/issues?milestone={{.Milestone.ID}}">
|
2023-02-14 01:59:59 +08:00
|
|
|
{{svg "octicon-milestone" 18 "gt-mr-3"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Milestone.Name}}
|
|
|
|
|
</a>
|
2015-08-10 18:57:57 +08:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
2015-08-10 18:57:57 +08:00
|
|
|
|
2020-08-17 11:07:38 +08:00
|
|
|
{{if .IsProjectsEnabled}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
|
|
|
|
|
<input id="project_id" name="project_id" type="hidden" value="{{.project_id}}">
|
|
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-project dropdown">
|
2020-11-29 14:22:04 +08:00
|
|
|
<span class="text">
|
2022-06-28 04:58:46 +08:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.projects"}}</strong>
|
2020-11-29 14:22:04 +08:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
|
|
|
|
{{svg "octicon-gear"}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_project_title"}}</div>
|
2020-11-29 14:22:04 +08:00
|
|
|
{{if or .OpenProjects .ClosedProjects}}
|
|
|
|
|
<div class="ui icon search input">
|
2023-02-14 01:59:59 +08:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-28 04:58:46 +08:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_projects"}}">
|
2020-11-29 14:22:04 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_projects"}}</div>
|
2020-11-29 14:22:04 +08:00
|
|
|
{{if and (not .OpenProjects) (not .ClosedProjects)}}
|
|
|
|
|
<div class="header" style="text-transform: none;font-size:14px;">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.no_items"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
</div>
|
|
|
|
|
{{else}}
|
|
|
|
|
{{if .OpenProjects}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.open_projects"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
</div>
|
|
|
|
|
{{range .OpenProjects}}
|
2023-03-07 03:48:04 +08:00
|
|
|
<a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link}}">
|
|
|
|
|
{{if .IsOrganizationProject}}{{svg "octicon-project-symlink" 18 "gt-mr-3"}}{{else}}{{svg "octicon-project" 18 "gt-mr-3"}}{{end}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Title}}
|
|
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{if .ClosedProjects}}
|
|
|
|
|
<div class="divider"></div>
|
|
|
|
|
<div class="header">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.closed_projects"}}
|
2020-11-29 14:22:04 +08:00
|
|
|
</div>
|
|
|
|
|
{{range .ClosedProjects}}
|
2023-03-07 03:48:04 +08:00
|
|
|
<a class="item muted sidebar-item-link" data-id="{{.ID}}" data-href="{{.Link}}">
|
|
|
|
|
{{if .IsOrganizationProject}}{{svg "octicon-project-symlink" 18 "gt-mr-3"}}{{else}}{{svg "octicon-project" 18 "gt-mr-3"}}{{end}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Title}}
|
|
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2020-08-17 11:07:38 +08:00
|
|
|
</div>
|
|
|
|
|
<div class="ui select-project list">
|
2023-02-19 12:06:14 +08:00
|
|
|
<span class="no-select item {{if .Project}}gt-hidden{{end}}">{{.locale.Tr "repo.issues.new.no_projects"}}</span>
|
2020-11-29 14:22:04 +08:00
|
|
|
<div class="selected">
|
|
|
|
|
{{if .Project}}
|
2023-03-07 03:48:04 +08:00
|
|
|
<a class="item muted sidebar-item-link" href="{{.Project.Link}}">
|
|
|
|
|
{{if .IsOrganizationProject}}{{svg "octicon-project-symlink" 18 "gt-mr-3"}}{{else}}{{svg "octicon-project" 18 "gt-mr-3"}}{{end}}
|
2020-11-29 14:22:04 +08:00
|
|
|
{{.Project.Title}}
|
|
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2020-08-17 11:07:38 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-08-10 21:47:23 +08:00
|
|
|
<div class="ui divider"></div>
|
2018-05-10 00:29:04 +08:00
|
|
|
<input id="assignee_ids" name="assignee_ids" type="hidden" value="{{.assignee_ids}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating jump select-assignees dropdown">
|
2018-05-10 00:29:04 +08:00
|
|
|
<span class="text">
|
2022-06-28 04:58:46 +08:00
|
|
|
<strong>{{.locale.Tr "repo.issues.new.assignees"}}</strong>
|
2020-04-04 13:39:48 +08:00
|
|
|
{{if .HasIssuesOrPullsWritePermission}}
|
2020-09-12 04:19:00 +08:00
|
|
|
{{svg "octicon-gear"}}
|
2020-04-04 13:39:48 +08:00
|
|
|
{{end}}
|
2018-05-10 00:29:04 +08:00
|
|
|
</span>
|
|
|
|
|
<div class="filter menu" data-id="#assignee_ids">
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="header" style="text-transform: none;font-size:16px;">{{.locale.Tr "repo.issues.new.add_assignees_title"}}</div>
|
2020-04-04 13:39:48 +08:00
|
|
|
<div class="ui icon search input">
|
2023-02-14 01:59:59 +08:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-06-28 04:58:46 +08:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_assignees"}}">
|
2020-04-04 13:39:48 +08:00
|
|
|
</div>
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="no-select item">{{.locale.Tr "repo.issues.new.clear_assignees"}}</div>
|
2018-05-10 00:29:04 +08:00
|
|
|
{{range .Assignees}}
|
2020-11-29 14:22:04 +08:00
|
|
|
<a class="item muted" href="#" data-id="{{.ID}}" data-id-selector="#assignee_{{.ID}}">
|
2020-09-12 04:19:00 +08:00
|
|
|
<span class="octicon-check invisible">{{svg "octicon-check"}}</span>
|
2018-05-10 00:29:04 +08:00
|
|
|
<span class="text">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context . 28 "gt-mr-3"}}{{.GetDisplayName}}
|
2018-05-10 00:29:04 +08:00
|
|
|
</span>
|
|
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
<div class="ui assignees list">
|
2023-02-19 12:06:14 +08:00
|
|
|
<span class="no-select item {{if .HasSelectedLabel}}gt-hidden{{end}}">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.new.no_assignees"}}
|
2018-05-10 00:29:04 +08:00
|
|
|
</span>
|
|
|
|
|
{{range .Assignees}}
|
2023-02-19 12:06:14 +08:00
|
|
|
<a class="item gt-p-2 muted gt-hidden" id="assignee_{{.ID}}" href="{{$.RepoLink}}/issues?assignee={{.ID}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context . 28 "gt-mr-3 gt-vm"}}{{.GetDisplayName}}
|
2018-05-10 00:29:04 +08:00
|
|
|
</a>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2022-04-28 23:45:33 +08:00
|
|
|
{{if and .PageIsComparePull (not (eq .HeadRepo.FullName .BaseCompareRepo.FullName)) .CanWriteToHeadRepo}}
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
<div class="inline field">
|
|
|
|
|
<div class="ui checkbox">
|
2022-06-28 04:58:46 +08:00
|
|
|
<label class="tooltip" data-content="{{.locale.Tr "repo.pulls.allow_edits_from_maintainers_desc"}}"><strong>{{.locale.Tr "repo.pulls.allow_edits_from_maintainers"}}</strong></label>
|
2023-02-13 14:09:52 +08:00
|
|
|
<input name="allow_maintainer_edit" type="checkbox" {{if .AllowMaintainerEdit}}checked{{end}}>
|
2022-04-28 23:45:33 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
2021-10-06 03:21:52 +08:00
|
|
|
<input type="hidden" name="redirect_after_creation" value="{{.redirect_after_creation}}">
|
2015-08-09 15:23:02 +08:00
|
|
|
</div>
|
2015-12-08 06:30:52 +08:00
|
|
|
</form>
|