2016-03-14 11:20:22 +08:00
// Copyright 2016 The Gogs Authors. All rights reserved.
2018-06-19 23:15:11 +08:00
// Copyright 2018 The Gitea Authors. All rights reserved.
2016-03-14 11:20:22 +08:00
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package repo
import (
"fmt"
2018-07-18 05:23:58 +08:00
"net/http"
2016-03-14 11:20:22 +08:00
"strings"
2019-01-02 01:56:47 +08:00
"time"
2016-03-14 11:20:22 +08:00
2016-11-11 00:24:48 +08:00
"code.gitea.io/gitea/models"
"code.gitea.io/gitea/modules/context"
2019-02-21 08:54:05 +08:00
issue_indexer "code.gitea.io/gitea/modules/indexer/issues"
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
"code.gitea.io/gitea/modules/log"
2016-11-11 00:24:48 +08:00
"code.gitea.io/gitea/modules/setting"
2019-08-24 00:40:30 +08:00
api "code.gitea.io/gitea/modules/structs"
2019-08-15 22:46:21 +08:00
"code.gitea.io/gitea/modules/timeutil"
2017-01-25 10:43:02 +08:00
"code.gitea.io/gitea/modules/util"
2019-09-30 21:50:44 +08:00
issue_service "code.gitea.io/gitea/services/issue"
2016-03-14 11:20:22 +08:00
)
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
// SearchIssues searches for issues across the repositories that the user has access to
func SearchIssues ( ctx * context . APIContext ) {
// swagger:operation GET /repos/issues/search issue issueSearchIssues
// ---
// summary: Search for issues across the repositories that the user has access to
// produces:
// - application/json
// parameters:
// - name: state
// in: query
// description: whether issue is open or closed
// type: string
// - name: labels
// in: query
// description: comma separated list of labels. Fetch only issues that have any of this labels. Non existent labels are discarded
// type: string
// - name: page
// in: query
// description: page number of requested issues
// type: integer
// - name: q
// in: query
// description: search string
// type: string
// - name: priority_repo_id
// in: query
// description: repository to prioritize in the results
// type: integer
// format: int64
// responses:
// "200":
// "$ref": "#/responses/IssueList"
2019-12-21 01:07:12 +08:00
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
var isClosed util . OptionalBool
switch ctx . Query ( "state" ) {
case "closed" :
isClosed = util . OptionalBoolTrue
case "all" :
isClosed = util . OptionalBoolNone
default :
isClosed = util . OptionalBoolFalse
}
// find repos user can access (for issue search)
repoIDs := make ( [ ] int64 , 0 )
issueCount := 0
for page := 1 ; ; page ++ {
repos , count , err := models . SearchRepositoryByName ( & models . SearchRepoOptions {
Page : page ,
PageSize : 15 ,
Private : true ,
Keyword : "" ,
OwnerID : ctx . User . ID ,
TopicOnly : false ,
Collaborate : util . OptionalBoolNone ,
UserIsAdmin : ctx . IsUserSiteAdmin ( ) ,
UserID : ctx . User . ID ,
OrderBy : models . SearchOrderByRecentUpdated ,
} )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "SearchRepositoryByName" , err )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
return
}
if len ( repos ) == 0 {
break
}
log . Trace ( "Processing next %d repos of %d" , len ( repos ) , count )
for _ , repo := range repos {
switch isClosed {
case util . OptionalBoolTrue :
issueCount += repo . NumClosedIssues
case util . OptionalBoolFalse :
issueCount += repo . NumOpenIssues
case util . OptionalBoolNone :
issueCount += repo . NumIssues
}
repoIDs = append ( repoIDs , repo . ID )
}
}
var issues [ ] * models . Issue
keyword := strings . Trim ( ctx . Query ( "q" ) , " " )
if strings . IndexByte ( keyword , 0 ) >= 0 {
keyword = ""
}
var issueIDs [ ] int64
var labelIDs [ ] int64
var err error
if len ( keyword ) > 0 && len ( repoIDs ) > 0 {
issueIDs , err = issue_indexer . SearchIssuesByKeyword ( repoIDs , keyword )
}
labels := ctx . Query ( "labels" )
if splitted := strings . Split ( labels , "," ) ; labels != "" && len ( splitted ) > 0 {
labelIDs , err = models . GetLabelIDsInReposByNames ( repoIDs , splitted )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetLabelIDsInRepoByNames" , err )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
return
}
}
// Only fetch the issues if we either don't have a keyword or the search returned issues
// This would otherwise return all issues if no issues were found by the search.
if len ( keyword ) == 0 || len ( issueIDs ) > 0 || len ( labelIDs ) > 0 {
issues , err = models . Issues ( & models . IssuesOptions {
RepoIDs : repoIDs ,
Page : ctx . QueryInt ( "page" ) ,
PageSize : setting . UI . IssuePagingNum ,
IsClosed : isClosed ,
IssueIDs : issueIDs ,
LabelIDs : labelIDs ,
SortType : "priorityrepo" ,
PriorityRepoID : ctx . QueryInt64 ( "priority_repo_id" ) ,
} )
}
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "Issues" , err )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
return
}
apiIssues := make ( [ ] * api . Issue , len ( issues ) )
for i := range issues {
apiIssues [ i ] = issues [ i ] . APIFormat ( )
}
ctx . SetLinkHeader ( issueCount , setting . UI . IssuePagingNum )
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusOK , & apiIssues )
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
}
2016-11-24 15:04:31 +08:00
// ListIssues list the issues of a repository
2016-03-14 11:20:22 +08:00
func ListIssues ( ctx * context . APIContext ) {
2017-11-13 15:02:25 +08:00
// swagger:operation GET /repos/{owner}/{repo}/issues issue issueListIssues
// ---
// summary: List a repository's issues
// produces:
// - application/json
// parameters:
// - name: owner
// in: path
// description: owner of the repo
// type: string
// required: true
// - name: repo
// in: path
// description: name of the repo
// type: string
// required: true
// - name: state
// in: query
// description: whether issue is open or closed
// type: string
2019-02-04 23:20:44 +08:00
// - name: labels
// in: query
// description: comma separated list of labels. Fetch only issues that have any of this labels. Non existent labels are discarded
// type: string
2017-11-13 15:02:25 +08:00
// - name: page
// in: query
// description: page number of requested issues
// type: integer
2018-03-07 18:00:56 +08:00
// - name: q
// in: query
// description: search string
// type: string
2017-11-13 15:02:25 +08:00
// responses:
// "200":
// "$ref": "#/responses/IssueList"
2019-12-21 01:07:12 +08:00
2017-06-25 22:51:07 +08:00
var isClosed util . OptionalBool
switch ctx . Query ( "state" ) {
case "closed" :
isClosed = util . OptionalBoolTrue
case "all" :
isClosed = util . OptionalBoolNone
default :
isClosed = util . OptionalBoolFalse
2016-10-08 01:17:27 +08:00
}
2018-03-07 18:00:56 +08:00
var issues [ ] * models . Issue
keyword := strings . Trim ( ctx . Query ( "q" ) , " " )
if strings . IndexByte ( keyword , 0 ) >= 0 {
keyword = ""
}
var issueIDs [ ] int64
2019-02-04 23:20:44 +08:00
var labelIDs [ ] int64
2018-03-07 18:00:56 +08:00
var err error
if len ( keyword ) > 0 {
Allow cross-repository dependencies on issues (#7901)
* in progress changes for #7405, added ability to add cross-repo dependencies
* removed unused repolink var
* fixed query that was breaking ci tests; fixed check in issue dependency add so that the id of the issue and dependency is checked rather than the indexes
* reverted removal of string in local files becasue these are done via crowdin, not updated manually
* removed 'Select("issue.*")' from getBlockedByDependencies and getBlockingDependencies based on comments in PR review
* changed getBlockedByDependencies and getBlockingDependencies to use a more xorm-like query, also updated the sidebar as a result
* simplified the getBlockingDependencies and getBlockedByDependencies methods; changed the sidebar to show the dependencies in a different format where you can see the name of the repository
* made some changes to the issue view in the dependencies (issue name on top, repo full name on separate line). Change view of issue in the dependency search results (also showing the full repo name on separate line)
* replace call to FindUserAccessibleRepoIDs with SearchRepositoryByName. The former was hardcoded to use isPrivate = false on the repo search, but this code needed it to be true. The SearchRepositoryByName method is used more in the code including on the user's dashboard
* some more tweaks to the layout of the issues when showing dependencies and in the search box when you add new dependencies
* added Name to the RepositoryMeta struct
* updated swagger doc
* fixed total count for link header on SearchIssues
* fixed indentation
* fixed aligment of remove icon on dependencies in issue sidebar
* removed unnecessary nil check (unnecessary because issue.loadRepo is called prior to this block)
* reverting .css change, somehow missed or forgot that less is used
* updated less file and generated css; updated sidebar template with styles to line up delete and issue index
* added ordering to the blocked by/depends on queries
* fixed sorting in issue dependency search and the depends on/blocks views to show issues from the current repo first, then by created date descending; added a "all cross repository dependencies" setting to allow this feature to be turned off, if turned off, the issue dependency search will work the way it did before (restricted to the current repository)
* re-applied my swagger changes after merge
* fixed split string condition in issue search
* changed ALLOW_CROSS_REPOSITORY_DEPENDENCIES description to sound more global than just the issue dependency search; returning 400 in the cross repo issue search api method if not enabled; fixed bug where the issue count did not respect the state parameter
* when adding a dependency to an issue, added a check to make sure the issue and dependency are in the same repo if cross repo dependencies is not enabled
* updated sortIssuesSession call in PullRequests, another commit moved this method from pull.go to pull_list.go so I had to re-apply my change here
* fixed incorrect setting of user id parameter in search repos call
2019-10-31 13:06:10 +08:00
issueIDs , err = issue_indexer . SearchIssuesByKeyword ( [ ] int64 { ctx . Repo . Repository . ID } , keyword )
2018-03-07 18:00:56 +08:00
}
2019-02-04 23:20:44 +08:00
if splitted := strings . Split ( ctx . Query ( "labels" ) , "," ) ; len ( splitted ) > 0 {
labelIDs , err = models . GetLabelIDsInRepoByNames ( ctx . Repo . Repository . ID , splitted )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetLabelIDsInRepoByNames" , err )
2019-02-04 23:20:44 +08:00
return
}
}
2018-03-07 18:00:56 +08:00
// Only fetch the issues if we either don't have a keyword or the search returned issues
// This would otherwise return all issues if no issues were found by the search.
2019-02-04 23:20:44 +08:00
if len ( keyword ) == 0 || len ( issueIDs ) > 0 || len ( labelIDs ) > 0 {
2018-03-07 18:00:56 +08:00
issues , err = models . Issues ( & models . IssuesOptions {
RepoIDs : [ ] int64 { ctx . Repo . Repository . ID } ,
Page : ctx . QueryInt ( "page" ) ,
PageSize : setting . UI . IssuePagingNum ,
IsClosed : isClosed ,
IssueIDs : issueIDs ,
2019-02-04 23:20:44 +08:00
LabelIDs : labelIDs ,
2018-03-07 18:00:56 +08:00
} )
}
2016-03-14 11:20:22 +08:00
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "Issues" , err )
2016-03-14 11:20:22 +08:00
return
}
apiIssues := make ( [ ] * api . Issue , len ( issues ) )
for i := range issues {
2016-08-14 19:17:26 +08:00
apiIssues [ i ] = issues [ i ] . APIFormat ( )
2016-03-14 11:20:22 +08:00
}
2016-07-24 00:23:54 +08:00
ctx . SetLinkHeader ( ctx . Repo . Repository . NumIssues , setting . UI . IssuePagingNum )
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusOK , & apiIssues )
2016-03-14 11:20:22 +08:00
}
2016-11-24 15:04:31 +08:00
// GetIssue get an issue of a repository
2016-03-14 11:20:22 +08:00
func GetIssue ( ctx * context . APIContext ) {
2018-01-04 14:31:40 +08:00
// swagger:operation GET /repos/{owner}/{repo}/issues/{index} issue issueGetIssue
2017-11-13 15:02:25 +08:00
// ---
2018-01-04 14:31:40 +08:00
// summary: Get an issue
2017-11-13 15:02:25 +08:00
// produces:
// - application/json
// parameters:
// - name: owner
// in: path
// description: owner of the repo
// type: string
// required: true
// - name: repo
// in: path
// description: name of the repo
// type: string
// required: true
2018-01-04 14:31:40 +08:00
// - name: index
2017-11-13 15:02:25 +08:00
// in: path
2018-01-04 14:31:40 +08:00
// description: index of the issue to get
2017-11-13 15:02:25 +08:00
// type: integer
2018-10-21 11:40:42 +08:00
// format: int64
2017-11-13 15:02:25 +08:00
// required: true
// responses:
// "200":
// "$ref": "#/responses/Issue"
2019-12-21 01:07:12 +08:00
// "404":
// "$ref": "#/responses/notFound"
2019-02-20 01:07:19 +08:00
issue , err := models . GetIssueWithAttrsByIndex ( ctx . Repo . Repository . ID , ctx . ParamsInt64 ( ":index" ) )
2016-03-14 11:20:22 +08:00
if err != nil {
if models . IsErrIssueNotExist ( err ) {
2019-03-19 10:29:43 +08:00
ctx . NotFound ( )
2016-03-14 11:20:22 +08:00
} else {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetIssueByIndex" , err )
2016-03-14 11:20:22 +08:00
}
return
}
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusOK , issue . APIFormat ( ) )
2016-03-14 11:20:22 +08:00
}
2016-11-24 15:04:31 +08:00
// CreateIssue create an issue of a repository
2016-03-14 11:20:22 +08:00
func CreateIssue ( ctx * context . APIContext , form api . CreateIssueOption ) {
2017-11-13 15:02:25 +08:00
// swagger:operation POST /repos/{owner}/{repo}/issues issue issueCreateIssue
// ---
2019-01-02 01:56:47 +08:00
// summary: Create an issue. If using deadline only the date will be taken into account, and time of day ignored.
2017-11-13 15:02:25 +08:00
// consumes:
// - application/json
// produces:
// - application/json
// parameters:
// - name: owner
// in: path
// description: owner of the repo
// type: string
// required: true
// - name: repo
// in: path
// description: name of the repo
// type: string
// required: true
// - name: body
// in: body
// schema:
// "$ref": "#/definitions/CreateIssueOption"
// responses:
// "201":
// "$ref": "#/responses/Issue"
2019-12-21 01:07:12 +08:00
// "403":
// "$ref": "#/responses/forbidden"
// "412":
// "$ref": "#/responses/error"
// "422":
// "$ref": "#/responses/validationError"
2018-05-02 03:05:28 +08:00
2019-08-15 22:46:21 +08:00
var deadlineUnix timeutil . TimeStamp
2018-11-28 19:26:14 +08:00
if form . Deadline != nil && ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
2019-08-15 22:46:21 +08:00
deadlineUnix = timeutil . TimeStamp ( form . Deadline . Unix ( ) )
2018-05-02 03:05:28 +08:00
}
2016-03-14 11:20:22 +08:00
issue := & models . Issue {
2018-05-02 03:05:28 +08:00
RepoID : ctx . Repo . Repository . ID ,
2018-12-13 23:55:43 +08:00
Repo : ctx . Repo . Repository ,
2018-05-02 03:05:28 +08:00
Title : form . Title ,
PosterID : ctx . User . ID ,
Poster : ctx . User ,
Content : form . Body ,
DeadlineUnix : deadlineUnix ,
2016-03-14 11:20:22 +08:00
}
2018-06-19 23:15:11 +08:00
var assigneeIDs = make ( [ ] int64 , 0 )
var err error
2018-11-28 19:26:14 +08:00
if ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
2018-06-19 23:15:11 +08:00
issue . MilestoneID = form . Milestone
assigneeIDs , err = models . MakeIDsFromAPIAssigneesToAdd ( form . Assignee , form . Assignees )
if err != nil {
if models . IsErrUserNotExist ( err ) {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusUnprocessableEntity , "" , fmt . Sprintf ( "Assignee does not exist: [name: %s]" , err ) )
2018-06-19 23:15:11 +08:00
} else {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "AddAssigneeByName" , err )
2018-06-19 23:15:11 +08:00
}
return
2016-03-14 11:20:22 +08:00
}
2019-10-25 22:46:37 +08:00
// Check if the passed assignees is assignable
for _ , aID := range assigneeIDs {
assignee , err := models . GetUserByID ( aID )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetUserByID" , err )
2019-10-25 22:46:37 +08:00
return
}
valid , err := models . CanBeAssigned ( assignee , ctx . Repo . Repository , false )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "canBeAssigned" , err )
2019-10-25 22:46:37 +08:00
return
}
if ! valid {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusUnprocessableEntity , "canBeAssigned" , models . ErrUserDoesNotHaveAccessToRepo { UserID : aID , RepoName : ctx . Repo . Repository . Name } )
2019-10-25 22:46:37 +08:00
return
}
}
2018-06-19 23:15:11 +08:00
} else {
// setting labels is not allowed if user is not a writer
form . Labels = make ( [ ] int64 , 0 )
2016-03-14 11:20:22 +08:00
}
2019-10-29 00:45:43 +08:00
if err := issue_service . NewIssue ( ctx . Repo . Repository , issue , form . Labels , nil , assigneeIDs ) ; err != nil {
2018-05-10 00:29:04 +08:00
if models . IsErrUserDoesNotHaveAccessToRepo ( err ) {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusBadRequest , "UserDoesNotHaveAccessToRepo" , err )
2018-05-10 00:29:04 +08:00
return
}
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "NewIssue" , err )
2016-03-14 11:20:22 +08:00
return
}
2016-05-28 09:23:39 +08:00
if form . Closed {
2019-10-28 13:26:46 +08:00
if err := issue_service . ChangeStatus ( issue , ctx . User , true ) ; err != nil {
2018-07-18 05:23:58 +08:00
if models . IsErrDependenciesLeft ( err ) {
ctx . Error ( http . StatusPreconditionFailed , "DependenciesLeft" , "cannot close this issue because it still has open dependencies" )
return
}
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "ChangeStatus" , err )
2016-05-28 09:23:39 +08:00
return
}
}
2016-03-14 11:20:22 +08:00
// Refetch from database to assign some automatic values
issue , err = models . GetIssueByID ( issue . ID )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetIssueByID" , err )
2016-03-14 11:20:22 +08:00
return
}
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusCreated , issue . APIFormat ( ) )
2016-03-14 11:20:22 +08:00
}
2016-11-24 15:04:31 +08:00
// EditIssue modify an issue of a repository
2016-03-14 11:20:22 +08:00
func EditIssue ( ctx * context . APIContext , form api . EditIssueOption ) {
2018-01-04 14:31:40 +08:00
// swagger:operation PATCH /repos/{owner}/{repo}/issues/{index} issue issueEditIssue
2017-11-13 15:02:25 +08:00
// ---
2019-01-02 01:56:47 +08:00
// summary: Edit an issue. If using deadline only the date will be taken into account, and time of day ignored.
2017-11-13 15:02:25 +08:00
// consumes:
// - application/json
// produces:
// - application/json
// parameters:
// - name: owner
// in: path
// description: owner of the repo
// type: string
// required: true
// - name: repo
// in: path
// description: name of the repo
// type: string
// required: true
2018-01-04 14:31:40 +08:00
// - name: index
2017-11-13 15:02:25 +08:00
// in: path
2018-01-04 14:31:40 +08:00
// description: index of the issue to edit
2017-11-13 15:02:25 +08:00
// type: integer
2018-10-21 11:40:42 +08:00
// format: int64
2017-11-13 15:02:25 +08:00
// required: true
// - name: body
// in: body
// schema:
// "$ref": "#/definitions/EditIssueOption"
// responses:
// "201":
// "$ref": "#/responses/Issue"
2019-12-21 01:07:12 +08:00
// "403":
// "$ref": "#/responses/forbidden"
// "404":
// "$ref": "#/responses/notFound"
// "412":
// "$ref": "#/responses/error"
2016-03-14 11:20:22 +08:00
issue , err := models . GetIssueByIndex ( ctx . Repo . Repository . ID , ctx . ParamsInt64 ( ":index" ) )
if err != nil {
if models . IsErrIssueNotExist ( err ) {
2019-03-19 10:29:43 +08:00
ctx . NotFound ( )
2016-03-14 11:20:22 +08:00
} else {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetIssueByIndex" , err )
2016-03-14 11:20:22 +08:00
}
return
}
2018-12-13 23:55:43 +08:00
issue . Repo = ctx . Repo . Repository
2016-03-14 11:20:22 +08:00
2019-04-24 01:07:12 +08:00
err = issue . LoadAttributes ( )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "LoadAttributes" , err )
2019-04-24 01:07:12 +08:00
return
}
2018-11-28 19:26:14 +08:00
if ! issue . IsPoster ( ctx . User . ID ) && ! ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
2019-12-21 01:07:12 +08:00
ctx . Status ( http . StatusForbidden )
2016-03-14 11:20:22 +08:00
return
}
if len ( form . Title ) > 0 {
2016-08-14 18:32:24 +08:00
issue . Title = form . Title
2016-03-14 11:20:22 +08:00
}
if form . Body != nil {
issue . Content = * form . Body
}
2019-11-03 22:46:32 +08:00
// Update or remove the deadline, only if set and allowed
if ( form . Deadline != nil || form . RemoveDeadline != nil ) && ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
var deadlineUnix timeutil . TimeStamp
if ( form . RemoveDeadline == nil || ! * form . RemoveDeadline ) && ! form . Deadline . IsZero ( ) {
deadline := time . Date ( form . Deadline . Year ( ) , form . Deadline . Month ( ) , form . Deadline . Day ( ) ,
23 , 59 , 59 , 0 , form . Deadline . Location ( ) )
deadlineUnix = timeutil . TimeStamp ( deadline . Unix ( ) )
}
2019-10-28 07:35:20 +08:00
if err := models . UpdateIssueDeadline ( issue , deadlineUnix , ctx . User ) ; err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "UpdateIssueDeadline" , err )
2019-10-28 07:35:20 +08:00
return
}
issue . DeadlineUnix = deadlineUnix
2018-05-02 03:05:28 +08:00
}
2018-05-10 00:29:04 +08:00
// Add/delete assignees
2019-03-10 05:15:45 +08:00
// Deleting is done the GitHub way (quote from their api documentation):
2018-05-10 00:29:04 +08:00
// https://developer.github.com/v3/issues/#edit-an-issue
// "assignees" (array): Logins for Users to assign to this issue.
// Pass one or more user logins to replace the set of assignees on this Issue.
// Send an empty array ([]) to clear all assignees from the Issue.
2018-11-28 19:26:14 +08:00
if ctx . Repo . CanWrite ( models . UnitTypeIssues ) && ( form . Assignees != nil || form . Assignee != nil ) {
2018-05-10 00:29:04 +08:00
oneAssignee := ""
if form . Assignee != nil {
oneAssignee = * form . Assignee
2016-03-14 11:20:22 +08:00
}
2019-10-25 22:46:37 +08:00
err = issue_service . UpdateAssignees ( issue , oneAssignee , form . Assignees , ctx . User )
2018-05-10 00:29:04 +08:00
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "UpdateAssignees" , err )
2016-03-14 11:20:22 +08:00
return
}
}
2018-05-10 00:29:04 +08:00
2018-11-28 19:26:14 +08:00
if ctx . Repo . CanWrite ( models . UnitTypeIssues ) && form . Milestone != nil &&
2016-03-14 11:20:22 +08:00
issue . MilestoneID != * form . Milestone {
2016-08-16 09:40:32 +08:00
oldMilestoneID := issue . MilestoneID
2016-03-14 11:20:22 +08:00
issue . MilestoneID = * form . Milestone
2019-11-02 11:33:20 +08:00
if err = issue_service . ChangeMilestoneAssign ( issue , ctx . User , oldMilestoneID ) ; err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "ChangeMilestoneAssign" , err )
2016-03-14 11:20:22 +08:00
return
}
}
if err = models . UpdateIssue ( issue ) ; err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "UpdateIssue" , err )
2016-03-14 11:20:22 +08:00
return
}
2016-08-24 00:09:32 +08:00
if form . State != nil {
2019-10-28 13:26:46 +08:00
if err = issue_service . ChangeStatus ( issue , ctx . User , api . StateClosed == api . StateType ( * form . State ) ) ; err != nil {
2018-07-18 05:23:58 +08:00
if models . IsErrDependenciesLeft ( err ) {
ctx . Error ( http . StatusPreconditionFailed , "DependenciesLeft" , "cannot close this issue because it still has open dependencies" )
return
}
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "ChangeStatus" , err )
2016-08-24 00:09:32 +08:00
return
}
}
2016-03-14 11:20:22 +08:00
// Refetch from database to assign some automatic values
issue , err = models . GetIssueByID ( issue . ID )
if err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetIssueByID" , err )
2016-03-14 11:20:22 +08:00
return
}
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusCreated , issue . APIFormat ( ) )
2016-03-14 11:20:22 +08:00
}
2018-07-16 20:43:00 +08:00
// UpdateIssueDeadline updates an issue deadline
func UpdateIssueDeadline ( ctx * context . APIContext , form api . EditDeadlineOption ) {
// swagger:operation POST /repos/{owner}/{repo}/issues/{index}/deadline issue issueEditIssueDeadline
// ---
2019-01-02 01:56:47 +08:00
// summary: Set an issue deadline. If set to null, the deadline is deleted. If using deadline only the date will be taken into account, and time of day ignored.
2018-07-16 20:43:00 +08:00
// consumes:
// - application/json
// produces:
// - application/json
// parameters:
// - name: owner
// in: path
// description: owner of the repo
// type: string
// required: true
// - name: repo
// in: path
// description: name of the repo
// type: string
// required: true
// - name: index
// in: path
// description: index of the issue to create or update a deadline on
// type: integer
2018-10-21 11:40:42 +08:00
// format: int64
2018-07-16 20:43:00 +08:00
// required: true
// - name: body
// in: body
// schema:
// "$ref": "#/definitions/EditDeadlineOption"
// responses:
// "201":
// "$ref": "#/responses/IssueDeadline"
// "403":
2019-12-21 01:07:12 +08:00
// "$ref": "#/responses/forbidden"
2018-07-16 20:43:00 +08:00
// "404":
2019-12-21 01:07:12 +08:00
// "$ref": "#/responses/notFound"
2018-07-16 20:43:00 +08:00
issue , err := models . GetIssueByIndex ( ctx . Repo . Repository . ID , ctx . ParamsInt64 ( ":index" ) )
if err != nil {
if models . IsErrIssueNotExist ( err ) {
2019-03-19 10:29:43 +08:00
ctx . NotFound ( )
2018-07-16 20:43:00 +08:00
} else {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "GetIssueByIndex" , err )
2018-07-16 20:43:00 +08:00
}
return
}
2018-11-28 19:26:14 +08:00
if ! ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusForbidden , "" , "Not repo writer" )
2018-07-16 20:43:00 +08:00
return
}
2019-08-15 22:46:21 +08:00
var deadlineUnix timeutil . TimeStamp
2019-01-02 01:56:47 +08:00
var deadline time . Time
2018-07-16 20:43:00 +08:00
if form . Deadline != nil && ! form . Deadline . IsZero ( ) {
2019-01-02 01:56:47 +08:00
deadline = time . Date ( form . Deadline . Year ( ) , form . Deadline . Month ( ) , form . Deadline . Day ( ) ,
23 , 59 , 59 , 0 , form . Deadline . Location ( ) )
2019-08-15 22:46:21 +08:00
deadlineUnix = timeutil . TimeStamp ( deadline . Unix ( ) )
2018-07-16 20:43:00 +08:00
}
if err := models . UpdateIssueDeadline ( issue , deadlineUnix , ctx . User ) ; err != nil {
2019-12-21 01:07:12 +08:00
ctx . Error ( http . StatusInternalServerError , "UpdateIssueDeadline" , err )
2018-07-16 20:43:00 +08:00
return
}
2019-12-21 01:07:12 +08:00
ctx . JSON ( http . StatusCreated , api . IssueDeadline { Deadline : & deadline } )
2018-07-16 20:43:00 +08:00
}