2023-03-03 01:44:06 +08:00
|
|
|
{{if .ctxData.IsSigned}}
|
2023-03-17 11:08:05 +08:00
|
|
|
<div class="item action ui dropdown jump pointing top right select-reaction" data-action-url="{{.ActionURL}}">
|
2017-12-04 07:14:26 +08:00
|
|
|
<a class="add-reaction">
|
2020-09-12 04:19:00 +08:00
|
|
|
{{svg "octicon-smiley"}}
|
2017-12-04 07:14:26 +08:00
|
|
|
</a>
|
2020-04-29 02:05:39 +08:00
|
|
|
<div class="menu">
|
2023-03-03 01:44:06 +08:00
|
|
|
<div class="header">{{.ctxData.locale.Tr "repo.pick_reaction"}}</div>
|
2017-12-04 07:14:26 +08:00
|
|
|
<div class="divider"></div>
|
2019-12-28 07:43:56 +08:00
|
|
|
{{range $value := AllowedReactions}}
|
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
</details>
---------
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 09:26:27 +08:00
|
|
|
<a class="item reaction tooltip" data-content="{{$value}}">{{ReactionToEmoji $value}}</a>
|
2019-12-02 06:57:24 +08:00
|
|
|
{{end}}
|
2017-12-04 07:14:26 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|