2017-12-31 08:47:52 +08:00
|
|
|
<div class="ui stackable grid">
|
2015-08-12 17:04:23 +08:00
|
|
|
{{if .Flash}}
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="sixteen wide column">
|
|
|
|
|
{{template "base/alert" .}}
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{if not .Issue.IsPull}}
|
|
|
|
|
{{template "repo/issue/view_title" .}}
|
|
|
|
|
{{end}}
|
|
|
|
|
|
2021-10-11 06:40:03 +08:00
|
|
|
<!-- I know, there is probably a better way to do this (moved from sidebar.tmpl, original author: 6543 @ 2021-02-28) -->
|
2021-10-15 10:35:26 +08:00
|
|
|
<!-- Agree, there should be a better way, eg: introduce window.config.pageData (original author: wxiaoguang @ 2021-09-05) -->
|
2021-10-11 06:40:03 +08:00
|
|
|
<input type="hidden" id="repolink" value="{{$.RepoRelPath}}">
|
|
|
|
|
<input type="hidden" id="repoId" value="{{.Repository.ID}}">
|
|
|
|
|
<input type="hidden" id="issueIndex" value="{{.Issue.Index}}"/>
|
|
|
|
|
<input type="hidden" id="type" value="{{.IssueType}}">
|
|
|
|
|
|
2022-08-31 23:58:54 +08:00
|
|
|
{{$createdStr:= TimeSinceUnix .Issue.CreatedUnix $.locale}}
|
2019-07-07 05:37:46 +08:00
|
|
|
<div class="twelve wide column comment-list prevent-before-timeline">
|
2020-04-11 06:01:41 +08:00
|
|
|
<ui class="ui timeline">
|
|
|
|
|
<div id="{{.Issue.HashTag}}" class="timeline-item comment first">
|
2022-08-31 23:58:54 +08:00
|
|
|
{{if .Issue.OriginalAuthor}}
|
2021-05-22 01:03:27 +08:00
|
|
|
<span class="timeline-avatar"><img src="{{AppSubUrl}}/assets/img/avatar_default.png"></span>
|
2019-07-08 10:14:12 +08:00
|
|
|
{{else}}
|
2020-04-11 06:01:41 +08:00
|
|
|
<a class="timeline-avatar" {{if gt .Issue.Poster.ID 0}}href="{{.Issue.Poster.HomeLink}}"{{end}}>
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context .Issue.Poster}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</a>
|
2019-07-08 10:14:12 +08:00
|
|
|
{{end}}
|
2020-11-08 07:15:09 +08:00
|
|
|
<div class="content comment-container">
|
Improve accessibility for issue comments (#22612) (#23083)
Backport #22612
### Preamble
Gitea is an extremely great and smart solution perfectly suitable for
smaller systems and self-hosted Git-powered setups. However, there is a
group of people who have indredible difficulties in using Gitea,
rendering it useless in many cases. Those people are blind developers
using [screen readers](https://en.wikipedia.org/wiki/Screen_reader).
Unfortunately, the frontend framework is super convoluted, and Go
templates don’t allow accessibility improvements in a straightforward
way. As a blind developer myself, I'm trying to start fixing smaller
accessibility quirks with intention to go deeper and eventually, alone
or not, make Gitea at least mostly accessible for screen reader users.
### What This Fix Does
My blind fellows and me navigate webpages not very similarly to how a
sighted person does it. For instance, we love semantic HTML markup like
headings, lists, tables etc. because our screen readers allow us to jump
by those landmarks with a single keypress.
Currently in Gitea issue comments are not marked up with headings. I'm
trying to fix this by adding an appropriate
[ARIA](https://www.w3.org/WAI/standards-guidelines/aria/) role for
comment header and also by enclosing the comment itself in a semantical
article element.
Co-authored-by: Andre Polykanine <ap@oire.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
2023-02-23 16:32:15 +08:00
|
|
|
<div class="ui top attached header comment-header gt-df gt-ac gt-sb" role="heading" aria-level="3">
|
2023-02-14 01:59:59 +08:00
|
|
|
<div class="comment-header-left gt-df gt-ac">
|
2022-08-31 23:58:54 +08:00
|
|
|
{{if .Issue.OriginalAuthor}}
|
2023-02-14 01:59:59 +08:00
|
|
|
<span class="text black gt-bold">
|
2021-09-19 00:22:51 +08:00
|
|
|
{{svg (MigrationIcon .Repository.GetOriginalURLHostname)}}
|
2022-08-31 23:58:54 +08:00
|
|
|
{{.Issue.OriginalAuthor}}
|
2020-10-31 21:17:52 +08:00
|
|
|
</span>
|
|
|
|
|
<span class="text grey">
|
2022-08-31 23:58:54 +08:00
|
|
|
{{.locale.Tr "repo.issues.commented_at" (.Issue.HashTag|Escape) $createdStr | Safe}}
|
2020-10-31 21:17:52 +08:00
|
|
|
</span>
|
|
|
|
|
<span class="text migrate">
|
2022-08-31 23:58:54 +08:00
|
|
|
{{if .Repository.OriginalURL}} ({{$.locale.Tr "repo.migrated_from" (.Repository.OriginalURL|Escape) (.Repository.GetOriginalURLHostname|Escape) | Safe}}){{end}}
|
2020-10-31 21:17:52 +08:00
|
|
|
</span>
|
|
|
|
|
{{else}}
|
Improve UI on mobile (#19546)
Start making the mobile experience not painful and be actually usable. This contains a few smaller changes to enhance this experience.
- Submit buttons on the review forms aren't columns anymore and are now allowed to be displayed on one row.
- The label/milestone & New Issue buttons were given each own row even tough, there's enough place to do it one the same row. This commit fixes that.
- The issues+Pull tab on repo's has a third item besides the label/milestone & New Issue buttons, the search bar. On desktop there's enough place to do this on one row, for mobile it isn't, currently it was using for each item a new row. This commits fixes that by only giving the searchbar a new row and have the other two buttons on the same row.
- The notification table will now be show a scrollbar instead of overflow.
- The repo buttons(Watch, Star, Fork) on mobile were showing quite big and the SVG wasn't even displayed on the same line, if the count of those numbers were too high it would even overflow. This commit removes the SVG, as there isn't any place to show them on the same row and allows them to have a new row if the counts of those buttons are high.
- The admin page can show you a lot of interesting information, on mobile the System Status + Configuration weren't properly displayed as the margin's were too high. This commit fixes that by reducing the margin to a number that makes sense on mobile.
- Fixes to not overflow the tables but instead force them to be scrollable.
- When viewing a issue or pull request, the comments aren't full-width but instead 80% and aligned to right, on mobile this is a annoyance as there isn't much width to begin with. This commits fixes that by forcing full-width and removing the avatars on the left side and instead including them inline in the comment header.
2022-05-02 00:11:21 +08:00
|
|
|
<a class="inline-timeline-avatar" href="{{.Issue.Poster.HomeLink}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context .Issue.Poster}}
|
Improve UI on mobile (#19546)
Start making the mobile experience not painful and be actually usable. This contains a few smaller changes to enhance this experience.
- Submit buttons on the review forms aren't columns anymore and are now allowed to be displayed on one row.
- The label/milestone & New Issue buttons were given each own row even tough, there's enough place to do it one the same row. This commit fixes that.
- The issues+Pull tab on repo's has a third item besides the label/milestone & New Issue buttons, the search bar. On desktop there's enough place to do this on one row, for mobile it isn't, currently it was using for each item a new row. This commits fixes that by only giving the searchbar a new row and have the other two buttons on the same row.
- The notification table will now be show a scrollbar instead of overflow.
- The repo buttons(Watch, Star, Fork) on mobile were showing quite big and the SVG wasn't even displayed on the same line, if the count of those numbers were too high it would even overflow. This commit removes the SVG, as there isn't any place to show them on the same row and allows them to have a new row if the counts of those buttons are high.
- The admin page can show you a lot of interesting information, on mobile the System Status + Configuration weren't properly displayed as the margin's were too high. This commit fixes that by reducing the margin to a number that makes sense on mobile.
- Fixes to not overflow the tables but instead force them to be scrollable.
- When viewing a issue or pull request, the comments aren't full-width but instead 80% and aligned to right, on mobile this is a annoyance as there isn't much width to begin with. This commits fixes that by forcing full-width and removing the avatars on the left side and instead including them inline in the comment header.
2022-05-02 00:11:21 +08:00
|
|
|
</a>
|
2020-10-31 21:17:52 +08:00
|
|
|
<span class="text grey">
|
2022-11-19 12:02:30 +08:00
|
|
|
{{template "shared/user/authorlink" .Issue.Poster}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.commented_at" (.Issue.HashTag|Escape) $createdStr | Safe}}
|
2020-10-31 21:17:52 +08:00
|
|
|
</span>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2023-02-14 01:59:59 +08:00
|
|
|
<div class="comment-header-right actions gt-df gt-ac">
|
2021-12-05 23:04:02 +08:00
|
|
|
{{if gt .Issue.ShowRole 0}}
|
|
|
|
|
{{if (.Issue.ShowRole.HasRole "Writer")}}
|
Improve UI on mobile (#19546)
Start making the mobile experience not painful and be actually usable. This contains a few smaller changes to enhance this experience.
- Submit buttons on the review forms aren't columns anymore and are now allowed to be displayed on one row.
- The label/milestone & New Issue buttons were given each own row even tough, there's enough place to do it one the same row. This commit fixes that.
- The issues+Pull tab on repo's has a third item besides the label/milestone & New Issue buttons, the search bar. On desktop there's enough place to do this on one row, for mobile it isn't, currently it was using for each item a new row. This commits fixes that by only giving the searchbar a new row and have the other two buttons on the same row.
- The notification table will now be show a scrollbar instead of overflow.
- The repo buttons(Watch, Star, Fork) on mobile were showing quite big and the SVG wasn't even displayed on the same line, if the count of those numbers were too high it would even overflow. This commit removes the SVG, as there isn't any place to show them on the same row and allows them to have a new row if the counts of those buttons are high.
- The admin page can show you a lot of interesting information, on mobile the System Status + Configuration weren't properly displayed as the margin's were too high. This commit fixes that by reducing the margin to a number that makes sense on mobile.
- Fixes to not overflow the tables but instead force them to be scrollable.
- When viewing a issue or pull request, the comments aren't full-width but instead 80% and aligned to right, on mobile this is a annoyance as there isn't much width to begin with. This commits fixes that by forcing full-width and removing the avatars on the left side and instead including them inline in the comment header.
2022-05-02 00:11:21 +08:00
|
|
|
<div class="ui basic label role-label">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{$.locale.Tr "repo.issues.collaborator"}}
|
2021-12-05 23:04:02 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
{{if (.Issue.ShowRole.HasRole "Owner")}}
|
Improve UI on mobile (#19546)
Start making the mobile experience not painful and be actually usable. This contains a few smaller changes to enhance this experience.
- Submit buttons on the review forms aren't columns anymore and are now allowed to be displayed on one row.
- The label/milestone & New Issue buttons were given each own row even tough, there's enough place to do it one the same row. This commit fixes that.
- The issues+Pull tab on repo's has a third item besides the label/milestone & New Issue buttons, the search bar. On desktop there's enough place to do this on one row, for mobile it isn't, currently it was using for each item a new row. This commits fixes that by only giving the searchbar a new row and have the other two buttons on the same row.
- The notification table will now be show a scrollbar instead of overflow.
- The repo buttons(Watch, Star, Fork) on mobile were showing quite big and the SVG wasn't even displayed on the same line, if the count of those numbers were too high it would even overflow. This commit removes the SVG, as there isn't any place to show them on the same row and allows them to have a new row if the counts of those buttons are high.
- The admin page can show you a lot of interesting information, on mobile the System Status + Configuration weren't properly displayed as the margin's were too high. This commit fixes that by reducing the margin to a number that makes sense on mobile.
- Fixes to not overflow the tables but instead force them to be scrollable.
- When viewing a issue or pull request, the comments aren't full-width but instead 80% and aligned to right, on mobile this is a annoyance as there isn't much width to begin with. This commits fixes that by forcing full-width and removing the avatars on the left side and instead including them inline in the comment header.
2022-05-02 00:11:21 +08:00
|
|
|
<div class="ui basic label role-label">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{$.locale.Tr "repo.issues.owner"}}
|
2021-12-05 23:04:02 +08:00
|
|
|
</div>
|
2020-09-11 02:09:14 +08:00
|
|
|
{{end}}
|
2021-12-05 23:04:02 +08:00
|
|
|
{{end}}
|
|
|
|
|
{{if not $.Repository.IsArchived}}
|
2019-12-28 07:43:56 +08:00
|
|
|
{{template "repo/issue/view_content/add_reaction" Dict "ctx" $ "ActionURL" (Printf "%s/issues/%d/reactions" $.RepoLink .Issue.Index)}}
|
2021-01-21 21:51:17 +08:00
|
|
|
{{template "repo/issue/view_content/context_menu" Dict "ctx" $ "item" .Issue "delete" false "issue" true "diff" false "IsCommentPoster" $.IsIssuePoster}}
|
2020-10-31 21:17:52 +08:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2015-08-12 17:04:23 +08:00
|
|
|
</div>
|
Improve accessibility for issue comments (#22612) (#23083)
Backport #22612
### Preamble
Gitea is an extremely great and smart solution perfectly suitable for
smaller systems and self-hosted Git-powered setups. However, there is a
group of people who have indredible difficulties in using Gitea,
rendering it useless in many cases. Those people are blind developers
using [screen readers](https://en.wikipedia.org/wiki/Screen_reader).
Unfortunately, the frontend framework is super convoluted, and Go
templates don’t allow accessibility improvements in a straightforward
way. As a blind developer myself, I'm trying to start fixing smaller
accessibility quirks with intention to go deeper and eventually, alone
or not, make Gitea at least mostly accessible for screen reader users.
### What This Fix Does
My blind fellows and me navigate webpages not very similarly to how a
sighted person does it. For instance, we love semantic HTML markup like
headings, lists, tables etc. because our screen readers allow us to jump
by those landmarks with a single keypress.
Currently in Gitea issue comments are not marked up with headings. I'm
trying to fix this by adding an appropriate
[ARIA](https://www.w3.org/WAI/standards-guidelines/aria/) role for
comment header and also by enclosing the comment itself in a semantical
article element.
Co-authored-by: Andre Polykanine <ap@oire.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
2023-02-23 16:32:15 +08:00
|
|
|
<div class="ui attached segment comment-body" role="article">
|
2021-05-23 22:14:03 +08:00
|
|
|
<div class="render-content markup" {{if or $.Permission.IsAdmin $.HasIssuesOrPullsWritePermission $.IsIssuePoster}}data-can-edit="true"{{end}}>
|
2015-12-08 06:30:52 +08:00
|
|
|
{{if .Issue.RenderedContent}}
|
|
|
|
|
{{.Issue.RenderedContent|Str2html}}
|
|
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<span class="no-content">{{.locale.Tr "repo.issues.no_content"}}</span>
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
2015-08-12 17:04:23 +08:00
|
|
|
</div>
|
2023-02-19 12:06:14 +08:00
|
|
|
<div id="issue-{{.Issue.ID}}-raw" class="raw-content gt-hidden">{{.Issue.Content}}</div>
|
|
|
|
|
<div class="edit-content-zone gt-hidden" data-write="issue-{{.Issue.ID}}-write" data-preview="issue-{{.Issue.ID}}-preview" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/content" data-context="{{.RepoLink}}" data-attachment-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/attachments" data-view-attachment-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/view-attachments"></div>
|
2021-04-11 11:46:37 +08:00
|
|
|
{{if .Issue.Attachments}}
|
|
|
|
|
{{template "repo/issue/view_content/attachments" Dict "ctx" $ "Attachments" .Issue.Attachments "Content" .Issue.RenderedContent}}
|
|
|
|
|
{{end}}
|
2015-08-12 17:04:23 +08:00
|
|
|
</div>
|
2017-12-04 07:14:26 +08:00
|
|
|
{{$reactions := .Issue.Reactions.GroupByType}}
|
|
|
|
|
{{if $reactions}}
|
Improve accessibility for issue comments (#22612) (#23083)
Backport #22612
### Preamble
Gitea is an extremely great and smart solution perfectly suitable for
smaller systems and self-hosted Git-powered setups. However, there is a
group of people who have indredible difficulties in using Gitea,
rendering it useless in many cases. Those people are blind developers
using [screen readers](https://en.wikipedia.org/wiki/Screen_reader).
Unfortunately, the frontend framework is super convoluted, and Go
templates don’t allow accessibility improvements in a straightforward
way. As a blind developer myself, I'm trying to start fixing smaller
accessibility quirks with intention to go deeper and eventually, alone
or not, make Gitea at least mostly accessible for screen reader users.
### What This Fix Does
My blind fellows and me navigate webpages not very similarly to how a
sighted person does it. For instance, we love semantic HTML markup like
headings, lists, tables etc. because our screen readers allow us to jump
by those landmarks with a single keypress.
Currently in Gitea issue comments are not marked up with headings. I'm
trying to fix this by adding an appropriate
[ARIA](https://www.w3.org/WAI/standards-guidelines/aria/) role for
comment header and also by enclosing the comment itself in a semantical
article element.
Co-authored-by: Andre Polykanine <ap@oire.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
2023-02-23 16:32:15 +08:00
|
|
|
<div class="ui attached segment reactions" role="note">
|
2019-12-28 07:43:56 +08:00
|
|
|
{{template "repo/issue/view_content/reactions" Dict "ctx" $ "ActionURL" (Printf "%s/issues/%d/reactions" $.RepoLink .Issue.Index) "Reactions" $reactions}}
|
2017-12-04 07:14:26 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2015-08-12 18:44:09 +08:00
|
|
|
|
2022-08-31 23:58:54 +08:00
|
|
|
{{template "repo/issue/view_content/comments" .}}
|
2015-08-13 23:21:43 +08:00
|
|
|
|
2019-01-24 02:58:38 +08:00
|
|
|
{{if and .Issue.IsPull (not $.Repository.IsArchived)}}
|
2022-08-31 23:58:54 +08:00
|
|
|
{{template "repo/issue/view_content/pull".}}
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
2019-02-19 04:55:04 +08:00
|
|
|
{{if .IsSigned}}
|
2022-08-31 23:58:54 +08:00
|
|
|
{{if and (or .IsRepoAdmin .HasIssuesOrPullsWritePermission (not .Issue.IsLocked)) (not .Repository.IsArchived)}}
|
2020-04-11 06:01:41 +08:00
|
|
|
<div class="timeline-item comment form">
|
|
|
|
|
<a class="timeline-avatar" href="{{.SignedUser.HomeLink}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context .SignedUser}}
|
2019-02-19 04:55:04 +08:00
|
|
|
</a>
|
|
|
|
|
<div class="content">
|
|
|
|
|
<form class="ui segment form" id="comment-form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/comments" method="post">
|
|
|
|
|
{{template "repo/issue/comment_tab" .}}
|
|
|
|
|
{{.CsrfTokenHtml}}
|
|
|
|
|
<input id="status" name="status" type="hidden">
|
2020-05-15 03:15:21 +08:00
|
|
|
<div class="field footer">
|
|
|
|
|
<div class="text right">
|
|
|
|
|
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .DisableStatusChange)}}
|
|
|
|
|
{{if .Issue.IsClosed}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div id="status-button" class="ui green basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.reopen_comment_issue"}}" data-status-val="reopen">
|
|
|
|
|
{{.locale.Tr "repo.issues.reopen_issue"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
|
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
|
|
|
|
|
{{.locale.Tr "repo.issues.close_issue"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2019-02-19 04:55:04 +08:00
|
|
|
{{end}}
|
2022-05-07 20:24:02 +08:00
|
|
|
<button class="ui green button loading-button" tabindex="5">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.create_comment"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</button>
|
|
|
|
|
</div>
|
2019-02-19 04:55:04 +08:00
|
|
|
</div>
|
|
|
|
|
</form>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2022-08-31 23:58:54 +08:00
|
|
|
{{else if .Repository.IsArchived}}
|
2019-07-09 03:18:09 +08:00
|
|
|
<div class="ui warning message">
|
|
|
|
|
{{if .Issue.IsPull}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.archive.pull.nocomment"}}
|
2019-07-09 03:18:09 +08:00
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.archive.issue.nocomment"}}
|
2019-07-09 03:18:09 +08:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
2022-08-31 23:58:54 +08:00
|
|
|
{{end}}
|
2019-02-19 04:55:04 +08:00
|
|
|
{{else}}
|
2019-01-24 02:58:38 +08:00
|
|
|
{{if .Repository.IsArchived}}
|
2015-12-08 06:30:52 +08:00
|
|
|
<div class="ui warning message">
|
2019-01-24 02:58:38 +08:00
|
|
|
{{if .Issue.IsPull}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.archive.pull.nocomment"}}
|
2019-01-24 02:58:38 +08:00
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.archive.issue.nocomment"}}
|
2019-01-24 02:58:38 +08:00
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
2019-01-24 02:58:38 +08:00
|
|
|
{{else}}
|
|
|
|
|
{{if .IsSigned}}
|
2019-06-29 17:18:49 +08:00
|
|
|
{{if .Repository.IsArchived}}
|
2020-04-11 06:01:41 +08:00
|
|
|
<div class="timeline-item comment form">
|
|
|
|
|
<a class="timeline-avatar" href="{{.SignedUser.HomeLink}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 21:37:34 +08:00
|
|
|
{{avatar $.Context .SignedUser}}
|
2019-01-24 02:58:38 +08:00
|
|
|
</a>
|
|
|
|
|
<div class="content">
|
|
|
|
|
<form class="ui segment form" id="comment-form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/comments" method="post">
|
|
|
|
|
{{template "repo/issue/comment_tab" .}}
|
|
|
|
|
{{.CsrfTokenHtml}}
|
|
|
|
|
<input id="status" name="status" type="hidden">
|
2020-05-15 03:15:21 +08:00
|
|
|
<div class="field footer">
|
|
|
|
|
<div class="text right">
|
|
|
|
|
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .DisableStatusChange)}}
|
|
|
|
|
{{if .Issue.IsClosed}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div id="status-button" class="ui green basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.reopen_comment_issue"}}" data-status-val="reopen">
|
|
|
|
|
{{.locale.Tr "repo.issues.reopen_issue"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
|
|
|
|
{{else}}
|
2022-06-28 04:58:46 +08:00
|
|
|
<div id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
|
|
|
|
|
{{.locale.Tr "repo.issues.close_issue"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2019-01-24 02:58:38 +08:00
|
|
|
{{end}}
|
2022-05-07 20:24:02 +08:00
|
|
|
<button class="ui green button loading-button" tabindex="5">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.create_comment"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</button>
|
|
|
|
|
</div>
|
2019-01-24 02:58:38 +08:00
|
|
|
</div>
|
|
|
|
|
</form>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2019-06-29 17:18:49 +08:00
|
|
|
{{end}}
|
2019-01-24 02:58:38 +08:00
|
|
|
{{else}}
|
|
|
|
|
<div class="ui warning message">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{.locale.Tr "repo.issues.sign_in_require_desc" (.SignInLink|Escape) | Safe}}
|
2019-01-24 02:58:38 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
{{end}}
|
2019-02-19 04:55:04 +08:00
|
|
|
{{end}}
|
2015-12-08 06:30:52 +08:00
|
|
|
</ui>
|
2015-08-12 17:04:23 +08:00
|
|
|
</div>
|
|
|
|
|
|
2022-08-31 23:58:54 +08:00
|
|
|
{{template "repo/issue/view_content/sidebar" .}}
|
2015-08-20 04:31:28 +08:00
|
|
|
</div>
|
|
|
|
|
|
2023-02-19 12:06:14 +08:00
|
|
|
<div class="gt-hidden" id="edit-content-form">
|
2015-08-20 04:31:28 +08:00
|
|
|
<div class="ui comment form">
|
2020-05-15 03:15:21 +08:00
|
|
|
<div class="ui top tabular menu">
|
2022-06-28 04:58:46 +08:00
|
|
|
<a class="active write item">{{$.locale.Tr "write"}}</a>
|
2023-02-07 02:09:18 +08:00
|
|
|
<a class="preview item" data-url="{{$.Repository.Link}}/markdown" data-context="{{$.RepoLink}}">{{$.locale.Tr "preview"}}</a>
|
2015-08-20 04:31:28 +08:00
|
|
|
</div>
|
2020-05-15 03:15:21 +08:00
|
|
|
<div class="field">
|
|
|
|
|
<div class="ui bottom active tab write">
|
2022-05-20 10:26:04 +08:00
|
|
|
<textarea tabindex="1" name="content" class="js-quick-submit"></textarea>
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
2021-05-07 16:43:41 +08:00
|
|
|
<div class="ui bottom tab preview markup">
|
2022-06-28 04:58:46 +08:00
|
|
|
{{$.locale.Tr "loading"}}
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
2015-08-20 04:31:28 +08:00
|
|
|
</div>
|
2019-10-15 20:19:32 +08:00
|
|
|
{{if .IsAttachmentEnabled}}
|
2020-10-05 13:49:33 +08:00
|
|
|
<div class="field">
|
|
|
|
|
{{template "repo/upload" .}}
|
2019-10-15 20:19:32 +08:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2020-05-15 03:15:21 +08:00
|
|
|
<div class="field footer">
|
|
|
|
|
<div class="text right edit">
|
2022-06-28 04:58:46 +08:00
|
|
|
<div class="ui basic secondary cancel button" tabindex="3">{{.locale.Tr "repo.issues.cancel"}}</div>
|
|
|
|
|
<div class="ui primary save button" tabindex="2">{{.locale.Tr "repo.issues.save"}}</div>
|
2020-05-15 03:15:21 +08:00
|
|
|
</div>
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
2015-08-20 04:31:28 +08:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
|
2021-01-21 21:51:17 +08:00
|
|
|
{{template "repo/issue/view_content/reference_issue_dialog" .}}
|
|
|
|
|
|
2023-02-19 12:06:14 +08:00
|
|
|
<div class="gt-hidden" id="no-content">
|
2022-06-28 04:58:46 +08:00
|
|
|
<span class="no-content">{{.locale.Tr "repo.issues.no_content"}}</span>
|
2015-12-08 06:30:52 +08:00
|
|
|
</div>
|
2016-12-26 00:19:25 +08:00
|
|
|
|
|
|
|
|
<div class="ui small basic delete modal">
|
|
|
|
|
<div class="ui icon header">
|
2021-03-22 12:04:19 +08:00
|
|
|
{{svg "octicon-trash"}}
|
2022-08-31 23:58:54 +08:00
|
|
|
{{.locale.Tr "repo.branch.delete" .HeadTarget}}
|
2016-12-26 00:19:25 +08:00
|
|
|
</div>
|
|
|
|
|
<div class="content">
|
2022-06-28 04:58:46 +08:00
|
|
|
<p>{{.locale.Tr "repo.branch.delete_desc" | Str2html}}</p>
|
2016-12-26 00:19:25 +08:00
|
|
|
</div>
|
|
|
|
|
{{template "base/delete_modal_actions" .}}
|
2017-03-15 09:10:35 +08:00
|
|
|
</div>
|