From 00703d0f8c712765f944d001ce035614a6a012d2 Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Sun, 17 Nov 2024 20:54:25 -0800
Subject: [PATCH] Strict pagination check

---
 models/issues/comment.go      | 2 +-
 models/issues/issue.go        | 2 +-
 models/issues/reaction.go     | 2 +-
 models/issues/tracked_time.go | 2 +-
 models/user/search.go         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/models/issues/comment.go b/models/issues/comment.go
index 48b8e335d4..6650817e50 100644
--- a/models/issues/comment.go
+++ b/models/issues/comment.go
@@ -1108,7 +1108,7 @@ func FindComments(ctx context.Context, opts *FindCommentsOptions) (CommentList,
 		sess.Join("INNER", "issue", "issue.id = comment.issue_id")
 	}
 
-	if opts.Page != 0 {
+	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, opts)
 	}
 
diff --git a/models/issues/issue.go b/models/issues/issue.go
index 9ccf2859ea..fd89267b84 100644
--- a/models/issues/issue.go
+++ b/models/issues/issue.go
@@ -641,7 +641,7 @@ func (issue *Issue) BlockedByDependencies(ctx context.Context, opts db.ListOptio
 		Where("issue_id = ?", issue.ID).
 		// sort by repo id then created date, with the issues of the same repo at the beginning of the list
 		OrderBy("CASE WHEN issue.repo_id = ? THEN 0 ELSE issue.repo_id END, issue.created_unix DESC", issue.RepoID)
-	if opts.Page != 0 {
+	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, &opts)
 	}
 	err = sess.Find(&issueDeps)
diff --git a/models/issues/reaction.go b/models/issues/reaction.go
index eb7faefc79..11b3c6be20 100644
--- a/models/issues/reaction.go
+++ b/models/issues/reaction.go
@@ -163,7 +163,7 @@ func FindReactions(ctx context.Context, opts FindReactionsOptions) (ReactionList
 		Where(opts.toConds()).
 		In("reaction.`type`", setting.UI.Reactions).
 		Asc("reaction.issue_id", "reaction.comment_id", "reaction.created_unix", "reaction.id")
-	if opts.Page != 0 {
+	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, &opts)
 
 		reactions := make([]*Reaction, 0, opts.PageSize)
diff --git a/models/issues/tracked_time.go b/models/issues/tracked_time.go
index caa582a9fc..ea404d36cd 100644
--- a/models/issues/tracked_time.go
+++ b/models/issues/tracked_time.go
@@ -139,7 +139,7 @@ func (opts *FindTrackedTimesOptions) toSession(e db.Engine) db.Engine {
 
 	sess = sess.Where(opts.ToConds())
 
-	if opts.Page != 0 {
+	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, opts)
 	}
 
diff --git a/models/user/search.go b/models/user/search.go
index 382b6fac2b..6af3389237 100644
--- a/models/user/search.go
+++ b/models/user/search.go
@@ -152,7 +152,7 @@ func SearchUsers(ctx context.Context, opts *SearchUserOptions) (users []*User, _
 
 	sessQuery := opts.toSearchQueryBase(ctx).OrderBy(opts.OrderBy.String())
 	defer sessQuery.Close()
-	if opts.Page != 0 {
+	if opts.Page > 0 {
 		sessQuery = db.SetSessionPagination(sessQuery, opts)
 	}