wxiaoguang
838653d1df
Fix file editor & preview ( #32706 )
...
Fix a regression caused by jQuery removal (`renderPreviewPanelContent`)
And simplify the file editor, it doesn't need to be that complex. And
remove jQuery code.
2024-12-04 09:26:54 +00:00
wxiaoguang
c9e582c6b6
Refactor markdown editor and use it for milestone description editor ( #32688 )
...
Refactor markdown editor to clarify its "preview" behavior and remove
jQuery code.
Close #15045
---------
Co-authored-by: silverwind <me@silverwind.io>
2024-12-04 02:11:34 +00:00
wxiaoguang
2f43536c3e
Fix issue title rendering and refactor legacy function names ( #32703 )
...
Fix #32700 , regression of recent markup refactoring
And by the way, clarify many legacy problems:
1. Some "RenderXxx" functions do not really "render", they only call "post processors"
2. Merge "RenderEmoji | RenderCodeBlock", they are all for "simple issue title"
2024-12-04 01:39:33 +00:00
yp05327
690d07470c
Fix word overflow in file search page ( #32695 )
2024-12-03 16:52:25 +00:00
Kerwin Bryant
576e31ae3b
Add "View all branches/tags" entry to Branch Selector ( #32653 )
...
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-02 20:19:27 +00:00
wxiaoguang
13fbab5cf4
Remove all "floated" CSS styles ( #32691 )
...
flex but don't float
diff with ignoring spaces :
https://github.com/go-gitea/gitea/pull/32691/files?diff=split&w=1
related pages:
### admin users
### milestone
### user account setting
2024-12-03 03:54:33 +08:00
Kerwin Bryant
9a494af125
Optimize the styling of icon buttons within file-header-right ( #32675 )
...
Optimize partial layout and styling to achieve uniformity and
consistency.
Some buttons's structure is `<a><span><svg/></span></a>`, while others
buttons's structure is `<a><svg/></a>`. Additionally, some buttons have
icons that are **14** in size, while others have icons that are **16**.
Now, the layout has been unified to structure `<a><svg/></a>`, and the
icon size for all buttons has been standardized to the default size of
**16**.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-02 22:36:16 +08:00
metiftikci
2824ae2128
fix: show tag name on branch/tag selector if repo shown from tag ref ( #32689 )
2024-12-02 13:34:16 +00:00
wxiaoguang
e3e32605a1
Refactor RepoBranchTagSelector ( #32681 )
2024-12-02 01:41:32 +00:00
Simon Pistache
2abef971dc
fix( #32667 ): 🐛 Fixe a keystring misuse and refactor duplicates keystrings ( #32668 )
...
- Fixes a translation keystring misuse where the string 'open
milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones'
keystrings on the sidebar of an issue, reusing the ones on the issues
filter and action bars.
- Closes #32667
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-01 10:14:56 +08:00
6543
846f618716
Add priority to protected branch ( #32286 )
...
## Solves
Currently for rules to re-order them you have to alter the creation
date. so you basicly have to delete and recreate them in the right
order. This is more than just inconvinient ...
## Solution
Add a new col for prioritization
## Demo WebUI Video
https://github.com/user-attachments/assets/92182a31-9705-4ac5-b6e3-9bb74108cbd1
---
*Sponsored by Kithara Software GmbH*
2024-11-27 05:41:06 +01:00
Kerwin Bryant
25cacaf0aa
Fixed Issue of Review Menu Shown Behind ( #32631 )
...
Fixed #31144
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-26 09:24:56 +08:00
Yarden Shoham
f2a9951741
Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar ( #32570 )
...
We make sure the user cards are updated
- Fixes https://github.com/go-gitea/gitea/issues/32561
I also removed `ctx.Data["PageIsWatchers"] = true` and
`ctx.Data["PageIsStargazers"] = true` as they are not used anywhere.
# Before
# After
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-11-22 18:51:51 +00:00
Kerwin Bryant
bc7d599030
Fix issues with inconsistent spacing in areas ( #32607 )
...
Fix issues with inconsistent spacing in areas where the branch_dropdown
component is used.
before:
after:
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-22 06:12:50 +00:00
Kerwin Bryant
81ac8d914c
Style unification for the issue_management area ( #32605 )
...
Style unification for the issue_management area (consistent across the
layout
before:
after:
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-22 04:33:31 +00:00
Lunny Xiao
a175f9805c
Add line-through for deleted branch on pull request view page ( #32500 )
...
Base branch deleted
branch deleted comment
Head branch deleted
2024-11-21 17:04:18 +00:00
wxiaoguang
a32cfb2a8d
Fix issue sidebar regression ( #32598 )
2024-11-22 00:38:34 +08:00
silverwind
d11f8d24b0
Add 'Copy path' button to file view ( #32584 )
...
Also adds a tooltip which is replicated to the same button in the diff
box. Fixes: https://github.com/go-gitea/gitea/issues/32583
2024-11-21 04:03:17 +00:00
wxiaoguang
07373f1d5d
Improve issue sidebar UI ( #32587 )
...
1. remove duplicate dividers
2. align reviewer items
3. merge & remove unused CSS styles
Before:
<details>
</details>
After:
<details>
</details>
2024-11-21 03:31:54 +00:00
a1012112796
23d0f9083e
make search box in issue sidebar dropdown list always show when scrolling ( #32576 )
...
as title, replace #31597 after #32460
---------
Signed-off-by: a1012112796 <1012112796@qq.com>
2024-11-21 09:23:50 +08:00
Lunny Xiao
4f879a00df
Refactor find forks and fix possible bugs that weak permissions check ( #32528 )
...
- Move models/GetForks to services/FindForks
- Add doer as a parameter of FindForks to check permissions
- Slight performance optimization for get forks API with batch loading
of repository units
- Add tests for forking repository to organizations
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-18 03:06:25 +00:00
wxiaoguang
5eebe1dc5f
Fix and refactor markdown rendering ( #32522 )
2024-11-16 08:41:44 +00:00
charles
e546480d0a
Fix large image overflow in comment page ( #31740 )
...
Close #31709
52px is calculate by avatar size in
templates\repo\issue\view_content\comments.tmpl
```html
<img src="{{.Poster.AvatarLink $.Context}}" width="40" height="40">
```
+
```css
.ui.comments .comment > .avatar ~ .content {
margin-left: 12px;
}
```
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-15 18:34:54 +00:00
wxiaoguang
21f7db2124
Fix incorrect project page CSS class ( #32510 )
...
Otherwise milestone JS would run on this page and cause errors
2024-11-15 01:30:26 +00:00
wxiaoguang
a928739456
Refactor sidebar assignee&milestone&project selectors ( #32465 )
...
Follow #32460
Now the code could be much clearer than before and easier to maintain. A
lot of legacy code is removed.
Manually tested.
This PR is large enough, that fine tunes could be deferred to the future if
there is no bug found or design problem.
Screenshots:
<details>
</details>
2024-11-11 04:07:54 +08:00
wxiaoguang
58c634b854
Refactor sidebar label selector ( #32460 )
...
Introduce `issueSidebarLabelsData` to handle all sidebar labels related data.
2024-11-10 08:26:42 +00:00
Calvin K
18aeca5320
Add reviewers selection to new pull request ( #32403 )
...
Users could add reviewers when creating new PRs.
---------
Co-authored-by: splitt3r <splitt3r@users.noreply.github.com>
Co-authored-by: Sebastian Sauer <sauer.sebastian@gmail.com>
Co-authored-by: bb-ben <70356237+bboerben@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-11-09 04:48:31 +00:00
wxiaoguang
d80f99ef04
Fix issue sidebar ( #32455 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Fix #32453
Major changes:
* revert the `<div class="divider"></div>` in
`templates/repo/issue/branch_selector_field.tmpl` (it was removed by
mistake in ##32444)
* remove incorrect `<div class="inline field">` in
`templates/repo/issue/sidebar/allow_maintainer_edit.tmpl`
* use `gt-ellipsis` to replace the "title" class in the dependency list,
then `.repository .issue-content-right .ui.list .title` could be removed
* remove the "relaxed" from dependency list, then there is no padding,
then `.repository .issue-content-right .ui.list .dependency` could be
removed (`white-space` doesn't have effect either because there is
`gt-ellipsis`)
* remove dead code `.repository .issue-content-right #deadlineForm input
`
The fixed UI should be the same as before.
2024-11-09 01:55:32 +08:00
wxiaoguang
623a2d41cc
Refactor issue page info ( #32445 )
...
Fix a longstanding TODO since 2021 (#14826 ) / 2018 (#2531 )
2024-11-08 02:21:13 +00:00
wxiaoguang
028e612094
Split issue sidebar into small templates ( #32444 )
...
Only move code
2024-11-08 01:44:20 +00:00
wxiaoguang
145e266987
Support quote selected comments to reply ( #32431 )
...
Many existing tests were quite hacky, these could be improved later.
<details>
</details>
2024-11-07 03:57:07 +00:00
Lunny Xiao
24b83ff63e
Fix milestone deadline and date related problems ( #32339 )
...
Use zero instead of 9999-12-31 for deadline
Fix #32291
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
2024-11-05 07:46:40 +00:00
wxiaoguang
4a469c8e1b
Refactor template ctx and render utils ( #32422 )
...
Clean up the templates
2024-11-05 14:04:26 +08:00
wxiaoguang
b068dbd40e
Refactor DateUtils and merge TimeSince ( #32409 )
...
Follow #32383 and #32402
2024-11-04 11:30:00 +00:00
wxiaoguang
259811617b
Replace DateTime with proper functions ( #32402 )
...
Follow #32383
This PR cleans up the "Deadline" usages in templates, make them call
`ParseLegacy` first to get a `Time` struct then display by `DateUtils`.
Now it should be pretty clear how "deadline string" works, it makes it
possible to do further refactoring and correcting.
2024-11-02 21:04:53 +00:00
wxiaoguang
fec6b3d500
Replace DateTime with DateUtils ( #32383 )
2024-11-02 04:08:28 +00:00
Rowan Bohde
1cd3f69859
remove unused call to $.HeadRepo in view_title template ( #32317 )
...
This is only populated in
[`ParseCompareInfo`](https://github.com/search?q=repo%3Ago-gitea%2Fgitea%20%20.Data%5B%22HeadRepo%22%5D&type=code )
which is called in two handlers:
*
[`CompareAndPullRequestPost`](9206fbb55f/routers/web/repo/pull.go (L1246)9206fbb55f/routers/web/repo/compare.go (L706)
2024-10-30 13:12:48 +08:00
Tim
de2ad2e1b1
Make admins adhere to branch protection rules ( #32248 )
...
This introduces a new flag `BlockAdminMergeOverride` on the branch
protection rules that prevents admins/repo owners from bypassing branch
protection rules and merging without approvals or failing status checks.
Fixes #17131
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
2024-10-23 12:39:43 +08:00
Ehsan Shirvanian
8bee7fcf7e
update git book link to v2 ( #32221 )
...
Fix the dead link `https://git-scm.com/book/en/Git-Basics-Getting-a-Git-Repository ` for
empty repositories to help how to clone the repository
to `https://git-scm.com/book/en/v2/Git-Basics-Getting-a-Git-Repository `
which is v2 of the git book. This also updates download git links
2024-10-09 13:04:34 +08:00
Lunny Xiao
a989404e23
Fix javascript error when an anonymous user visiting migration page ( #32144 )
...
This PR fixes javascript errors when an anonymous user visits the
migration page.
It also makes task view checking more restrictive.
The router moved from `/user/task/{id}/status` to
`/username/reponame/-/migrate/status` because it's a migrate status.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-02 04:37:16 +00:00
yp05327
70b7df0e5e
Support repo license ( #24872 )
...
Close #278
Close #24076
## Solutions:
- Use
[google/licenseclassifier](https://github.com/google/licenseclassifier/ )
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[go-license-detector](https://github.com/go-enry/go-license-detector ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[google/licenseclassifier](https://github.com/google/licenseclassifier/ ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1576092178
- Generate License Convert Name List to avoid import license templates
with same contents
Gitea automatically get latest license data from[
spdx/license-list-data](https://github.com/spdx/license-list-data ).
But unfortunately, some license templates have same contents. #20915
[click here to see the
list](https://github.com/go-gitea/gitea/pull/24872#issuecomment-1584141684 )
So we will generate a list of these license templates with same contents
and create a new file to save the result when using `make
generate-license`. (Need to decide the save path)
- Save License info into a new table `repo_license`
Can easily support searching repo by license in the future.
## Screen shot
Single License:
Multiple Licenses:
Triggers:
- [x] Push commit to default branch
- [x] Create repo
- [x] Mirror repo
- [x] When Default Branch is changed, licenses should be updated
Todo:
- [x] Save Licenses info in to DB when there's a change to license file
in the commit
- [x] DB Migration
- [x] A nominal test?
- [x] Select which library to
use(https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167 )
- [x] API Support
- [x] Add repo license table
- ~Select license in settings if there are several licenses(Not
recommended)~
- License board(later, not in this PR)
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <m.huber@kithara.com>
Co-authored-by: a1012112796 <1012112796@qq.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2024-10-01 15:25:08 -04:00
Lunny Xiao
e2f365b55c
Display head branch more comfortable on pull request view ( #32000 )
...
This PR do some minor improvements for head branch display on pull
request view UI.
- [x] Remove the link if the head branch has been deleted with a
tooltip, so that users will not result in a 404 page
- [x] Display a label if this pull request is an agit based one.
2024-09-24 04:14:57 +00:00
Lunny Xiao
2c6fa6c1e0
Fix template bug of pull request view ( #32072 )
...
Caused by #31924
2024-09-24 03:02:42 +00:00
Lunny Xiao
6eb5950835
Allow set branch protection in an empty repository ( #32095 )
2024-09-24 02:06:28 +00:00
cloudchamb3r
e1f0598c8f
Fix Bug in Issue/pulls list ( #32081 )
...
fix #32080
## After
### for opened issues
<img width="1199" alt="Screenshot 2024-09-19 at 6 29 31 PM"
src="https://github.com/user-attachments/assets/86cf48ad-5e4b-4dcb-8abe-4d7fd74e0aec ">
### for closed issues
<img width="1208" alt="Screenshot 2024-09-19 at 6 29 37 PM"
src="https://github.com/user-attachments/assets/a16bc545-bfcf-49a4-be52-3e7334910482 ">
### for all issues
<img width="1340" alt="Screenshot 2024-09-20 at 12 07 12 PM"
src="https://github.com/user-attachments/assets/b2309c8f-e59d-44e9-ae3b-bf54e1196169 ">
2024-09-24 01:09:57 +08:00
Lunny Xiao
9e0db1b646
Fix rename branch permission bug ( #32066 )
...
The previous implementation requires admin permission to rename branches
which should be write permission.
Fix #31993
2024-09-22 18:08:27 +00:00
Bruno Sofiato
7dde3e6489
Included tag search capabilities ( #32045 )
...
Resolves #31998
The first screenshot shows the tag page without any filter being
applied:
The second one, shows the page when the given filter returns no tag:
The last one shows a single tag being filtered:
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
2024-09-18 02:33:11 +08:00
Zettat123
def1c9670b
Support migration from AWS CodeCommit ( #31981 )
...
This PR adds support for migrating repos from [AWS
CodeCommit](https://docs.aws.amazon.com/codecommit/latest/userguide/welcome.html ).
The access key ID and secret access key are required to get repository
information and pull requests. And [HTTPS Git
credentials](https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-gc.html )
are required to clone the repository.
<img
src="https://github.com/user-attachments/assets/82ecb2d0-8d43-42b0-b5af-f5347a13b9d0 "
width="680" />
The AWS CodeCommit icon is from [AWS Architecture
Icons](https://aws.amazon.com/architecture/icons/ ).
<img
src="https://github.com/user-attachments/assets/3c44d21f-d753-40f5-9eae-5d3589e0d50d "
width="320" />
2024-09-11 07:49:42 +08:00
william-allspice
e9c64f41a6
Distinguish official vs non-official reviews, add tool tips, and upgr… ( #31924 )
...
This Pull Request is a follow up to
https://github.com/go-gitea/gitea/pull/31886 :
1. Adds a UI indicator between official (green) and unofficial (grey)
approved pull requests on the Pull Request page (as suggested by
@kdumontnu )
2. Adds tooltips adding clarity to the type and status of a review on
the Pull Request page (as suggested by @kdumontnu)
3. Updates text adding more clarity to required approvals (as suggested
by @kdumontnu)
4. Updates text on the branch settings page explaining what branch
approval limitations (as suggested by @yp05327)
Official approval:
<img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM"
src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696 ">
Unofficial approval:
<img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM"
src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7 ">
Rejected approval:
<img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM"
src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617 ">
Stale approval:
<img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM"
src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77 ">
Requested review tooltip:
<img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM"
src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2 ">
Updated text for approvals:
<img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM"
src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c ">
Updated text for allowlisted/whitelisted approvals:
<img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM"
src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1 ">
Protected branch settings text:
<img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM"
src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776 ">
Comments list:
<img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM"
src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2 ">
---------
Co-authored-by: Kyle D. <kdumontnu@gmail.com>
2024-09-06 06:40:02 +00:00
Denys Konovalov
83f37f6302
Remove urls from translations ( #31950 )
...
Part of #27700
Removes all URLs from translation strings to easy up changing them in
the future and to exclude people injecting malicious URLs through
translations. First measure as long as #24402 is out of scope.
2024-09-02 18:36:24 +00:00
