mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-05 09:49:37 +08:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
91 lines
3.0 KiB
Go
91 lines
3.0 KiB
Go
// Copyright 2012 Google Inc. All Rights Reserved.
|
|
// Copyright 2014 The Macaron Authors
|
|
// Copyright 2020 The Gitea Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package context
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
key = "quay"
|
|
userID = "12345678"
|
|
actionID = "POST /form"
|
|
)
|
|
|
|
var (
|
|
now = time.Now()
|
|
oneMinuteFromNow = now.Add(1 * time.Minute)
|
|
)
|
|
|
|
func Test_ValidToken(t *testing.T) {
|
|
t.Run("Validate token", func(t *testing.T) {
|
|
tok := generateTokenAtTime(key, userID, actionID, now)
|
|
assert.True(t, validTokenAtTime(tok, key, userID, actionID, oneMinuteFromNow))
|
|
assert.True(t, validTokenAtTime(tok, key, userID, actionID, now.Add(Timeout-1*time.Nanosecond)))
|
|
assert.True(t, validTokenAtTime(tok, key, userID, actionID, now.Add(-1*time.Minute)))
|
|
})
|
|
}
|
|
|
|
// Test_SeparatorReplacement tests that separators are being correctly substituted
|
|
func Test_SeparatorReplacement(t *testing.T) {
|
|
t.Run("Test two separator replacements", func(t *testing.T) {
|
|
assert.NotEqual(t, generateTokenAtTime("foo:bar", "baz", "wah", now),
|
|
generateTokenAtTime("foo", "bar:baz", "wah", now))
|
|
})
|
|
}
|
|
|
|
func Test_InvalidToken(t *testing.T) {
|
|
t.Run("Test invalid tokens", func(t *testing.T) {
|
|
invalidTokenTests := []struct {
|
|
name, key, userID, actionID string
|
|
t time.Time
|
|
}{
|
|
{"Bad key", "foobar", userID, actionID, oneMinuteFromNow},
|
|
{"Bad userID", key, "foobar", actionID, oneMinuteFromNow},
|
|
{"Bad actionID", key, userID, "foobar", oneMinuteFromNow},
|
|
{"Expired", key, userID, actionID, now.Add(Timeout)},
|
|
{"More than 1 minute from the future", key, userID, actionID, now.Add(-1*time.Nanosecond - 1*time.Minute)},
|
|
}
|
|
|
|
tok := generateTokenAtTime(key, userID, actionID, now)
|
|
for _, itt := range invalidTokenTests {
|
|
assert.False(t, validTokenAtTime(tok, itt.key, itt.userID, itt.actionID, itt.t))
|
|
}
|
|
})
|
|
}
|
|
|
|
// Test_ValidateBadData primarily tests that no unexpected panics are triggered during parsing
|
|
func Test_ValidateBadData(t *testing.T) {
|
|
t.Run("Validate bad data", func(t *testing.T) {
|
|
badDataTests := []struct {
|
|
name, tok string
|
|
}{
|
|
{"Invalid Base64", "ASDab24(@)$*=="},
|
|
{"No delimiter", base64.URLEncoding.EncodeToString([]byte("foobar12345678"))},
|
|
{"Invalid time", base64.URLEncoding.EncodeToString([]byte("foobar:foobar"))},
|
|
}
|
|
|
|
for _, bdt := range badDataTests {
|
|
assert.False(t, validTokenAtTime(bdt.tok, key, userID, actionID, oneMinuteFromNow))
|
|
}
|
|
})
|
|
}
|