mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-16 02:09:18 +08:00
e8b6d28ab9
Backport #29254 The tests on migration tests failed but CI reports successfully https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141 This PR will fix the bug on migrations and also the CI hidden behaviour. The reason is on the Makefile `GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will return the error exit code. But `for pkg in $(shell $(GO) list code.gitea.io/gitea/models/migrations/...); do \ GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \ done` will not work. --------- Co-authored-by: Giteabot <teabot@gitea.io>
81 lines
2.2 KiB
Go
81 lines
2.2 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_16 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/migrations/base"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_AddRepoIDForAttachment(t *testing.T) {
|
|
type Attachment struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UUID string `xorm:"uuid UNIQUE"`
|
|
IssueID int64 `xorm:"INDEX"` // maybe zero when creating
|
|
ReleaseID int64 `xorm:"INDEX"` // maybe zero when creating
|
|
UploaderID int64 `xorm:"INDEX DEFAULT 0"`
|
|
}
|
|
|
|
type Issue struct {
|
|
ID int64
|
|
RepoID int64
|
|
}
|
|
|
|
type Release struct {
|
|
ID int64
|
|
RepoID int64
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferrable := base.PrepareTestEnv(t, 0, new(Attachment), new(Issue), new(Release))
|
|
defer deferrable()
|
|
if x == nil || t.Failed() {
|
|
return
|
|
}
|
|
|
|
// Run the migration
|
|
if err := AddRepoIDForAttachment(x); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
type NewAttachment struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UUID string `xorm:"uuid UNIQUE"`
|
|
RepoID int64 `xorm:"INDEX"` // this should not be zero
|
|
IssueID int64 `xorm:"INDEX"` // maybe zero when creating
|
|
ReleaseID int64 `xorm:"INDEX"` // maybe zero when creating
|
|
UploaderID int64 `xorm:"INDEX DEFAULT 0"`
|
|
}
|
|
|
|
var issueAttachments []*NewAttachment
|
|
err := x.Table("attachment").Where("issue_id > 0").Find(&issueAttachments)
|
|
assert.NoError(t, err)
|
|
for _, attach := range issueAttachments {
|
|
assert.Greater(t, attach.RepoID, int64(0))
|
|
assert.Greater(t, attach.IssueID, int64(0))
|
|
var issue Issue
|
|
has, err := x.ID(attach.IssueID).Get(&issue)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.EqualValues(t, attach.RepoID, issue.RepoID)
|
|
}
|
|
|
|
var releaseAttachments []*NewAttachment
|
|
err = x.Table("attachment").Where("release_id > 0").Find(&releaseAttachments)
|
|
assert.NoError(t, err)
|
|
for _, attach := range releaseAttachments {
|
|
assert.Greater(t, attach.RepoID, int64(0))
|
|
assert.Greater(t, attach.ReleaseID, int64(0))
|
|
var release Release
|
|
has, err := x.ID(attach.ReleaseID).Get(&release)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.EqualValues(t, attach.RepoID, release.RepoID)
|
|
}
|
|
}
|