mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-24 19:19:39 +08:00
16adaaeaa3
A consequence of forcibly setting the RoutePath to the escaped url is that the auto routing to endpoints without terminal slashes fails (Causing #18060.) This failure raises the possibility that forcibly setting the RoutePath causes other unexpected behaviors too. Therefore, instead we should simply pre-escape the URL in the process registering handler. Then the request URL will be properly escaped for all the following calls. Fix #17938 Fix #18060 Replace #18062 Replace #17997 Signed-off-by: Andrew Thornton <art27@cantab.net>
176 lines
4.8 KiB
Go
176 lines
4.8 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package integrations
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"path"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLinksNoLogin(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
var links = []string{
|
|
"/explore/repos",
|
|
"/explore/repos?q=test&tab=",
|
|
"/explore/users",
|
|
"/explore/users?q=test&tab=",
|
|
"/explore/organizations",
|
|
"/explore/organizations?q=test&tab=",
|
|
"/",
|
|
"/user/sign_up",
|
|
"/user/login",
|
|
"/user/forgot_password",
|
|
"/api/swagger",
|
|
"/user2/repo1",
|
|
"/user2/repo1/",
|
|
"/user2/repo1/projects",
|
|
"/user2/repo1/projects/1",
|
|
"/assets/img/404.png",
|
|
"/assets/img/500.png",
|
|
}
|
|
|
|
for _, link := range links {
|
|
req := NewRequest(t, "GET", link)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
}
|
|
}
|
|
|
|
func TestRedirectsNoLogin(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
var redirects = map[string]string{
|
|
"/user2/repo1/commits/master": "/user2/repo1/commits/branch/master",
|
|
"/user2/repo1/src/master": "/user2/repo1/src/branch/master",
|
|
"/user2/repo1/src/master/file.txt": "/user2/repo1/src/branch/master/file.txt",
|
|
"/user2/repo1/src/master/directory/file.txt": "/user2/repo1/src/branch/master/directory/file.txt",
|
|
"/user/avatar/Ghost/-1": "/assets/img/avatar_default.png",
|
|
"/api/v1/swagger": "/api/swagger",
|
|
}
|
|
for link, redirectLink := range redirects {
|
|
req := NewRequest(t, "GET", link)
|
|
resp := MakeRequest(t, req, http.StatusFound)
|
|
assert.EqualValues(t, path.Join(setting.AppSubURL, redirectLink), test.RedirectURL(resp))
|
|
}
|
|
}
|
|
|
|
func TestNoLoginNotExist(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
var links = []string{
|
|
"/user5/repo4/projects",
|
|
"/user5/repo4/projects/3",
|
|
}
|
|
|
|
for _, link := range links {
|
|
req := NewRequest(t, "GET", link)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
}
|
|
}
|
|
|
|
func testLinksAsUser(userName string, t *testing.T) {
|
|
var links = []string{
|
|
"/explore/repos",
|
|
"/explore/repos?q=test&tab=",
|
|
"/explore/users",
|
|
"/explore/users?q=test&tab=",
|
|
"/explore/organizations",
|
|
"/explore/organizations?q=test&tab=",
|
|
"/",
|
|
"/user/forgot_password",
|
|
"/api/swagger",
|
|
"/issues",
|
|
"/issues?type=your_repositories&repos=[0]&sort=&state=open",
|
|
"/issues?type=assigned&repos=[0]&sort=&state=open",
|
|
"/issues?type=your_repositories&repos=[0]&sort=&state=closed",
|
|
"/issues?type=assigned&repos=[]&sort=&state=closed",
|
|
"/issues?type=assigned&sort=&state=open",
|
|
"/issues?type=created_by&repos=[1,2]&sort=&state=closed",
|
|
"/issues?type=created_by&repos=[1,2]&sort=&state=open",
|
|
"/pulls",
|
|
"/pulls?type=your_repositories&repos=[2]&sort=&state=open",
|
|
"/pulls?type=assigned&repos=[]&sort=&state=open",
|
|
"/pulls?type=created_by&repos=[0]&sort=&state=open",
|
|
"/pulls?type=your_repositories&repos=[0]&sort=&state=closed",
|
|
"/pulls?type=assigned&repos=[0]&sort=&state=closed",
|
|
"/pulls?type=created_by&repos=[0]&sort=&state=closed",
|
|
"/milestones",
|
|
"/milestones?sort=mostcomplete&state=closed",
|
|
"/milestones?type=your_repositories&sort=mostcomplete&state=closed",
|
|
"/milestones?sort=&repos=[1]&state=closed",
|
|
"/milestones?sort=&repos=[1]&state=open",
|
|
"/milestones?repos=[0]&sort=mostissues&state=open",
|
|
"/notifications",
|
|
"/repo/create",
|
|
"/repo/migrate",
|
|
"/org/create",
|
|
"/user2",
|
|
"/user2?tab=stars",
|
|
"/user2?tab=activity",
|
|
"/user/settings",
|
|
"/user/settings/account",
|
|
"/user/settings/security",
|
|
"/user/settings/security/two_factor/enroll",
|
|
"/user/settings/keys",
|
|
"/user/settings/organization",
|
|
"/user/settings/repos",
|
|
}
|
|
|
|
session := loginUser(t, userName)
|
|
for _, link := range links {
|
|
req := NewRequest(t, "GET", link)
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
}
|
|
|
|
reqAPI := NewRequestf(t, "GET", "/api/v1/users/%s/repos", userName)
|
|
respAPI := MakeRequest(t, reqAPI, http.StatusOK)
|
|
|
|
var apiRepos []*api.Repository
|
|
DecodeJSON(t, respAPI, &apiRepos)
|
|
|
|
var repoLinks = []string{
|
|
"",
|
|
"/issues",
|
|
"/pulls",
|
|
"/commits/branch/master",
|
|
"/graph",
|
|
"/settings",
|
|
"/settings/collaboration",
|
|
"/settings/branches",
|
|
"/settings/hooks",
|
|
// FIXME: below links should return 200 but 404 ??
|
|
//"/settings/hooks/git",
|
|
//"/settings/hooks/git/pre-receive",
|
|
//"/settings/hooks/git/update",
|
|
//"/settings/hooks/git/post-receive",
|
|
"/settings/keys",
|
|
"/releases",
|
|
"/releases/new",
|
|
//"/wiki/_pages",
|
|
"/wiki/?action=_new",
|
|
}
|
|
|
|
for _, repo := range apiRepos {
|
|
for _, link := range repoLinks {
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/%s/%s%s", userName, repo.Name, link))
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestLinksLogin(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
testLinksAsUser("user2", t)
|
|
}
|