mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-25 03:29:40 +08:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
60 lines
2.4 KiB
Handlebars
60 lines
2.4 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository file editor edit">
|
|
{{template "repo/header" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<form class="ui edit form" method="post" action="{{.RepoLink}}/_diffpatch/{{.BranchName | PathEscapeSegments}}">
|
|
{{.CsrfTokenHtml}}
|
|
<input type="hidden" name="last_commit" value="{{.last_commit}}">
|
|
<input type="hidden" name="page_has_posted" value="{{.PageHasPosted}}">
|
|
<div class="ui secondary menu">
|
|
<div class="fitted item treepath">
|
|
<div class="ui breadcrumb field {{if .Err_TreePath}}error{{end}}">
|
|
{{.locale.Tr "repo.editor.patching"}}
|
|
<a class="section" href="{{$.RepoLink}}">{{.Repository.FullName}}</a>
|
|
<div class="divider">:</div>
|
|
<a class="section" href="{{$.BranchLink}}">{{.BranchName}}</a>
|
|
<span>{{.locale.Tr "repo.editor.or"}} <a href="{{$.BranchLink}}">{{.locale.Tr "repo.editor.cancel_lower"}}</a></span>
|
|
<input type="hidden" id="tree_path" name="tree_path" value="" required>
|
|
<input id="file-name" type="hidden" value="diff.patch">
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="field">
|
|
<div class="ui top attached tabular menu" data-write="write">
|
|
<a class="active item" data-tab="write">{{svg "octicon-code" 16 "gt-mr-2"}}{{.locale.Tr "repo.editor.new_patch"}}</a>
|
|
</div>
|
|
<div class="ui bottom attached active tab segment" data-tab="write">
|
|
<textarea id="edit_area" name="content" class="gt-hidden" data-id="repo-{{.Repository.Name}}-patch"
|
|
data-context="{{.RepoLink}}"
|
|
data-line-wrap-extensions="{{.LineWrapExtensions}}">
|
|
{{.FileContent}}</textarea>
|
|
<div class="editor-loading is-loading"></div>
|
|
</div>
|
|
</div>
|
|
{{template "repo/editor/commit_form" .}}
|
|
</form>
|
|
</div>
|
|
|
|
<div class="ui small basic modal" id="edit-empty-content-modal">
|
|
<div class="ui icon header">
|
|
<i class="file icon"></i>
|
|
{{.locale.Tr "repo.editor.commit_empty_file_header"}}
|
|
</div>
|
|
<div class="center content">
|
|
<p>{{.locale.Tr "repo.editor.commit_empty_file_text"}}</p>
|
|
</div>
|
|
<div class="actions">
|
|
<button class="ui red basic inverted cancel button">
|
|
{{svg "octicon-x"}}
|
|
{{.locale.Tr "repo.editor.cancel"}}
|
|
</button>
|
|
<button class="ui green basic inverted ok button">
|
|
{{svg "fontawesome-save"}}
|
|
{{.locale.Tr "repo.editor.commit_changes"}}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{{template "base/footer" .}}
|