mirror/leveldb
1
0
Fork 0
mirror of https://github.com/google/leveldb.git synced 2025-06-07 18:02:42 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix clang thread-safety-pointer warnings

Browse Source 
Clang's -Wthread-safety-pointer warnings will become part of -Wthread-safety in
some future release. Add missing annotations for functions that pass the
address of guarded members. No functional change. Fixes the following warnings:

util/cache.cc:220:17: warning: passing pointer to variable 'in_use_' requires holding mutex 'mutex_' [-Wthread-safety-pointer]
  220 |     LRU_Append(&in_use_, e);
      |                 ^
util/cache.cc:235:17: warning: passing pointer to variable 'lru_' requires holding mutex 'mutex_' [-Wthread-safety-pointer]
  235 |     LRU_Append(&lru_, e);
This commit is contained in:
Cory Fields 2025-05-28 20:15:43 +00:00
parent ac691084fd
commit 9b03d2334c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/cache.cc
View File

@ -172,8 +172,8 @@ class LRUCache {
private: private:
void LRU_Remove(LRUHandle* e); void LRU_Remove(LRUHandle* e);
void LRU_Append(LRUHandle* list, LRUHandle* e); void LRU_Append(LRUHandle* list, LRUHandle* e);
void Ref(LRUHandle* e); void Ref(LRUHandle* e) EXCLUSIVE_LOCKS_REQUIRED(mutex_);
void Unref(LRUHandle* e); void Unref(LRUHandle* e) EXCLUSIVE_LOCKS_REQUIRED(mutex_);
bool FinishErase(LRUHandle* e) EXCLUSIVE_LOCKS_REQUIRED(mutex_); bool FinishErase(LRUHandle* e) EXCLUSIVE_LOCKS_REQUIRED(mutex_);
// Initialized before use. // Initialized before use.