From 1c5fce75186ae792b76d055223cd0a70ac7370b0 Mon Sep 17 00:00:00 2001 From: Maxim Dounin Date: Fri, 1 Feb 2013 14:40:19 +0000 Subject: [PATCH] FastCGI: fixed wrong connection close with fastcgi_keep_conn. With fastcgi_keep_conn it was possible that connection was closed after FCGI_STDERR record with zero padding and without any further data read yet. This happended as f->state was set to ngx_http_fastcgi_st_padding and then "break" happened, resulting in p->length being set to f->padding, i.e. 0 (which in turn resulted in connection close). Fix is to make sure we continue the loop after f->state is set. --- src/http/modules/ngx_http_fastcgi_module.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/http/modules/ngx_http_fastcgi_module.c b/src/http/modules/ngx_http_fastcgi_module.c index 123125a86..5e8ef40c1 100644 --- a/src/http/modules/ngx_http_fastcgi_module.c +++ b/src/http/modules/ngx_http_fastcgi_module.c @@ -1788,10 +1788,6 @@ ngx_http_fastcgi_input_filter(ngx_event_pipe_t *p, ngx_buf_t *buf) "FastCGI sent in stderr: \"%*s\"", m + 1 - msg, msg); - if (f->pos == f->last) { - break; - } - } else { if (f->padding) { f->state = ngx_http_fastcgi_st_padding;