From 1fd21c48bb29cdce8147f0fb53b2ad02a6130104 Mon Sep 17 00:00:00 2001 From: Ruslan Ermilov Date: Tue, 17 Jul 2012 04:47:34 +0000 Subject: [PATCH] Fixed sorting of listen addresses so that wildcard address is always at the end (closes #187). Failure to do so could result in several listen sockets to be created instead of only one listening on wildcard address. Reported by Roman Odaisky. --- src/http/ngx_http.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/http/ngx_http.c b/src/http/ngx_http.c index 3e077fb95..f1f8a48e0 100644 --- a/src/http/ngx_http.c +++ b/src/http/ngx_http.c @@ -1613,6 +1613,11 @@ ngx_http_cmp_conf_addrs(const void *one, const void *two) return 1; } + if (second->opt.wildcard) { + /* a wildcard address must be the last resort, shift it to the end */ + return -1; + } + if (first->opt.bind && !second->opt.bind) { /* shift explicit bind()ed addresses to the start */ return -1;