*) use previously cached GMT offset value to update time from a signal handler

*) change ngx_time_update() interface since there are no notification methods
   those return time
This commit is contained in:
Igor Sysoev 2010-03-13 18:08:07 +00:00
parent b80f68aeda
commit 2f916a9721
17 changed files with 64 additions and 45 deletions

View File

@ -63,7 +63,7 @@ ngx_init_cycle(ngx_cycle_t *old_cycle)
tp = ngx_timeofday();
tp->sec = 0;
ngx_time_update(0, 0);
ngx_time_update(0);
log = old_cycle->log;

View File

@ -28,6 +28,17 @@ volatile ngx_str_t ngx_cached_err_log_time;
volatile ngx_str_t ngx_cached_http_time;
volatile ngx_str_t ngx_cached_http_log_time;
#if !(NGX_HAVE_GETTIMEZONE)
/*
* locatime() and localtime_r() are not Async-Signal-Safe functions, therefore,
* if ngx_time_update() is called by signal handler, it uses the cached
* GMT offset value. Fortunately the value is changed only two times a year.
*/
static ngx_int_t cached_gmtoff;
#endif
static ngx_time_t cached_time[NGX_TIME_SLOTS];
static u_char cached_err_log_time[NGX_TIME_SLOTS]
[sizeof("1970/09/28 12:00:00")];
@ -50,15 +61,17 @@ ngx_time_init(void)
ngx_cached_time = &cached_time[0];
ngx_time_update(0, 0);
ngx_time_update(0);
}
void
ngx_time_update(time_t sec, ngx_uint_t msec)
ngx_time_update(ngx_uint_t use_cached_gmtoff)
{
u_char *p0, *p1, *p2;
ngx_tm_t tm, gmt;
time_t sec;
ngx_uint_t msec;
ngx_time_t *tp;
struct timeval tv;
@ -66,12 +79,10 @@ ngx_time_update(time_t sec, ngx_uint_t msec)
return;
}
if (sec == 0) {
ngx_gettimeofday(&tv);
ngx_gettimeofday(&tv);
sec = tv.tv_sec;
msec = tv.tv_usec / 1000;
}
sec = tv.tv_sec;
msec = tv.tv_usec / 1000;
ngx_current_msec = (ngx_msec_t) sec * 1000 + msec;
@ -109,15 +120,23 @@ ngx_time_update(time_t sec, ngx_uint_t msec)
tp->gmtoff = ngx_gettimezone();
ngx_gmtime(sec + tp->gmtoff * 60, &tm);
#elif (NGX_HAVE_GMTOFF)
ngx_localtime(sec, &tm);
tp->gmtoff = (ngx_int_t) (tm.ngx_tm_gmtoff / 60);
#else
ngx_localtime(sec, &tm);
tp->gmtoff = ngx_timezone(tm.ngx_tm_isdst);
if (use_cached_gmtoff) {
ngx_gmtime(sec + cached_gmtoff * 60, &tm);
} else {
ngx_localtime(sec, &tm);
#if (NGX_HAVE_GMTOFF)
cached_gmtoff = (ngx_int_t) (tm.ngx_tm_gmtoff / 60);
#else
cached_gmtoff = ngx_timezone(tm.ngx_tm_isdst);
#endif
}
tp->gmtoff = cached_gmtoff;
#endif

View File

@ -20,7 +20,7 @@ typedef struct {
void ngx_time_init(void);
void ngx_time_update(time_t sec, ngx_uint_t msec);
void ngx_time_update(ngx_uint_t use_cached_gmtoff);
u_char *ngx_http_time(u_char *buf, time_t t);
u_char *ngx_http_cookie_time(u_char *buf, time_t t);
void ngx_gmtime(time_t t, ngx_tm_t *tp);

View File

@ -372,7 +372,7 @@ ngx_devpoll_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
err = (events == -1) ? ngx_errno : 0;
if (flags & NGX_UPDATE_TIME || ngx_event_timer_alarm) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
if (err) {

View File

@ -532,7 +532,7 @@ ngx_epoll_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
err = (events == -1) ? ngx_errno : 0;
if (flags & NGX_UPDATE_TIME || ngx_event_timer_alarm) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
if (err) {

View File

@ -405,7 +405,7 @@ ngx_eventport_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
err = ngx_errno;
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
if (n == -1) {
@ -439,7 +439,7 @@ ngx_eventport_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
for (i = 0; i < events; i++) {
if (event_list[i].portev_source == PORT_SOURCE_TIMER) {
ngx_time_update(0, 0);
ngx_time_update(0);
continue;
}

View File

@ -163,7 +163,7 @@ ngx_iocp_timer(void *data)
for ( ;; ) {
Sleep(timer);
ngx_time_update(0, 0);
ngx_time_update(0);
#if 1
ngx_log_debug0(NGX_LOG_DEBUG_EVENT, ngx_cycle->log, 0, "timer");
#endif
@ -258,7 +258,7 @@ ngx_int_t ngx_iocp_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
delta = ngx_current_msec;
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_debug4(NGX_LOG_DEBUG_EVENT, cycle->log, 0,

View File

@ -538,7 +538,7 @@ ngx_kqueue_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
err = (events == -1) ? ngx_errno : 0;
if (flags & NGX_UPDATE_TIME || ngx_event_timer_alarm) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
@ -589,7 +589,7 @@ ngx_kqueue_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
#if (NGX_HAVE_TIMER_EVENT)
if (event_list[i].filter == EVFILT_TIMER) {
ngx_time_update(0, 0);
ngx_time_update(0);
continue;
}

View File

@ -263,7 +263,7 @@ ngx_poll_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
err = (ready == -1) ? ngx_errno : 0;
if (flags & NGX_UPDATE_TIME || ngx_event_timer_alarm) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_debug2(NGX_LOG_DEBUG_EVENT, cycle->log, 0,

View File

@ -323,7 +323,7 @@ ngx_rtsig_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
"rtsig signo:%d", signo);
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
if (err == NGX_EAGAIN) {
@ -349,7 +349,7 @@ ngx_rtsig_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
signo, si.si_fd, si.si_band);
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
rtscf = ngx_event_get_conf(ngx_cycle->conf_ctx, ngx_rtsig_module);
@ -419,7 +419,7 @@ ngx_rtsig_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
} else if (signo == SIGALRM) {
ngx_time_update(0, 0);
ngx_time_update(0);
return NGX_OK;
@ -671,7 +671,7 @@ ngx_rtsig_process_overflow(ngx_cycle_t *cycle, ngx_msec_t timer,
}
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_error(NGX_LOG_ALERT, cycle->log, 0,

View File

@ -263,7 +263,7 @@ ngx_select_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
err = (ready == -1) ? ngx_errno : 0;
if (flags & NGX_UPDATE_TIME || ngx_event_timer_alarm) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,

View File

@ -269,7 +269,7 @@ ngx_select_process_events(ngx_cycle_t *cycle, ngx_msec_t timer,
err = (ready == -1) ? ngx_socket_errno : 0;
if (flags & NGX_UPDATE_TIME) {
ngx_time_update(0, 0);
ngx_time_update(0);
}
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,

View File

@ -1216,7 +1216,7 @@ ngx_http_file_cache_manager_sleep(ngx_http_file_cache_t *cache)
if (cache->files++ > 100) {
ngx_time_update(0, 0);
ngx_time_update(0);
elapsed = ngx_abs((ngx_msec_int_t) (ngx_current_msec - cache->last));
@ -1233,7 +1233,7 @@ ngx_http_file_cache_manager_sleep(ngx_http_file_cache_t *cache)
ngx_msleep(200);
ngx_time_update(0, 0);
ngx_time_update(0);
}
cache->last = ngx_current_msec;

View File

@ -317,7 +317,7 @@ ngx_signal_handler(int signo)
}
}
ngx_time_update(0, 0);
ngx_time_update(1);
action = "";

View File

@ -168,7 +168,7 @@ ngx_master_process_cycle(ngx_cycle_t *cycle)
sigsuspend(&set);
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
"wake up, sigio %i", sigio);
@ -1342,7 +1342,7 @@ ngx_cache_manager_process_handler(ngx_event_t *ev)
next = (n <= next) ? n : next;
ngx_time_update(0, 0);
ngx_time_update(0);
}
}
@ -1372,7 +1372,7 @@ ngx_cache_loader_process_handler(ngx_event_t *ev)
if (path[i]->loader) {
path[i]->loader(path[i]->data);
ngx_time_update(0, 0);
ngx_time_update(0);
}
}

View File

@ -85,7 +85,7 @@ ngx_spawn_process(ngx_cycle_t *cycle, char *name, ngx_int_t respawn)
rc = WaitForMultipleObjects(2, events, 0, 5000);
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, cycle->log, 0,
"WaitForMultipleObjects: %ul", rc);

View File

@ -140,7 +140,7 @@ ngx_master_process_cycle(ngx_cycle_t *cycle)
ev = WaitForMultipleObjects(nev, events, 0, timeout);
err = ngx_errno;
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, cycle->log, 0,
"master WaitForMultipleObjects: %ul", ev);
@ -679,7 +679,7 @@ ngx_worker_process_cycle(ngx_cycle_t *cycle, char *mevn)
ev = WaitForMultipleObjects(3, events, 0, INFINITE);
err = ngx_errno;
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
"worker WaitForMultipleObjects: %ul", ev);
@ -738,7 +738,7 @@ ngx_worker_process_cycle(ngx_cycle_t *cycle, char *mevn)
ev = WaitForMultipleObjects(nev, events, 0, INFINITE);
err = ngx_errno;
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0,
"worker exit WaitForMultipleObjects: %ul", ev);
@ -907,7 +907,7 @@ ngx_cache_manager_thread(void *data)
ev = WaitForMultipleObjects(2, events, 0, INFINITE);
err = ngx_errno;
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, cycle->log, 0,
"cache manager WaitForMultipleObjects: %ul", ev);
@ -968,7 +968,7 @@ ngx_cache_manager_process_handler(void)
next = (n <= next) ? n : next;
ngx_time_update(0, 0);
ngx_time_update(0);
}
}
@ -980,7 +980,7 @@ ngx_cache_manager_process_handler(void)
if (ev != WAIT_TIMEOUT) {
ngx_time_update(0, 0);
ngx_time_update(0);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, ngx_cycle->log, 0,
"cache manager WaitForSingleObject: %ul", ev);
@ -1008,7 +1008,7 @@ ngx_cache_loader_thread(void *data)
if (path[i]->loader) {
path[i]->loader(path[i]->data);
ngx_time_update(0, 0);
ngx_time_update(0);
}
}