From 430db103f682457f7cc0e7198e03ef6ddb4a76ad Mon Sep 17 00:00:00 2001 From: Igor Sysoev Date: Sun, 16 Mar 2008 16:52:15 +0000 Subject: [PATCH] speed up ngx_http_charset_recode() for 25%: google-perftools reported that CPU usage of charset body filter has decreased from 7.5% to 5.5% if gzipping is disabled --- .../modules/ngx_http_charset_filter_module.c | 34 ++++++++++++------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/http/modules/ngx_http_charset_filter_module.c b/src/http/modules/ngx_http_charset_filter_module.c index f7d9906a8..850e64e75 100644 --- a/src/http/modules/ngx_http_charset_filter_module.c +++ b/src/http/modules/ngx_http_charset_filter_module.c @@ -561,25 +561,33 @@ ngx_http_charset_body_filter(ngx_http_request_t *r, ngx_chain_t *in) static ngx_uint_t ngx_http_charset_recode(ngx_buf_t *b, u_char *table) { - u_char *p; + u_char *p, *last; - for (p = b->pos; p < b->last; p++) { + last = b->last; - if (*p == table[*p]) { - continue; + for (p = b->pos; p < last; p++) { + + if (*p != table[*p]) { + goto recode; } - - while (p < b->last) { - *p = table[*p]; - p++; - } - - b->in_file = 0; - - return 1; } return 0; + +recode: + + do { + if (*p != table[*p]) { + *p = table[*p]; + } + + p++; + + } while (p < last); + + b->in_file = 0; + + return 1; }