From 6c3c3bbe4254b2f2d65e4a27ed2618b37391606c Mon Sep 17 00:00:00 2001 From: Igor Sysoev Date: Tue, 19 Jul 2011 11:24:16 +0000 Subject: [PATCH] fix segfault if cache key is larger than upstream buffer size patch by Lanshun Zhou --- src/http/ngx_http_upstream.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/http/ngx_http_upstream.c b/src/http/ngx_http_upstream.c index f9f09cb34..ad5b449ec 100644 --- a/src/http/ngx_http_upstream.c +++ b/src/http/ngx_http_upstream.c @@ -661,6 +661,15 @@ ngx_http_upstream_cache(ngx_http_request_t *r, ngx_http_upstream_t *u) ngx_http_file_cache_create_key(r); + if (r->cache->header_start >= u->conf->buffer_size) { + ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, + "cache key too large, increase upstream buffer size %uz", + u->conf->buffer_size); + + r->cache = NULL; + return NGX_DECLINED; + } + switch (ngx_http_test_predicates(r, u->conf->cache_bypass)) { case NGX_ERROR: