mirror/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-06-12 13:42:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

store name pointer in variable allocated on stack

Browse Source 
as resolver ctx may be already deallocated at this point
This commit is contained in:
Igor Sysoev 2009-01-29 14:35:23 +00:00
parent fa748fe120
commit 9258872c2a
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/core/ngx_resolver.c
View File

@ -578,6 +578,7 @@ failed:
ngx_int_t ngx_int_t
ngx_resolve_addr(ngx_resolver_ctx_t *ctx) ngx_resolve_addr(ngx_resolver_ctx_t *ctx)
{ {
u_char *name;
ngx_resolver_t *r; ngx_resolver_t *r;
ngx_resolver_node_t *rn; ngx_resolver_node_t *rn;
@ -601,19 +602,21 @@ ngx_resolve_addr(ngx_resolver_ctx_t *ctx)
ngx_queue_insert_head(&r->addr_expire_queue, &rn->queue); ngx_queue_insert_head(&r->addr_expire_queue, &rn->queue);
ctx->name.len = rn->nlen; name = ngx_resolver_dup(r, rn->name, rn->nlen);
ctx->name.data = ngx_resolver_dup(r, rn->name, rn->nlen); if (name == NULL) {
if (ctx->name.data == NULL) {
goto failed; goto failed;
} }
ctx->name.len = rn->nlen;
ctx->name.data = name;
/* unlock addr mutex */ /* unlock addr mutex */
ctx->state = NGX_OK; ctx->state = NGX_OK;
ctx->handler(ctx); ctx->handler(ctx);
ngx_resolver_free(r, ctx->name.data); ngx_resolver_free(r, name);
return NGX_OK; return NGX_OK;
} }