From a5bb616af4339a3e0be2f22cb7e456cd649aa4ee Mon Sep 17 00:00:00 2001 From: Ruslan Ermilov Date: Wed, 11 Apr 2012 17:18:15 +0000 Subject: [PATCH] Improved readability of the code that produces bitmask from prefix. In collaboration with Maxim Dounin. --- src/core/ngx_inet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/ngx_inet.c b/src/core/ngx_inet.c index a6ce9f395..4fccc17ed 100644 --- a/src/core/ngx_inet.c +++ b/src/core/ngx_inet.c @@ -420,7 +420,7 @@ ngx_ptocidr(ngx_str_t *text, ngx_cidr_t *cidr) s = (shift > 8) ? 8 : shift; shift -= s; - mask[i] = (u_char) (0 - (1 << (8 - s))); + mask[i] = (u_char) (0xffu << (8 - s)); if (addr[i] != (addr[i] & mask[i])) { rc = NGX_DONE; @@ -437,7 +437,7 @@ ngx_ptocidr(ngx_str_t *text, ngx_cidr_t *cidr) } if (shift) { - cidr->u.in.mask = htonl((ngx_uint_t) (0 - (1 << (32 - shift)))); + cidr->u.in.mask = htonl((uint32_t) (0xffffffffu << (32 - shift))); } else { /* x86 compilers use a shl instruction that shifts by modulo 32 */