mirror/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-06-07 17:52:38 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

load SSL engine before certificates,

Browse Source 
otherwise RSA keys will use built-in RSA methods
This commit is contained in:
Igor Sysoev 2009-02-16 13:37:58 +00:00
parent b17bf52a27
commit be63760fc5
1 changed files with 25 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
src/event/ngx_event_openssl.c
View File

@ -10,7 +10,7 @@
typedef struct { typedef struct {
ngx_str_t engine; ngx_uint_t engine; /* unsigned engine:1; */
} ngx_openssl_conf_t; } ngx_openssl_conf_t;
@ -37,26 +37,17 @@ static void ngx_ssl_session_rbtree_insert_value(ngx_rbtree_node_t *temp,
ngx_rbtree_node_t *node, ngx_rbtree_node_t *sentinel); ngx_rbtree_node_t *node, ngx_rbtree_node_t *sentinel);
static void *ngx_openssl_create_conf(ngx_cycle_t *cycle); static void *ngx_openssl_create_conf(ngx_cycle_t *cycle);
static char *ngx_openssl_init_conf(ngx_cycle_t *cycle, void *conf); static char *ngx_openssl_engine(ngx_conf_t *cf, ngx_command_t *cmd, void *conf);
static void ngx_openssl_exit(ngx_cycle_t *cycle); static void ngx_openssl_exit(ngx_cycle_t *cycle);
#if !(NGX_SSL_ENGINE)
static char *ngx_openssl_noengine(ngx_conf_t *cf, ngx_command_t *cmd,
void *conf);
#endif
static ngx_command_t ngx_openssl_commands[] = { static ngx_command_t ngx_openssl_commands[] = {
{ ngx_string("ssl_engine"), { ngx_string("ssl_engine"),
NGX_MAIN_CONF|NGX_DIRECT_CONF|NGX_CONF_TAKE1, NGX_MAIN_CONF|NGX_DIRECT_CONF|NGX_CONF_TAKE1,
#if (NGX_SSL_ENGINE) ngx_openssl_engine,
ngx_conf_set_str_slot, 0,
#else
ngx_openssl_noengine,
#endif
0, 0,
offsetof(ngx_openssl_conf_t, engine),
NULL }, NULL },
ngx_null_command ngx_null_command
@ -66,7 +57,7 @@ static ngx_command_t ngx_openssl_commands[] = {
static ngx_core_module_t ngx_openssl_module_ctx = { static ngx_core_module_t ngx_openssl_module_ctx = {
ngx_string("openssl"), ngx_string("openssl"),
ngx_openssl_create_conf, ngx_openssl_create_conf,
ngx_openssl_init_conf NULL
}; };
@ -2113,8 +2104,7 @@ ngx_openssl_create_conf(ngx_cycle_t *cycle)
/* /*
* set by ngx_pcalloc(): * set by ngx_pcalloc():
* *
* oscf->engine.len = 0; * oscf->engine = 0;
* oscf->engine.data = NULL;
*/ */
return oscf; return oscf;
@ -2122,53 +2112,54 @@ ngx_openssl_create_conf(ngx_cycle_t *cycle)
static char * static char *
ngx_openssl_init_conf(ngx_cycle_t *cycle, void *conf) ngx_openssl_engine(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
{ {
#if (NGX_SSL_ENGINE) #if (NGX_SSL_ENGINE)
ngx_openssl_conf_t *oscf = conf; ngx_openssl_conf_t *oscf = conf;
ENGINE *engine; ENGINE *engine;
ngx_str_t *value;
if (oscf->engine.len == 0) { if (oscf->engine) {
return NGX_CONF_OK; return "is duplicate";
} }
engine = ENGINE_by_id((const char *) oscf->engine.data); oscf->engine = 1;
value = cf->args->elts;
engine = ENGINE_by_id((const char *) value[1].data);
if (engine == NULL) { if (engine == NULL) {
ngx_ssl_error(NGX_LOG_WARN, cycle->log, 0, ngx_ssl_error(NGX_LOG_WARN, cf->log, 0,
"ENGINE_by_id(\"%V\") failed", &oscf->engine); "ENGINE_by_id(\"%V\") failed", &value[1]);
return NGX_CONF_ERROR; return NGX_CONF_ERROR;
} }
if (ENGINE_set_default(engine, ENGINE_METHOD_ALL) == 0) { if (ENGINE_set_default(engine, ENGINE_METHOD_ALL) == 0) {
ngx_ssl_error(NGX_LOG_WARN, cycle->log, 0, ngx_ssl_error(NGX_LOG_WARN, cf->log, 0,
"ENGINE_set_default(\"%V\", ENGINE_METHOD_ALL) failed", "ENGINE_set_default(\"%V\", ENGINE_METHOD_ALL) failed",
&oscf->engine); &value[1]);
ENGINE_free(engine);
return NGX_CONF_ERROR; return NGX_CONF_ERROR;
} }
ENGINE_free(engine); ENGINE_free(engine);
#endif
return NGX_CONF_OK; return NGX_CONF_OK;
}
#else
#if !(NGX_SSL_ENGINE)
static char *
ngx_openssl_noengine(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
{
ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
"\"ssl_engine\" directive is available only in " "\"ssl_engine\" directive is available only in "
"OpenSSL 0.9.7 and higher,"); "OpenSSL 0.9.7 and higher,");
return NGX_CONF_ERROR; return NGX_CONF_ERROR;
}
#endif #endif
}
static void static void