mirror/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2024-12-13 11:09:06 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Workaround for cpu hog on errors with cached connections.

Browse Source 
Just doing another connect isn't safe as peer.get() may expect peer.tries
to be strictly positive (this is the case e.g. with round robin with multiple
upstream servers).  Increment peer.tries to at least avoid cpu hog in
round robin balancer (with the patch alert will be seen instead).

This is not enough to fully address the problem though, hence TODO.  We
should be able to inform balancer that the error wasn't considered fatal
and it may make sense to retry the same peer.
This commit is contained in:
Maxim Dounin 2011-09-15 18:12:58 +00:00
parent d7c2673d3f
commit c42c70f478
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/http/ngx_http_upstream.c
View File

@ -2812,6 +2812,10 @@ ngx_http_upstream_next(ngx_http_request_t *r, ngx_http_upstream_t *u,
if (u->peer.cached && ft_type == NGX_HTTP_UPSTREAM_FT_ERROR) { if (u->peer.cached && ft_type == NGX_HTTP_UPSTREAM_FT_ERROR) {
status = 0; status = 0;
/* TODO: inform balancer instead */
u->peer.tries++;
} else { } else {
switch(ft_type) { switch(ft_type) {