mirror/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-01-20 18:42:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

QUIC: consider max_ack_delay=16384 invalid.

Browse Source 
As per RFC 9000:

   Values of 2^14 or greater are invalid.
This commit is contained in:
Roman Arutyunyan 2021-06-30 13:47:38 +03:00
parent 8f8f484004
commit d54d551e2a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/event/quic/ngx_event_quic.c
View File

@ -176,7 +176,7 @@ ngx_quic_apply_transport_params(ngx_connection_t *c, ngx_quic_tp_t *ctp)
return NGX_ERROR; return NGX_ERROR;
} }
if (ctp->max_ack_delay > 16384) { if (ctp->max_ack_delay >= 16384) {
qc->error = NGX_QUIC_ERR_TRANSPORT_PARAMETER_ERROR; qc->error = NGX_QUIC_ERR_TRANSPORT_PARAMETER_ERROR;
qc->error_reason = "invalid max_ack_delay"; qc->error_reason = "invalid max_ack_delay";

2
src/http/modules/ngx_http_quic_module.c
View File

@ -394,7 +394,7 @@ ngx_http_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data)
{ {
ngx_msec_t *sp = data; ngx_msec_t *sp = data;
if (*sp > 16384) { if (*sp >= 16384) {
ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
"\"quic_max_ack_delay\" must be less than 16384"); "\"quic_max_ack_delay\" must be less than 16384");

2
src/stream/ngx_stream_quic_module.c
View File

@ -354,7 +354,7 @@ ngx_stream_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data)
{ {
ngx_msec_t *sp = data; ngx_msec_t *sp = data;
if (*sp > 16384) { if (*sp >= 16384) {
ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
"\"quic_max_ack_delay\" must be less than 16384"); "\"quic_max_ack_delay\" must be less than 16384");