SSL: logging level of "peer closed connection in SSL handshake".

Previously, the NGX_LOG_INFO level was used unconditionally.  This is
correct for client SSL connections, but too low for connections to
upstream servers.  To resolve this, ngx_connection_error() now used
to log this error, it will select logging level appropriately.

With this change, if an upstream connection is closed during SSL
handshake, it is now properly logged at "error" level.
This commit is contained in:
Maxim Dounin 2014-07-04 22:14:36 +04:00
parent 4a75e1a63c
commit d9152910d3

View File

@ -1112,8 +1112,8 @@ ngx_ssl_handshake(ngx_connection_t *c)
c->read->eof = 1; c->read->eof = 1;
if (sslerr == SSL_ERROR_ZERO_RETURN || ERR_peek_error() == 0) { if (sslerr == SSL_ERROR_ZERO_RETURN || ERR_peek_error() == 0) {
ngx_log_error(NGX_LOG_INFO, c->log, err, ngx_connection_error(c, err,
"peer closed connection in SSL handshake"); "peer closed connection in SSL handshake");
return NGX_ERROR; return NGX_ERROR;
} }