Upstream: don't cache unfinished responses.

Check if received data length match Content-Length header (if present),
don't cache response if no match found.  This prevents caching of corrupted
response in case of premature connection close by upstream.
This commit is contained in:
Maxim Dounin 2011-11-18 15:09:08 +00:00
parent 5eef168a22
commit e0c1a63028

View File

@ -2696,9 +2696,17 @@ ngx_http_upstream_process_request(ngx_http_request_t *r)
} else if (p->upstream_eof) {
/* TODO: check length & update cache */
tf = u->pipe->temp_file;
ngx_http_file_cache_update(r, u->pipe->temp_file);
if (u->headers_in.content_length_n == -1
|| u->headers_in.content_length_n
== tf->offset - (off_t) r->cache->body_start)
{
ngx_http_file_cache_update(r, tf);
} else {
ngx_http_file_cache_free(r->cache, tf);
}
} else if (p->upstream_error) {
ngx_http_file_cache_free(r->cache, u->pipe->temp_file);