mirror/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-06-27 09:00:38 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

All non-unique input headers are now linked lists.

Browse Source 
The ngx_http_process_multi_header_lines() function is removed, as it is
exactly equivalent to ngx_http_process_header_line().  Similarly,
ngx_http_variable_header() is used instead of ngx_http_variable_headers().
This commit is contained in:
Maxim Dounin 2022-05-30 21:25:35 +03:00
parent 3aef1d693f
commit fcf4331a0f
2 changed files with 12 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/http/ngx_http_request.c
View File

@ -22,8 +22,6 @@ static ngx_int_t ngx_http_process_header_line(ngx_http_request_t *r,
ngx_table_elt_t *h, ngx_uint_t offset); ngx_table_elt_t *h, ngx_uint_t offset);
static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r,
ngx_table_elt_t *h, ngx_uint_t offset); ngx_table_elt_t *h, ngx_uint_t offset);
static ngx_int_t ngx_http_process_multi_header_lines(ngx_http_request_t *r,
ngx_table_elt_t *h, ngx_uint_t offset);
static ngx_int_t ngx_http_process_host(ngx_http_request_t *r, static ngx_int_t ngx_http_process_host(ngx_http_request_t *r,
ngx_table_elt_t *h, ngx_uint_t offset); ngx_table_elt_t *h, ngx_uint_t offset);
static ngx_int_t ngx_http_process_connection(ngx_http_request_t *r, static ngx_int_t ngx_http_process_connection(ngx_http_request_t *r,
@ -164,7 +162,7 @@ ngx_http_header_t ngx_http_headers_in[] = {
#if (NGX_HTTP_X_FORWARDED_FOR) #if (NGX_HTTP_X_FORWARDED_FOR)
{ ngx_string("X-Forwarded-For"), { ngx_string("X-Forwarded-For"),
offsetof(ngx_http_headers_in_t, x_forwarded_for), offsetof(ngx_http_headers_in_t, x_forwarded_for),
ngx_http_process_multi_header_lines }, ngx_http_process_header_line },
#endif #endif
#if (NGX_HTTP_REALIP) #if (NGX_HTTP_REALIP)
@ -197,7 +195,7 @@ ngx_http_header_t ngx_http_headers_in[] = {
#endif #endif
{ ngx_string("Cookie"), offsetof(ngx_http_headers_in_t, cookie), { ngx_string("Cookie"), offsetof(ngx_http_headers_in_t, cookie),
ngx_http_process_multi_header_lines }, ngx_http_process_header_line },
{ ngx_null_string, 0, NULL } { ngx_null_string, 0, NULL }
}; };
@ -1742,10 +1740,10 @@ ngx_http_process_header_line(ngx_http_request_t *r, ngx_table_elt_t *h,
ph = (ngx_table_elt_t **) ((char *) &r->headers_in + offset); ph = (ngx_table_elt_t **) ((char *) &r->headers_in + offset);
if (*ph == NULL) { while (*ph) { ph = &(*ph)->next; }
*ph = h;
h->next = NULL; *ph = h;
} h->next = NULL;
return NGX_OK; return NGX_OK;
} }
@ -1851,13 +1849,10 @@ ngx_http_process_user_agent(ngx_http_request_t *r, ngx_table_elt_t *h,
{ {
u_char *user_agent, *msie; u_char *user_agent, *msie;
if (r->headers_in.user_agent) { if (ngx_http_process_header_line(r, h, offset) != NGX_OK) {
return NGX_OK; return NGX_ERROR;
} }
r->headers_in.user_agent = h;
h->next = NULL;
/* check some widespread browsers while the header is in CPU cache */ /* check some widespread browsers while the header is in CPU cache */
user_agent = h->value.data; user_agent = h->value.data;
@ -1919,23 +1914,6 @@ ngx_http_process_user_agent(ngx_http_request_t *r, ngx_table_elt_t *h,
} }
static ngx_int_t
ngx_http_process_multi_header_lines(ngx_http_request_t *r, ngx_table_elt_t *h,
ngx_uint_t offset)
{
ngx_table_elt_t **ph;
ph = (ngx_table_elt_t **) ((char *) &r->headers_in + offset);
while (*ph) { ph = &(*ph)->next; }
*ph = h;
h->next = NULL;
return NGX_OK;
}
ngx_int_t ngx_int_t
ngx_http_process_request_header(ngx_http_request_t *r) ngx_http_process_request_header(ngx_http_request_t *r)
{ {

33
src/http/ngx_http_variables.c
View File

@ -27,8 +27,6 @@ static ngx_int_t ngx_http_variable_header(ngx_http_request_t *r,
static ngx_int_t ngx_http_variable_cookies(ngx_http_request_t *r, static ngx_int_t ngx_http_variable_cookies(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data); ngx_http_variable_value_t *v, uintptr_t data);
static ngx_int_t ngx_http_variable_headers(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data);
static ngx_int_t ngx_http_variable_headers_internal(ngx_http_request_t *r, static ngx_int_t ngx_http_variable_headers_internal(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data, u_char sep); ngx_http_variable_value_t *v, uintptr_t data, u_char sep);
@ -178,7 +176,7 @@ static ngx_http_variable_t ngx_http_core_variables[] = {
#endif #endif
#if (NGX_HTTP_X_FORWARDED_FOR) #if (NGX_HTTP_X_FORWARDED_FOR)
{ ngx_string("http_x_forwarded_for"), NULL, ngx_http_variable_headers, { ngx_string("http_x_forwarded_for"), NULL, ngx_http_variable_header,
offsetof(ngx_http_request_t, headers_in.x_forwarded_for), 0, 0 }, offsetof(ngx_http_request_t, headers_in.x_forwarded_for), 0, 0 },
#endif #endif
@ -327,10 +325,10 @@ static ngx_http_variable_t ngx_http_core_variables[] = {
{ ngx_string("sent_http_transfer_encoding"), NULL, { ngx_string("sent_http_transfer_encoding"), NULL,
ngx_http_variable_sent_transfer_encoding, 0, 0, 0 }, ngx_http_variable_sent_transfer_encoding, 0, 0, 0 },
{ ngx_string("sent_http_cache_control"), NULL, ngx_http_variable_headers, { ngx_string("sent_http_cache_control"), NULL, ngx_http_variable_header,
offsetof(ngx_http_request_t, headers_out.cache_control), 0, 0 }, offsetof(ngx_http_request_t, headers_out.cache_control), 0, 0 },
{ ngx_string("sent_http_link"), NULL, ngx_http_variable_headers, { ngx_string("sent_http_link"), NULL, ngx_http_variable_header,
offsetof(ngx_http_request_t, headers_out.link), 0, 0 }, offsetof(ngx_http_request_t, headers_out.link), 0, 0 },
{ ngx_string("limit_rate"), ngx_http_variable_set_limit_rate, { ngx_string("limit_rate"), ngx_http_variable_set_limit_rate,
@ -807,22 +805,7 @@ static ngx_int_t
ngx_http_variable_header(ngx_http_request_t *r, ngx_http_variable_value_t *v, ngx_http_variable_header(ngx_http_request_t *r, ngx_http_variable_value_t *v,
uintptr_t data) uintptr_t data)
{ {
ngx_table_elt_t *h; return ngx_http_variable_headers_internal(r, v, data, ',');
h = *(ngx_table_elt_t **) ((char *) r + data);
if (h) {
v->len = h->value.len;
v->valid = 1;
v->no_cacheable = 0;
v->not_found = 0;
v->data = h->value.data;
} else {
v->not_found = 1;
}
return NGX_OK;
} }
@ -834,14 +817,6 @@ ngx_http_variable_cookies(ngx_http_request_t *r,
} }
static ngx_int_t
ngx_http_variable_headers(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data)
{
return ngx_http_variable_headers_internal(r, v, data, ',');
}
static ngx_int_t static ngx_int_t
ngx_http_variable_headers_internal(ngx_http_request_t *r, ngx_http_variable_headers_internal(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data, u_char sep) ngx_http_variable_value_t *v, uintptr_t data, u_char sep)