mirror/opencv
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2025-06-09 18:43:05 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

improve code style and Doc of stackblur.

Browse Source
This commit is contained in:
Zihao Mu 2022-10-29 17:34:28 +08:00
parent 1293e99ad8
commit 17b98dd005
3 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
modules/imgproc/include/opencv2/imgproc.hpp
View File

@ -1620,14 +1620,15 @@ CV_EXPORTS_W void blur( InputArray src, OutputArray dst,
Size ksize, Point anchor = Point(-1,-1), Size ksize, Point anchor = Point(-1,-1),
int borderType = BORDER_DEFAULT ); int borderType = BORDER_DEFAULT );
/** @brief Blurs an image using the StackBlur. /** @brief Blurs an image using the stackBlur.
The function applies and StackBlur to an image.
StackBlur can generate similar results as Gaussian blur, and the time does not increase as the kernel size increases. The function applies and stackBlur to an image.
stackBlur can generate similar results as Gaussian blur, and the time consumption does not increase with the increase of kernel size.
It creates a kind of moving stack of colors whilst scanning through the image. Thereby it just has to add one new block of color to the right side It creates a kind of moving stack of colors whilst scanning through the image. Thereby it just has to add one new block of color to the right side
of the stack and remove the leftmost color. The remaining colors on the topmost layer of the stack are either added on or reduced by one, of the stack and remove the leftmost color. The remaining colors on the topmost layer of the stack are either added on or reduced by one,
depending on if they are on the right or on the left side of the stack. depending on if they are on the right or on the left side of the stack. The only supported borderType is BORDER_REPLICATE.
Described here: http://underdestruction.com/2004/02/25/stackblur-2004. Original paper was proposed by Mario Klingemann, which can be found http://underdestruction.com/2004/02/25/stackblur-2004.
Stack Blur Algorithm by Mario Klingemann <mario@quasimondo.com>
@param src input image. The number of channels can be arbitrary, but the depth should be one of @param src input image. The number of channels can be arbitrary, but the depth should be one of
CV_8U, CV_16U, CV_16S or CV_32F. CV_8U, CV_16U, CV_16S or CV_32F.
@param dst output image of the same size and type as src. @param dst output image of the same size and type as src.

12
modules/imgproc/src/stackblur.cpp
View File

@ -461,8 +461,6 @@ public:
~ParallelStackBlurRow() {} ~ParallelStackBlurRow() {}
ParallelStackBlurRow& operator=(const ParallelStackBlurRow &) { return *this; }
/* /*
* The idea is as follows: * The idea is as follows:
* The stack can be understood as a sliding window of length kernel size. * The stack can be understood as a sliding window of length kernel size.
@ -1084,8 +1082,6 @@ public:
~ParallelStackBlurColumn() {} ~ParallelStackBlurColumn() {}
ParallelStackBlurColumn& operator=(const ParallelStackBlurColumn &) { return *this; }
virtual void operator ()(const Range& range) const CV_OVERRIDE virtual void operator ()(const Range& range) const CV_OVERRIDE
{ {
if (radius == 0) if (radius == 0)
@ -1146,7 +1142,8 @@ public:
if (stackStart >= kernelSize) stackStart -= kernelSize; if (stackStart >= kernelSize) stackStart -= kernelSize;
int sp1 = sp + 1; int sp1 = sp + 1;
sp1 &= -(sp1 < kernelSize); if (sp1 >= kernelSize)
sp1 = 0;
if (yp < hm) if (yp < hm)
{ {
@ -1176,7 +1173,8 @@ public:
dstPtr += widthElem; dstPtr += widthElem;
++sp; ++sp;
if (sp >= kernelSize) sp = 0; if (sp >= kernelSize)
sp = 0;
} }
} }
@ -1255,7 +1253,7 @@ void stackBlur(InputArray _src, OutputArray _dst, Size ksize)
parallel_for_(Range(0, widthElem), ParallelStackBlurColumn<float, float>(dst, dst, radiusH), numOfThreads); parallel_for_(Range(0, widthElem), ParallelStackBlurColumn<float, float>(dst, dst, radiusH), numOfThreads);
} }
else else
CV_Error_( CV_StsNotImplemented, CV_Error(Error::StsNotImplemented,
("Unsupported input format in StackBlur, the supported formats are: CV_8U, CV_16U, CV_16S and CV_32F.")); ("Unsupported input format in StackBlur, the supported formats are: CV_8U, CV_16U, CV_16S and CV_32F."));
} }
} //namespace } //namespace

8
modules/imgproc/test/test_stackblur.cpp
View File

@ -125,7 +125,8 @@ void _stackblurRef(const Mat& src, Mat& dst, Size ksize)
} }
int sp1 = sp + 1; int sp1 = sp + 1;
sp1 &= -(sp1 < stackLenW); if (sp1 >= stackLenW)
sp1 = 0;
for(int ci = 0; ci < CN; ci++) for(int ci = 0; ci < CN; ci++)
{ {
@ -143,7 +144,8 @@ void _stackblurRef(const Mat& src, Mat& dst, Size ksize)
} }
++sp; ++sp;
if (sp >= stackLenW) sp = 0; if (sp >= stackLenW)
sp = 0;
} }
} }
@ -239,7 +241,7 @@ void stackBlurRef(const Mat& img, Mat& dst, Size ksize)
else if (img.depth() == CV_32F) else if (img.depth() == CV_32F)
_stackblurRef<float>(img, dst, ksize); _stackblurRef<float>(img, dst, ksize);
else else
CV_Error_( CV_StsNotImplemented, CV_Error(Error::StsNotImplemented,
("Unsupported Mat type in stackBlurRef, " ("Unsupported Mat type in stackBlurRef, "
"the supported formats are: CV_8U, CV_16U, CV_16S and CV_32F.")); "the supported formats are: CV_8U, CV_16U, CV_16S and CV_32F."));
} }