mirror/opencv
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2025-07-25 22:57:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #19828 from OrestChura:oc/fix_garray_garray_input

Browse Source 
[G-API] Fix bug of GArray<GArray> passing through a graph

* Add test to check GArray<GArray> passing through a graph (assertion failed)

* G-API: Flatten GArray<T> to std::vector<T> when capturing VCtr

- Also: Fix formatting in garray.hpp

* Refactored test, added valuable check

* Initialize size_t

Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com>
This commit is contained in:
Orest Chura 2021-04-01 23:39:31 +03:00 committed by GitHub
parent 1e51f87298
commit 34a8a45a6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
modules/gapi/include/opencv2/gapi/garray.hpp
View File

@ -246,12 +246,18 @@ namespace detail
public: public:
VectorRef() = default; VectorRef() = default;
template<typename T> explicit VectorRef(const std::vector<T>& vec) : template<typename T> explicit VectorRef(const std::vector<T>& vec)
m_ref(new VectorRefT<T>(vec)), m_kind(GOpaqueTraits<T>::kind) {} : m_ref(new VectorRefT<T>(vec))
template<typename T> explicit VectorRef(std::vector<T>& vec) : , m_kind(GOpaqueTraits<T>::kind)
m_ref(new VectorRefT<T>(vec)), m_kind(GOpaqueTraits<T>::kind) {} {}
template<typename T> explicit VectorRef(std::vector<T>&& vec) : template<typename T> explicit VectorRef(std::vector<T>& vec)
m_ref(new VectorRefT<T>(std::move(vec))), m_kind(GOpaqueTraits<T>::kind) {} : m_ref(new VectorRefT<T>(vec))
, m_kind(GOpaqueTraits<T>::kind)
{}
template<typename T> explicit VectorRef(std::vector<T>&& vec)
: m_ref(new VectorRefT<T>(std::move(vec)))
, m_kind(GOpaqueTraits<T>::kind)
{}
cv::detail::OpaqueKind getKind() const cv::detail::OpaqueKind getKind() const
{ {
@ -321,9 +327,10 @@ namespace detail
# define FLATTEN_NS cv # define FLATTEN_NS cv
#endif #endif
template<class T> struct flatten_g; template<class T> struct flatten_g;
template<> struct flatten_g<cv::GMat> { using type = FLATTEN_NS::Mat; }; template<> struct flatten_g<cv::GMat> { using type = FLATTEN_NS::Mat; };
template<> struct flatten_g<cv::GScalar> { using type = FLATTEN_NS::Scalar; }; template<> struct flatten_g<cv::GScalar> { using type = FLATTEN_NS::Scalar; };
template<class T> struct flatten_g { using type = T; }; template<class T> struct flatten_g<GArray<T>> { using type = std::vector<T>; };
template<class T> struct flatten_g { using type = T; };
#undef FLATTEN_NS #undef FLATTEN_NS
// FIXME: the above mainly duplicates "ProtoToParam" thing from gtyped.hpp // FIXME: the above mainly duplicates "ProtoToParam" thing from gtyped.hpp
// but I decided not to include gtyped here - probably worth moving that stuff // but I decided not to include gtyped here - probably worth moving that stuff

30
modules/gapi/test/gapi_array_tests.cpp
View File

@ -32,6 +32,10 @@ G_TYPED_KERNEL(PointIncrement, <GPointArray(GMat, GPointArray)>, "test.point_inc
{ {
static GArrayDesc outMeta(const GMatDesc&, const GArrayDesc&) { return empty_array_desc(); } static GArrayDesc outMeta(const GMatDesc&, const GArrayDesc&) { return empty_array_desc(); }
}; };
G_TYPED_KERNEL(CountContours, <GOpaque<size_t>(GArray<GPointArray>)>, "test.array.array.in")
{
static GOpaqueDesc outMeta(const GArrayDesc&) { return empty_gopaque_desc(); }
};
} // namespace ThisTest } // namespace ThisTest
namespace namespace
@ -70,6 +74,14 @@ GAPI_OCV_KERNEL(OCVPointIncrement, ThisTest::PointIncrement)
} }
}; };
GAPI_OCV_KERNEL(OCVCountContours, ThisTest::CountContours)
{
static void run(const std::vector<std::vector<cv::Point>> &contours, size_t &out)
{
out = contours.size();
}
};
cv::Mat cross(int w, int h) cv::Mat cross(int w, int h)
{ {
cv::Mat mat = cv::Mat::eye(h, w, CV_8UC1)*255; cv::Mat mat = cv::Mat::eye(h, w, CV_8UC1)*255;
@ -177,6 +189,24 @@ TEST(GArray, TestIntermediateOutput)
EXPECT_EQ(10, out_count[0]); EXPECT_EQ(10, out_count[0]);
} }
TEST(GArray, TestGArrayGArrayKernelInput)
{
cv::GMat in;
auto contours = cv::gapi::findContours(in, cv::RETR_EXTERNAL, cv::CHAIN_APPROX_NONE);
auto out = ThisTest::CountContours::on(contours);
cv::GComputation c(GIn(in), GOut(out));
// Create input - two filled rectangles
cv::Mat in_mat = cv::Mat::zeros(50, 50, CV_8UC1);
cv::rectangle(in_mat, cv::Point{5,5}, cv::Point{20,20}, 255, cv::FILLED);
cv::rectangle(in_mat, cv::Point{25,25}, cv::Point{40,40}, 255, cv::FILLED);
size_t out_count = 0u;
c.apply(gin(in_mat), gout(out_count), cv::compile_args(cv::gapi::kernels<OCVCountContours>()));
EXPECT_EQ(2u, out_count) << "Two contours must be found";
}
TEST(GArray, GArrayConstValInitialization) TEST(GArray, GArrayConstValInitialization)
{ {
std::vector<cv::Point> initial_vec {Point(0,0), Point(1,1), Point(2,2)}; std::vector<cv::Point> initial_vec {Point(0,0), Point(1,1), Point(2,2)};